ObjectDisposedException.ThrowIf wrongly used

Hirogen · Hirogen · commit ccf2a769125b · 2025-06-03T13:18:16.000+02:00
diff --git a/src/LogExpert.Core/Classes/Log/PositionAwareStreamReaderBase.cs b/src/LogExpert.Core/Classes/Log/PositionAwareStreamReaderBase.cs
@@ -94,7 +94,7 @@ protected override void Dispose (bool disposing)
     //TODO This is unsafe and should be refactored
     public override unsafe int ReadChar ()
     {
-        ObjectDisposedException.ThrowIf(true, ToString());
+        ObjectDisposedException.ThrowIf(IsDisposed, GetType().ToString());
 
         try
         {
@@ -126,9 +126,8 @@ protected virtual void ResetReader ()
 
     protected StreamReader GetStreamReader ()
     {
-        return IsDisposed
-            ? throw new ObjectDisposedException(ToString())
-            : _reader;
+        ObjectDisposedException.ThrowIf(IsDisposed, GetType().ToString());
+        return _reader;
     }
 
     protected void MovePosition (int offset)

Original file line number	Diff line number	Diff line change
`@@ -94,7 +94,7 @@ protected override void Dispose (bool disposing)`
`94`	`94`	`//TODO This is unsafe and should be refactored`
`95`	`95`	`public override unsafe int ReadChar ()`
`96`	`96`	`{`
`97`		`- ObjectDisposedException.ThrowIf(true, ToString());`
	`97`	`+ ObjectDisposedException.ThrowIf(IsDisposed, GetType().ToString());`
`98`	`98`
`99`	`99`	`try`
`100`	`100`	`{`
`@@ -126,9 +126,8 @@ protected virtual void ResetReader ()`
`126`	`126`
`127`	`127`	`protected StreamReader GetStreamReader ()`
`128`	`128`	`{`
`129`		`- return IsDisposed`
`130`		`- ? throw new ObjectDisposedException(ToString())`
`131`		`- : _reader;`
	`129`	`+ ObjectDisposedException.ThrowIf(IsDisposed, GetType().ToString());`
	`130`	`+ return _reader;`
`132`	`131`	`}`
`133`	`132`
`134`	`133`	`protected void MovePosition (int offset)`