error fix

Author: BRUNER Patrick

src/FlashIconHighlighter/FlashIconHighlighter.csproj

@@ -7,8 +7,14 @@
     <ImportWindowsDesktopTargets>true</ImportWindowsDesktopTargets>
     <OutputPath>$(SolutionDir)..\bin\$(Configuration)\plugins</OutputPath>
     <AllowUnsafeBlocks>true</AllowUnsafeBlocks>
+    <AssemblyTitle>FlashIconHighlighter</AssemblyTitle>
+    <RootNamespace>FlashIconHighlighter</RootNamespace>
   </PropertyGroup>
 
+  <ItemGroup>
+    <PackageReference Include="Vanara.PInvoke.User32" />
+  </ItemGroup>
+
   <ItemGroup>
     <ProjectReference Include="..\ColumnizerLib\ColumnizerLib.csproj" />
   </ItemGroup>

src/FlashIconHighlighter/FlashIconPlugin.cs

@@ -1,10 +1,10 @@
-using System;
 using System.Runtime.InteropServices;
 using System.Runtime.Versioning;
-using System.Windows.Forms;
 
 using ColumnizerLib;
 
+using static Vanara.PInvoke.User32;
+
 [assembly: SupportedOSPlatform("windows")]
 namespace FlashIconHighlighter;
 
@@ -18,29 +18,33 @@ internal class FlashIconPlugin : IKeywordAction
 
     #region IKeywordAction Member
 
-    public void Execute (string keyword, string param, ILogExpertCallback callback, ILogLineMemoryColumnizer columnizer)
+    public void Execute (string keyword, string param, ILogExpertCallbackMemory callback, ILogLineMemoryColumnizer columnizer)
     {
         var openForms = Application.OpenForms;
         foreach (Form form in openForms)
         {
             if (form.TopLevel && form.Name.Equals("LogTabWindow", StringComparison.OrdinalIgnoreCase) && form.Text.Contains(callback.GetFileName(), StringComparison.Ordinal))
             {
-                form.BeginInvoke(FlashWindow, [form]);
+                _ = form.BeginInvoke(FlashWindow, [form]);
             }
         }
     }
 
+    /// <summary>
+    /// Flash Window http://blogs.x2line.com/al/archive/2008/04/19/3392.aspx
+    /// </summary>
+    /// <param name="form"></param>
     private void FlashWindow (Form form)
     {
         FLASHWINFO fw = new()
         {
-            cbSize = Convert.ToUInt32(Marshal.SizeOf(typeof(FLASHWINFO))),
+            cbSize = Convert.ToUInt32(Marshal.SizeOf<FLASHWINFO>()),
             hwnd = form.Handle,
-            dwFlags = 14,
+            dwFlags = FLASHW.FLASHW_TRAY | FLASHW.FLASHW_CAPTION | FLASHW.FLASHW_TIMER,
             uCount = 0
         };
 
-        Win32Stuff.FlashWindowEx(ref fw);
+        _ = FlashWindowEx(fw);
     }
 
     public string GetDescription ()

src/FlashIconHighlighter/Win32Stuff.cs

@@ -13,14 +13,16 @@ public class LedIndicatorServiceTests
 {
     private LedIndicatorService? _service;
     private ApplicationContext? _appContext;
+    private WindowsFormsSynchronizationContext? _syncContext;
 
     [SetUp]
     public void Setup ()
     {
         // Ensure we have a WindowsFormsSynchronizationContext for the UI thread
         if (SynchronizationContext.Current == null)
         {
-            SynchronizationContext.SetSynchronizationContext(new WindowsFormsSynchronizationContext());
+            _syncContext = new WindowsFormsSynchronizationContext();
+            SynchronizationContext.SetSynchronizationContext(_syncContext);
         }
 
         // Create an application context to ensure we have a proper UI context
@@ -35,6 +37,7 @@ public void TearDown ()
     {
         _service?.Dispose();
         _appContext?.Dispose();
+        _syncContext?.Dispose();
     }
 
     [Test]

src/LogExpert.Tests/Services/LedIndicatorServiceTests.cs

@@ -10,7 +10,7 @@
 namespace LogExpert.UI.Services;
 
 [SupportedOSPlatform("windows")]
-internal sealed class LedIndicatorService : ILedIndicatorService
+internal sealed class LedIndicatorService : ILedIndicatorService, IDisposable
 {
     private static readonly Logger _logger = LogManager.GetCurrentClassLogger();