feat: Global Settings should override pre-repository settings

Author: LonoxX

README.md

@@ -14,9 +14,6 @@ The configurations are heavily inspired by https://github.com/schaier-io, includ
 ## 🚀 Installation
 
 ### Via Obsidian Community Plugins
-
-> **Note:** This plugin is not yet available in the Community Plugins list.
-
 1. Open Obsidian settings
 2. Navigate to **Community Plugins**
 3. Click **Browse** and search for "GitHub Issues"

manifest.json

@@ -1,7 +1,7 @@
 {
 	"id": "github-issues",
 	"name": "Github Issues",
-	"version": "1.0.4",
+	"version": "1.2.3",
 	"minAppVersion": "0.15.0",
 	"description": "Track Github Issues and pull requests directly in your vault",
 	"author": "LonoxX",

package.json

@@ -1,6 +1,6 @@
 {
 	"name": "github-issues",
-	"version": "1.0.4",
+	"version": "1.2.3",
 	"description": "Track GitHub issues and pull requests in Obsidian",
 	"main": "main.js",
 	"scripts": {

src/file-manager.ts

@@ -13,6 +13,7 @@ import {
 	processContentTemplate,
 	extractNumberFromFilename
 } from "./util/templateUtils";
+import { getEffectiveRepoSettings } from "./util/settingsUtils";
 
 export class FileManager {
 	constructor(
@@ -50,12 +51,15 @@ export class FileManager {
 		allIssuesIncludingRecentlyClosed: any[],
 		_currentIssueNumbers: Set<string>,
 	): Promise<void> {
-		const [owner, repoName] = repo.repository.split("/");
+		// Apply global defaults to repository settings
+		const effectiveRepo = getEffectiveRepoSettings(repo, this.settings.globalDefaults);
+
+		const [owner, repoName] = effectiveRepo.repository.split("/");
 		if (!owner || !repoName) return;
 		const repoCleaned = repoName.replace(/\//g, "-");
 		const ownerCleaned = owner.replace(/\//g, "-");
 		await this.cleanupDeletedIssues(
-			repo,
+			effectiveRepo,
 			ownerCleaned,
 			repoCleaned,
 			allIssuesIncludingRecentlyClosed,
@@ -64,7 +68,7 @@ export class FileManager {
 		// Create or update issue files for open issues
 		for (const issue of openIssues) {
 			await this.createOrUpdateIssueFile(
-				repo,
+				effectiveRepo,
 				ownerCleaned,
 				repoCleaned,
 				issue,
@@ -81,22 +85,25 @@ export class FileManager {
 		allPullRequestsIncludingRecentlyClosed: any[],
 		_currentPRNumbers: Set<string>,
 	): Promise<void> {
-		const [owner, repoName] = repo.repository.split("/");
+		// Apply global defaults to repository settings
+		const effectiveRepo = getEffectiveRepoSettings(repo, this.settings.globalDefaults);
+
+		const [owner, repoName] = effectiveRepo.repository.split("/");
 		if (!owner || !repoName) return;
 
 		const repoCleaned = repoName.replace(/\//g, "-");
 		const ownerCleaned = owner.replace(/\//g, "-");
 
 		await this.cleanupDeletedPullRequests(
-			repo,
+			effectiveRepo,
 			ownerCleaned,
 			repoCleaned,
 			allPullRequestsIncludingRecentlyClosed,
 		);
 
 		for (const pr of openPullRequests) {
 			await this.createOrUpdatePullRequestFile(
-				repo,
+				effectiveRepo,
 				ownerCleaned,
 				repoCleaned,
 				pr,
@@ -565,6 +572,12 @@ export class FileManager {
 	}
 
 	private async ensureFolderExists(path: string): Promise<void> {
+		// Guard against undefined or empty paths
+		if (!path || path.trim() === "") {
+			this.noticeManager.error("Cannot create folder: path is empty or undefined");
+			return;
+		}
+
 		const folder = this.app.vault.getAbstractFileByPath(path);
 		if (!folder) {
 			try {

src/main.ts

@@ -257,9 +257,19 @@ export default class GitHubTrackerPlugin extends Plugin {
 		const loadedData = await this.loadData();
 		this.settings = Object.assign({}, DEFAULT_SETTINGS, loadedData);
 
+		// Ensure globalDefaults exists (migration for existing users)
+		if (!this.settings.globalDefaults) {
+			this.settings.globalDefaults = Object.assign({}, DEFAULT_SETTINGS.globalDefaults);
+		}
+
 		// Migrate existing repositories to include new custom folder properties
+		// Defaults first, then override with saved values
 		this.settings.repositories = this.settings.repositories.map(repo => {
-			return Object.assign({}, DEFAULT_REPOSITORY_TRACKING, repo);
+			const merged = Object.assign({}, DEFAULT_REPOSITORY_TRACKING, repo);
+			// Ensure critical fields are never undefined
+			if (!merged.issueFolder) merged.issueFolder = DEFAULT_REPOSITORY_TRACKING.issueFolder;
+			if (!merged.pullRequestFolder) merged.pullRequestFolder = DEFAULT_REPOSITORY_TRACKING.pullRequestFolder;
+			return merged;
 		});
 	}