refactor: 9round 리팩토링

Author: adminhelper

apps/commerce-api/src/main/java/com/loopers/application/order/OrderFacade.java

@@ -88,7 +88,7 @@ public OrderInfo createOrder(CreateOrderCommand command) {
                         command.userId(),
                         orderReference,
                         cardType,
-                        paymentCommand.cardNo(),
+                        maskCardNumber(paymentCommand.cardNo()),
                         saved.getTotalAmount(),
                         callbackUrl
                 )
@@ -97,6 +97,13 @@ public OrderInfo createOrder(CreateOrderCommand command) {
         return OrderInfo.from(saved);
     }
 
+    private String maskCardNumber(String cardNo) {
+        if (cardNo == null || cardNo.length() < 4) {
+            return "****";
+        }
+        return "*".repeat(cardNo.length() - 4) + cardNo.substring(cardNo.length() - 4);
+    }
+
     private String createOrderReference(Long orderId) {
         return "order-" + orderId;
     }

apps/commerce-api/src/main/java/com/loopers/application/order/OrderPaymentCommand.java

@@ -3,4 +3,10 @@
 public record OrderPaymentCommand(
         String cardType,
         String cardNo
-) {}
+) {
+    @Override
+    public String toString() {
+        return "OrderPaymentCommand[cardType=" + cardType +
+                ", cardNo=****" + (cardNo != null && cardNo.length() > 4 ? cardNo.substring(cardNo.length() - 4) : "") + "]";
+    }
+}

apps/commerce-api/src/main/java/com/loopers/application/order/OrderPaymentProcessor.java

@@ -62,6 +62,11 @@ public void syncPayment(Long orderId) {
         }
 
         PgPaymentV1Dto.TransactionRecord record = data.transactions().get(data.transactions().size() - 1);
+
+        if (payment.getTransactionKey() != null && payment.getTransactionKey().equals(record.transactionKey())) {
+            log.info("이미 처리된 결제입니다. orderId={}, transactionKey={}", orderId, record.transactionKey());
+            return;
+        }
         applyPaymentResult(order, payment, record.status(), record.transactionKey(), record.reason());
     }
 

apps/commerce-api/src/main/java/com/loopers/application/ranking/RankingFacade.java

@@ -11,6 +11,7 @@
 import org.springframework.transaction.annotation.Transactional;
 
 import java.util.List;
+import java.util.Objects;
 import java.util.stream.Collectors;
 
 @Service
@@ -26,6 +27,7 @@ public List<RankingInfo> getRankingItems(String date, int page, int size) {
         return rankingService.getRankingRows(date, page, size)
                 .stream()
                 .map(this::toDto)
+                .filter(Objects::nonNull)
                 .collect(Collectors.toList());
     }
 
@@ -50,7 +52,7 @@ private RankingInfo toDto(RankingRow row) {
         if (row.productId() == null) {
             return null;
         }
-        
+
         Product product = productService.getProduct(row.productId());
         ProductInfo productInfo = ProductInfo.of(product, brandService.getBrand(product.getBrandId()));
         return new RankingInfo(row.rank(), row.score(), productInfo);

apps/commerce-api/src/main/java/com/loopers/application/user/UserFacade.java

@@ -7,13 +7,15 @@
 import com.loopers.support.error.ErrorType;
 import lombok.RequiredArgsConstructor;
 import org.springframework.stereotype.Component;
+import org.springframework.transaction.annotation.Transactional;
 
 @RequiredArgsConstructor
 @Component
 public class UserFacade {
     private final UserService userService;
     private final PointService pointService;
 
+    @Transactional
     public UserInfo register(String userId, String email, String birth, String gender) {
         User user = userService.register(userId, email, birth, gender);
         pointService.initPoint(user.getUserId());

apps/commerce-api/src/main/java/com/loopers/infrastructure/outbox/OutboxEventPublisher.java

@@ -11,7 +11,6 @@
 import org.springframework.kafka.core.KafkaTemplate;
 import org.springframework.scheduling.annotation.Scheduled;
 import org.springframework.stereotype.Component;
-import org.springframework.transaction.annotation.Transactional;
 
 import java.util.List;
 
@@ -34,7 +33,6 @@ void logConfiguration() {
     }
 
     @Scheduled(fixedDelayString = "${outbox.publisher.fixed-delay-ms:1000}")
-    @Transactional
     public void publishPendingEvents() {
         if (!publisherEnabled) {
             return;

apps/commerce-streamer/src/main/java/com/loopers/interfaces/consumer/CatalogMetricsConsumer.java

@@ -3,8 +3,8 @@
 import com.loopers.confg.kafka.KafkaConfig;
 import com.loopers.domain.event.EventHandledService;
 import com.loopers.domain.metrics.ProductMetricsService;
-import com.loopers.ranking.RankingService;
 import com.loopers.interfaces.consumer.message.CatalogEventMessage;
+import com.loopers.ranking.RankingService;
 import lombok.RequiredArgsConstructor;
 import lombok.extern.slf4j.Slf4j;
 import org.springframework.kafka.annotation.KafkaListener;
@@ -40,7 +40,7 @@ public void consume(
 
         try {
             for (CatalogEventMessage message : messages) {
-                if (message == null || message.eventId() == null) {
+                if (!isValid(message)) {
                     continue;
                 }
                 if (eventHandledService.isHandled(message.eventId())) {
@@ -66,4 +66,10 @@ public void consume(
             throw exception;
         }
     }
+
+    private boolean isValid(CatalogEventMessage message) {
+        return message != null
+                && message.eventId() != null
+                && message.productId() != null;
+    }
 }

apps/pg-simulator/src/main/resources/application.yml

@@ -14,7 +14,7 @@ spring:
   main:
     web-application-type: servlet
   application:
-    name: commerce-api
+    name: pg-simulator
   profiles:
     active: local
   config:
@@ -24,11 +24,6 @@ spring:
       - logging.yml
       - monitoring.yml
 
-datasource:
-  mysql-jpa:
-    main:
-      jdbc-url: jdbc:mysql://localhost:3306/paymentgateway
-
 springdoc:
   use-fqn: true
   swagger-ui:
@@ -40,6 +35,11 @@ spring:
     activate:
       on-profile: local, test
 
+datasource:
+  mysql-jpa:
+    main:
+      jdbc-url: jdbc:mysql://localhost:3306/paymentgateway
+
 server:
   port: 8082
 

modules/redis/src/main/java/com/loopers/ranking/RankingScorePolicy.java

@@ -2,6 +2,8 @@
 
 import org.springframework.stereotype.Component;
 
+import java.math.BigDecimal;
+
 @Component
 public class RankingScorePolicy {
 
@@ -21,6 +23,9 @@ public double orderScore(Long price, Long quantity) {
         if (price == null || quantity == null || price <= 0 || quantity <= 0) {
             return 0d;
         }
-        return price * quantity * ORDER_WEIGHT;
+        return BigDecimal.valueOf(price)
+                .multiply(BigDecimal.valueOf(quantity))
+                .multiply(BigDecimal.valueOf(ORDER_WEIGHT))
+                .doubleValue();
     }
 }