Merge pull request #16 from Kimjipang/round08

Round08

Author: Kimjipang

apps/commerce-api/src/main/java/com/loopers/application/event/payment/PaymentEventHandler.java

@@ -24,11 +24,15 @@ public PaymentV1Dto.TransactionResponse requestPayment(String userId, PaymentV1D
         PaymentV1Dto.PaymentRequest paymentRequest = new PaymentV1Dto.PaymentRequest(
                 userId,
                 pgPaymentRequest.orderId(),
-                response.transactionKey(),
-                PaymentStatus.PENDING
+                response.transactionKey()
         );
 
-        Payment payment = Payment.create(paymentRequest);
+        Payment payment = Payment.create(
+                paymentRequest.userId(),
+                paymentRequest.orderNo(),
+                paymentRequest.transactionKey(),
+                PaymentStatus.PENDING
+        );
         paymentRepository.save(payment);
 
         return response;

apps/commerce-api/src/main/java/com/loopers/application/payment/PaymentFacade.java

@@ -7,7 +7,6 @@
 import com.loopers.domain.outbox.OutboxRepository;
 import com.loopers.domain.product.Product;
 import com.loopers.domain.product.ProductRepository;
-import com.loopers.infrastructure.product.ProductViewKafkaProducer;
 import com.loopers.interfaces.api.product.ProductV1Dto;
 import com.loopers.support.error.CoreException;
 import com.loopers.support.error.ErrorType;
@@ -26,7 +25,6 @@ public class ProductFacade {
     private final ProductRepository productRepository;
     private final BrandRepository brandRepository;
     private final OutboxRepository outBoxRepository;
-    private final ProductViewKafkaProducer kafkaProducer;
 
     @Transactional
     public ProductInfo registerProduct(ProductV1Dto.ProductRequest request) {

apps/commerce-api/src/main/java/com/loopers/application/product/ProductFacade.java

@@ -1,7 +1,6 @@
 package com.loopers.domain.payment;
 
 import com.loopers.domain.BaseEntity;
-import com.loopers.interfaces.api.payment.PaymentV1Dto;
 import jakarta.persistence.Column;
 import jakarta.persistence.Entity;
 import jakarta.persistence.EnumType;
@@ -37,11 +36,11 @@ public Payment(String userId, String orderNo, String transactionKey, PaymentStat
         this.status = status;
     }
 
-    public static Payment create(PaymentV1Dto.PaymentRequest request) {
+    public static Payment create(String userId, String orderNo, String transactionKey, PaymentStatus status) {
         return new Payment(
-                request.userId(),
-                request.orderNo(),
-                request.transactionKey(),
+                userId,
+                orderNo,
+                transactionKey,
                 PaymentStatus.PENDING
         );
     }

apps/commerce-api/src/main/java/com/loopers/domain/payment/Payment.java

@@ -1,8 +1,5 @@
 package com.loopers.interfaces.api.payment;
 
-
-import com.loopers.domain.payment.PaymentStatus;
-
 public class PaymentV1Dto {
     public record TransactionResponse(
             String transactionKey,
@@ -30,6 +27,6 @@ public enum CardTypeDto {
         HYUNDAI
     }
 
-    public record PaymentRequest(String userId, String orderNo, String transactionKey, PaymentStatus status) {
+    public record PaymentRequest(String userId, String orderNo, String transactionKey) {
     }
 }

apps/commerce-api/src/main/java/com/loopers/infrastructure/product/ProductViewKafkaProducer.java

@@ -43,8 +43,8 @@ resilience4j:
   circuitbreaker:
     instances:
       pgCircuit:
-        sliding-window-size: 5
-        failure-rate-threshold: 20       # 실패율이 50% 넘으면 Open
+        sliding-window-size: 10
+        failure-rate-threshold: 50       # 실패율이 50% 넘으면 Open
         wait-duration-in-open-state: 60s # Open 상태 유지 시간
         permitted-number-of-calls-in-half-open-state: 2
         slow-call-duration-threshold: 2s

apps/commerce-api/src/main/java/com/loopers/interfaces/api/payment/PaymentV1Dto.java

@@ -12,6 +12,7 @@
 import org.springframework.kafka.annotation.KafkaListener;
 import org.springframework.kafka.support.Acknowledgment;
 import org.springframework.stereotype.Component;
+import org.springframework.transaction.annotation.Transactional;
 
 import java.util.List;
 
@@ -25,6 +26,7 @@ public class KafkaOutboxConsumer {
             topics = {"product-viewed"},
             containerFactory = KafkaConfig.BATCH_LISTENER
     )
+    @Transactional
     public void demoListener(
             List<ConsumerRecord<String, String>> messages,
             Acknowledgment acknowledgment