feat(ranking): 주간 랭킹 조회 API 페이징 처리 추가

hyujikoh · hyujikoh · commit 58639157a0d0 · 2026-01-02T22:26:12.000+09:00
- 주간 랭킹 조회 시 페이징 기능을 추가하여 성능 개선
- 관련 메서드 및 리포지토리 수정
diff --git a/apps/commerce-api/src/main/java/com/loopers/application/ranking/WeeklyRankingService.java b/apps/commerce-api/src/main/java/com/loopers/application/ranking/WeeklyRankingService.java
@@ -37,27 +37,14 @@ public Page<WeeklyRankEntity> getWeeklyRanking(String yearWeek, Pageable pageabl
                 yearWeek, pageable.getPageNumber(), pageable.getPageSize());
 
         // 1. 전체 랭킹 조회 (순위 순으로 정렬됨)
-        List<WeeklyRankEntity> allRankings = weeklyRankRepository.findByYearWeek(yearWeek);
+        Page<WeeklyRankEntity> pagedRankings = weeklyRankRepository.findByYearWeek(yearWeek , pageable);
 
-        if (allRankings.isEmpty()) {
+        if (pagedRankings.isEmpty()) {
             log.debug("주간 랭킹 데이터 없음: yearWeek={}", yearWeek);
             return Page.empty(pageable);
         }
 
-        // 2. 페이징 처리
-        int start = (int) pageable.getOffset();
-        int end = Math.min(start + pageable.getPageSize(), allRankings.size());
-
-        if (start >= allRankings.size()) {
-            return Page.empty(pageable);
-        }
-
-        List<WeeklyRankEntity> pagedRankings = allRankings.subList(start, end);
-
-        log.debug("주간 랭킹 조회 완료: yearWeek={}, 전체={}, 페이지={}",
-                yearWeek, allRankings.size(), pagedRankings.size());
-
-        return new PageImpl<>(pagedRankings, pageable, allRankings.size());
+        return pagedRankings;
     }
 
     /**
diff --git a/apps/commerce-api/src/main/java/com/loopers/infrastructure/ranking/WeeklyRankJpaRepository.java b/apps/commerce-api/src/main/java/com/loopers/infrastructure/ranking/WeeklyRankJpaRepository.java
@@ -2,6 +2,7 @@
 
 import java.util.List;
 
+import org.springframework.data.domain.Page;
 import org.springframework.data.domain.Pageable;
 import org.springframework.data.jpa.repository.JpaRepository;
 import org.springframework.data.jpa.repository.Modifying;
@@ -26,7 +27,7 @@ public interface WeeklyRankJpaRepository extends JpaRepository<WeeklyRankEntity,
      * 특정 주차의 랭킹을 순위 순으로 페이지네이션하여 조회합니다.
      */
     @Query("SELECT w FROM WeeklyRankEntity w WHERE w.id.yearWeek = :yearWeek ORDER BY w.rankPosition ASC")
-    List<WeeklyRankEntity> findByIdYearWeekOrderByRankPosition(@Param("yearWeek") String yearWeek, Pageable pageable);
+    Page<WeeklyRankEntity> findByIdYearWeekOrderByRankPosition(@Param("yearWeek") String yearWeek, Pageable pageable);
 
     /**
      * 특정 주차의 모든 랭킹을 삭제합니다.
diff --git a/apps/commerce-api/src/main/java/com/loopers/infrastructure/ranking/WeeklyRankRepositoryImpl.java b/apps/commerce-api/src/main/java/com/loopers/infrastructure/ranking/WeeklyRankRepositoryImpl.java
@@ -2,6 +2,7 @@
 
 import java.util.List;
 
+import org.springframework.data.domain.Page;
 import org.springframework.data.domain.PageRequest;
 import org.springframework.data.domain.Pageable;
 import org.springframework.stereotype.Repository;
@@ -34,15 +35,13 @@ public List<WeeklyRankEntity> saveAll(List<WeeklyRankEntity> entities) {
     public List<WeeklyRankEntity> findByYearWeek(String yearWeek) {
         return jpaRepository.findByIdYearWeekOrderByRankPosition(yearWeek);
     }
-
     @Override
-    public List<WeeklyRankEntity> findByYearWeekWithPagination(String yearWeek, int page, int size) {
-        Pageable pageable = PageRequest.of(page, size);
-        return jpaRepository.findByIdYearWeekOrderByRankPosition(yearWeek, pageable);
+    public long deleteByYearWeek(String yearWeek) {
+        return jpaRepository.deleteByIdYearWeek(yearWeek);
     }
 
     @Override
-    public long deleteByYearWeek(String yearWeek) {
-        return jpaRepository.deleteByIdYearWeek(yearWeek);
+    public Page<WeeklyRankEntity> findByYearWeek(String yearWeek, Pageable pageable) {
+        return jpaRepository.findByIdYearWeekOrderByRankPosition(yearWeek, pageable);
     }
 }
diff --git a/apps/commerce-api/src/test/java/com/loopers/interfaces/api/ranking/RankingApiE2ETest.java b/apps/commerce-api/src/test/java/com/loopers/interfaces/api/ranking/RankingApiE2ETest.java
@@ -150,8 +150,8 @@ void should_return_products_in_ranking_order() {
                     () -> assertThat(response.getStatusCode()).isEqualTo(HttpStatus.OK),
                     () -> assertThat(Objects.requireNonNull(response.getBody()).data().content()).hasSize(3),
                     () -> assertThat(Objects.requireNonNull(response.getBody()).data().content().get(0).productId()).isEqualTo(product1),
-                    () -> assertThat(Objects.requireNonNull(response.getBody()).data().content().get(2).productId()).isEqualTo(product2),
-                    () -> assertThat(Objects.requireNonNull(response.getBody()).data().content().get(1).productId()).isEqualTo(product3)
+                    () -> assertThat(Objects.requireNonNull(response.getBody()).data().content().get(1).productId()).isEqualTo(product3),
+                    () -> assertThat(Objects.requireNonNull(response.getBody()).data().content().get(2).productId()).isEqualTo(product2)
             );
         }
 
diff --git a/apps/commerce-batch/src/main/java/com/loopers/infrastructure/ranking/WeeklyRankJpaRepository.java b/apps/commerce-batch/src/main/java/com/loopers/infrastructure/ranking/WeeklyRankJpaRepository.java
@@ -2,6 +2,7 @@
 
 import java.util.List;
 
+import org.springframework.data.domain.Page;
 import org.springframework.data.domain.Pageable;
 import org.springframework.data.jpa.repository.JpaRepository;
 import org.springframework.data.jpa.repository.Modifying;
@@ -26,7 +27,7 @@ public interface WeeklyRankJpaRepository extends JpaRepository<WeeklyRankEntity,
      * 특정 주차의 랭킹을 순위 순으로 페이지네이션하여 조회합니다.
      */
     @Query("SELECT w FROM WeeklyRankEntity w WHERE w.id.yearWeek = :yearWeek ORDER BY w.rankPosition ASC")
-    List<WeeklyRankEntity> findByIdYearWeekOrderByRankPosition(@Param("yearWeek") String yearWeek, Pageable pageable);
+    Page<WeeklyRankEntity> findByIdYearWeekOrderByRankPosition(@Param("yearWeek") String yearWeek, Pageable pageable);
 
     /**
      * 특정 주차의 모든 랭킹을 삭제합니다.
diff --git a/apps/commerce-batch/src/main/java/com/loopers/infrastructure/ranking/WeeklyRankRepositoryImpl.java b/apps/commerce-batch/src/main/java/com/loopers/infrastructure/ranking/WeeklyRankRepositoryImpl.java
@@ -2,6 +2,7 @@
 
 import java.util.List;
 
+import org.springframework.data.domain.Page;
 import org.springframework.data.domain.PageRequest;
 import org.springframework.data.domain.Pageable;
 import org.springframework.stereotype.Repository;
@@ -36,13 +37,12 @@ public List<WeeklyRankEntity> findByYearWeek(String yearWeek) {
     }
 
     @Override
-    public List<WeeklyRankEntity> findByYearWeekWithPagination(String yearWeek, int page, int size) {
-        Pageable pageable = PageRequest.of(page, size);
-        return jpaRepository.findByIdYearWeekOrderByRankPosition(yearWeek, pageable);
+    public long deleteByYearWeek(String yearWeek) {
+        return jpaRepository.deleteByIdYearWeek(yearWeek);
     }
 
     @Override
-    public long deleteByYearWeek(String yearWeek) {
-        return jpaRepository.deleteByIdYearWeek(yearWeek);
+    public Page<WeeklyRankEntity> findByYearWeek(String yearWeek, Pageable pageable) {
+        return jpaRepository.findByIdYearWeekOrderByRankPosition(yearWeek, pageable);
     }
 }
diff --git a/modules/jpa/src/main/java/com/loopers/domain/ranking/WeeklyRankRepository.java b/modules/jpa/src/main/java/com/loopers/domain/ranking/WeeklyRankRepository.java
@@ -2,6 +2,9 @@
 
 import java.util.List;
 
+import org.springframework.data.domain.Page;
+import org.springframework.data.domain.Pageable;
+
 /**
  * 주간 랭킹 Repository 인터페이스
  */
@@ -22,16 +25,13 @@ public interface WeeklyRankRepository {
      */
     List<WeeklyRankEntity> findByYearWeek(String yearWeek);
 
-    /**
-     * 특정 주차의 랭킹을 페이지네이션하여 조회합니다.
-     */
-    List<WeeklyRankEntity> findByYearWeekWithPagination(String yearWeek, int page, int size);
-
     /**
      * 특정 주차의 모든 랭킹을 삭제합니다. (멱등성 보장용)
      * 
      * @param yearWeek 삭제할 주차 (예: "2024-W52")
      * @return 삭제된 레코드 수
      */
     long deleteByYearWeek(String yearWeek);
+
+    Page<WeeklyRankEntity> findByYearWeek(String yearWeek, Pageable pageable);
 }

Original file line number	Diff line number	Diff line change
`@@ -2,6 +2,7 @@`
`2`	`2`
`3`	`3`	`import java.util.List;`
`4`	`4`
	`5`	`+import org.springframework.data.domain.Page;`
`5`	`6`	`import org.springframework.data.domain.PageRequest;`
`6`	`7`	`import org.springframework.data.domain.Pageable;`
`7`	`8`	`import org.springframework.stereotype.Repository;`
`@@ -34,15 +35,13 @@ public List<WeeklyRankEntity> saveAll(List<WeeklyRankEntity> entities) {`
`34`	`35`	`public List<WeeklyRankEntity> findByYearWeek(String yearWeek) {`
`35`	`36`	`return jpaRepository.findByIdYearWeekOrderByRankPosition(yearWeek);`
`36`	`37`	`}`
`37`		`-`
`38`	`38`	`@Override`
`39`		`- public List<WeeklyRankEntity> findByYearWeekWithPagination(String yearWeek, int page, int size) {`
`40`		`- Pageable pageable = PageRequest.of(page, size);`
`41`		`- return jpaRepository.findByIdYearWeekOrderByRankPosition(yearWeek, pageable);`
	`39`	`+ public long deleteByYearWeek(String yearWeek) {`
	`40`	`+ return jpaRepository.deleteByIdYearWeek(yearWeek);`
`42`	`41`	`}`
`43`	`42`
`44`	`43`	`@Override`
`45`		`- public long deleteByYearWeek(String yearWeek) {`
`46`		`- return jpaRepository.deleteByIdYearWeek(yearWeek);`
	`44`	`+ public Page<WeeklyRankEntity> findByYearWeek(String yearWeek, Pageable pageable) {`
	`45`	`+ return jpaRepository.findByIdYearWeekOrderByRankPosition(yearWeek, pageable);`
`47`	`46`	`}`
`48`	`47`	`}`