Skip to content

Commit 6f4cdff

Browse files
committed
refactor: 레이어 의존성 수정
**AS-IS** domain 레이어에서 외부 레이어를 의존하는 형태 **TO-BE** create() 메서드의 파라미터를 원시 값으로 받도록 수정 -> domain 에서 interfaces 레이어를 의존하는 것을 끊어냄.
1 parent c261145 commit 6f4cdff

2 files changed

Lines changed: 11 additions & 8 deletions

File tree

apps/commerce-api/src/main/java/com/loopers/application/payment/PaymentFacade.java

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,11 +24,15 @@ public PaymentV1Dto.TransactionResponse requestPayment(String userId, PaymentV1D
2424
PaymentV1Dto.PaymentRequest paymentRequest = new PaymentV1Dto.PaymentRequest(
2525
userId,
2626
pgPaymentRequest.orderId(),
27-
response.transactionKey(),
28-
PaymentStatus.PENDING
27+
response.transactionKey()
2928
);
3029

31-
Payment payment = Payment.create(paymentRequest);
30+
Payment payment = Payment.create(
31+
paymentRequest.userId(),
32+
paymentRequest.orderNo(),
33+
paymentRequest.transactionKey(),
34+
PaymentStatus.PENDING
35+
);
3236
paymentRepository.save(payment);
3337

3438
return response;

apps/commerce-api/src/main/java/com/loopers/domain/payment/Payment.java

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
package com.loopers.domain.payment;
22

33
import com.loopers.domain.BaseEntity;
4-
import com.loopers.interfaces.api.payment.PaymentV1Dto;
54
import jakarta.persistence.Column;
65
import jakarta.persistence.Entity;
76
import jakarta.persistence.EnumType;
@@ -37,11 +36,11 @@ public Payment(String userId, String orderNo, String transactionKey, PaymentStat
3736
this.status = status;
3837
}
3938

40-
public static Payment create(PaymentV1Dto.PaymentRequest request) {
39+
public static Payment create(String userId, String orderNo, String transactionKey, PaymentStatus status) {
4140
return new Payment(
42-
request.userId(),
43-
request.orderNo(),
44-
request.transactionKey(),
41+
userId,
42+
orderNo,
43+
transactionKey,
4544
PaymentStatus.PENDING
4645
);
4746
}

0 commit comments

Comments
 (0)