Skip to content

Commit cea0a6f

Browse files
committed
chore: 사용하지 않는 메서드 삭제
1 parent 99aa849 commit cea0a6f

5 files changed

Lines changed: 3 additions & 9 deletions

File tree

apps/commerce-api/src/main/java/com/loopers/domain/user/UserRepository.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,4 @@ public interface UserRepository {
1010
boolean existsByLoginId(String loginId);
1111

1212
Optional<UserEntity> findById(Long id);
13-
14-
Optional<UserEntity> findByLoginId(String loginId);
1513
}

apps/commerce-api/src/main/java/com/loopers/domain/user/UserService.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ public class UserService {
1212

1313
public UserEntity findUserByLoginId(String loginId) {
1414
return userRepository.findUserByLoginId(loginId).orElseThrow(
15-
() -> new CoreException(ErrorType.NOT_FOUND, "해당 이메일의 사용자가 존재하지 않습니다.")
15+
() -> new CoreException(ErrorType.NOT_FOUND, "해당 아이디의 사용자가 존재하지 않습니다.")
1616
);
1717
}
1818

apps/commerce-api/src/main/java/com/loopers/infrastructure/user/UserRepositoryImpl.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,4 @@ public Optional<UserEntity> findById(Long id) {
3434
return userJpaRepository.findById(id);
3535
}
3636

37-
@Override
38-
public Optional<UserEntity> findByLoginId(String loginId) {
39-
return userJpaRepository.findByLoginId(loginId);
40-
}
4137
}

apps/commerce-api/src/main/java/com/loopers/interfaces/api/user/UserV1Controller.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ public ApiResponse<UserV1Dto.UserResponse> signUp(@RequestBody UserV1Dto.SignUpR
2727
return ApiResponse.success(response);
2828
}
2929

30-
@GetMapping("/{loginId}")
30+
@GetMapping
3131
@Override
3232
public ApiResponse<UserV1Dto.UserResponse> findUserByLoginId(@RequestParam String loginId) {
3333
UserInfo userInfo = userFacade.findUserByLoginId(loginId);

apps/commerce-api/src/test/java/com/loopers/interfaces/api/UserV1ApiE2ETest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ void returnsUser_whenJoinSuccess() {
8989
);
9090

9191
// DB에도 실제로 저장됐는지 확인
92-
Optional<UserEntity> saved = userRepository.findByLoginId(request.loginId());
92+
Optional<UserEntity> saved = userRepository.findUserByLoginId(request.loginId());
9393
assertThat(saved).isPresent();
9494
}
9595

0 commit comments

Comments
 (0)