round1: 리뷰 적용 - JPA repo 구현체 분리

Author: JVHE

apps/commerce-api/src/main/java/com/loopers/domain/point/Point.java

@@ -9,7 +9,7 @@
 import lombok.Getter;
 
 @Entity
-@Table(name = "point")
+@Table(name = "tb_point")
 @Getter
 public class Point extends BaseEntity {
     @Column(name = "user_id", nullable = false, updatable = false, unique = true)

apps/commerce-api/src/main/java/com/loopers/domain/point/PointRepository.java

@@ -0,0 +1,9 @@
+package com.loopers.domain.point;
+
+import java.util.Optional;
+
+public interface PointRepository {
+    Optional<Point> findByUserId(Long userId);
+
+    void save(Point point);
+}

apps/commerce-api/src/main/java/com/loopers/domain/point/PointService.java

@@ -11,25 +11,25 @@
 @RequiredArgsConstructor
 @Service
 public class PointService {
-    private final PointJpaRepository pointJpaRepository;
+    private final PointRepository pointRepository;
 
     @Transactional
     public void createPoint(Long userId) {
         Point point = Point.create(userId);
-        pointJpaRepository.save(point);
+        pointRepository.save(point);
     }
 
     @Transactional
     public Long chargePoint(Long userId, int amount) {
-        Point point = pointJpaRepository.findByUserId(userId)
+        Point point = pointRepository.findByUserId(userId)
                 .orElseThrow(() -> new CoreException(ErrorType.NOT_FOUND, "포인트 정보를 찾을 수 없습니다."));
         point.charge(amount);
-        pointJpaRepository.save(point);
+        pointRepository.save(point);
         return point.getAmount();
     }
 
     @Transactional(readOnly = true)
     public Optional<Long> getCurrentPoint(Long userId) {
-        return pointJpaRepository.findByUserId(userId).map(Point::getAmount);
+        return pointRepository.findByUserId(userId).map(Point::getAmount);
     }
 }

apps/commerce-api/src/main/java/com/loopers/domain/user/User.java

@@ -10,7 +10,7 @@
 import org.apache.commons.lang3.StringUtils;
 
 @Entity
-@Table(name = "user")
+@Table(name = "tb_user")
 @Getter
 public class User extends BaseEntity {
     protected User() {

apps/commerce-api/src/main/java/com/loopers/domain/user/UserRepository.java

@@ -0,0 +1,13 @@
+package com.loopers.domain.user;
+
+import java.util.Optional;
+
+public interface UserRepository {
+    Optional<User> findByUserId(String userId);
+
+    Optional<User> findByUserIdForUpdate(String userId);
+
+    boolean existsUserByUserId(String userId);
+
+    User save(User user);
+}

apps/commerce-api/src/main/java/com/loopers/domain/user/UserService.java

@@ -11,27 +11,27 @@
 @RequiredArgsConstructor
 @Service
 public class UserService {
-    private final UserJpaRepository userJpaRepository;
+    private final UserRepository userRepository;
 
     @Transactional
     public User registerUser(String userId, String email, String birthday, String gender) {
         // 이미 등록된 userId 인 경우, 예외를 발생시킨다.
-        if (userJpaRepository.existsUserByUserId(userId)) {
+        if (userRepository.existsUserByUserId(userId)) {
             throw new CoreException(ErrorType.CONFLICT, "이미 존재하는 사용자 ID 입니다.");
         }
         User user = User.create(userId, email, birthday, gender);
-        return userJpaRepository.save(user);
+        return userRepository.save(user);
     }
 
     @Transactional(readOnly = true)
     public Optional<User> findByUserId(String userId) {
-        return userJpaRepository.findByUserId(userId);
+        return userRepository.findByUserId(userId);
     }
 
     // find by user id with lock for update
     @Transactional
     public Optional<User> findByUserIdForUpdate(String userId) {
-        return userJpaRepository.findByUserIdForUpdate(userId);
+        return userRepository.findByUserIdForUpdate(userId);
     }
 
 }

…ers/domain/point/PointJpaRepository.java …astructure/point/PointJpaRepository.javaapps/commerce-api/src/main/java/com/loopers/domain/point/PointJpaRepository.java renamed to apps/commerce-api/src/main/java/com/loopers/infrastructure/point/PointJpaRepository.java apps/commerce-api/src/main/java/com/loopers/domain/point/PointJpaRepository.java renamed to apps/commerce-api/src/main/java/com/loopers/infrastructure/point/PointJpaRepository.java

@@ -1,11 +1,10 @@
-package com.loopers.domain.point;
+package com.loopers.infrastructure.point;
 
+import com.loopers.domain.point.Point;
 import org.springframework.data.jpa.repository.JpaRepository;
-import org.springframework.stereotype.Repository;
 
 import java.util.Optional;
 
-@Repository
 public interface PointJpaRepository extends JpaRepository<Point, Long> {
 
     Optional<Point> findByUserId(Long userId);

apps/commerce-api/src/main/java/com/loopers/infrastructure/point/PointRepositoryImpl.java

@@ -0,0 +1,24 @@
+package com.loopers.infrastructure.point;
+
+import com.loopers.domain.point.Point;
+import com.loopers.domain.point.PointRepository;
+import lombok.RequiredArgsConstructor;
+import org.springframework.stereotype.Component;
+
+import java.util.Optional;
+
+@RequiredArgsConstructor
+@Component
+public class PointRepositoryImpl implements PointRepository {
+    private final PointJpaRepository pointJpaRepository;
+
+    @Override
+    public Optional<Point> findByUserId(Long userId) {
+        return pointJpaRepository.findByUserId(userId);
+    }
+
+    @Override
+    public void save(Point point) {
+        pointJpaRepository.save(point);
+    }
+}

…opers/domain/user/UserJpaRepository.java …frastructure/user/UserJpaRepository.javaapps/commerce-api/src/main/java/com/loopers/domain/user/UserJpaRepository.java renamed to apps/commerce-api/src/main/java/com/loopers/infrastructure/user/UserJpaRepository.java apps/commerce-api/src/main/java/com/loopers/domain/user/UserJpaRepository.java renamed to apps/commerce-api/src/main/java/com/loopers/infrastructure/user/UserJpaRepository.java

@@ -1,14 +1,13 @@
-package com.loopers.domain.user;
+package com.loopers.infrastructure.user;
 
+import com.loopers.domain.user.User;
 import jakarta.persistence.LockModeType;
 import org.springframework.data.jpa.repository.JpaRepository;
 import org.springframework.data.jpa.repository.Lock;
 import org.springframework.data.jpa.repository.Query;
-import org.springframework.stereotype.Repository;
 
 import java.util.Optional;
 
-@Repository
 public interface UserJpaRepository extends JpaRepository<User, String> {
     Optional<User> findByUserId(String userId);
 

apps/commerce-api/src/main/java/com/loopers/infrastructure/user/UserRepositoryImpl.java

@@ -0,0 +1,34 @@
+package com.loopers.infrastructure.user;
+
+import com.loopers.domain.user.User;
+import com.loopers.domain.user.UserRepository;
+import lombok.RequiredArgsConstructor;
+import org.springframework.stereotype.Component;
+
+import java.util.Optional;
+
+@RequiredArgsConstructor
+@Component
+public class UserRepositoryImpl implements UserRepository {
+    private final UserJpaRepository userJpaRepository;
+
+    @Override
+    public Optional<User> findByUserId(String userId) {
+        return userJpaRepository.findByUserId(userId);
+    }
+
+    @Override
+    public Optional<User> findByUserIdForUpdate(String userId) {
+        return userJpaRepository.findByUserIdForUpdate(userId);
+    }
+
+    @Override
+    public boolean existsUserByUserId(String userId) {
+        return userJpaRepository.existsUserByUserId(userId);
+    }
+
+    @Override
+    public User save(User user) {
+        return userJpaRepository.save(user);
+    }
+}