Skip to content

Commit df4f788

Browse files
rnqhstmdrnqhstmd
committed
fix: 상태 코드를 검증할 수 있도록 수정
1 parent 7011b9c commit df4f788

1 file changed

Lines changed: 46 additions & 23 deletions

File tree

‎apps/commerce-api/src/test/java/com/loopers/interfaces/api/order/OrderV1ApiE2ETest.java‎

Lines changed: 46 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,8 @@ void returnsOrderInfo_whenOrderIsSuccessful() {
7171

7272
// act
7373
ParameterizedTypeReference<ApiResponse<OrderV1Dto.OrderResponse>> responseType =
74-
new ParameterizedTypeReference<>() {};
74+
new ParameterizedTypeReference<>() {
75+
};
7576
ResponseEntity<ApiResponse<OrderV1Dto.OrderResponse>> response =
7677
testRestTemplate.exchange(
7778
ENDPOINT_ORDER,
@@ -115,7 +116,8 @@ void returnsDiscountedOrderInfo_whenCouponApplied() {
115116

116117
// act
117118
ParameterizedTypeReference<ApiResponse<OrderV1Dto.OrderResponse>> responseType =
118-
new ParameterizedTypeReference<>() {};
119+
new ParameterizedTypeReference<>() {
120+
};
119121
ResponseEntity<ApiResponse<OrderV1Dto.OrderResponse>> response =
120122
testRestTemplate.exchange(
121123
ENDPOINT_ORDER,
@@ -159,7 +161,8 @@ void returnsMultipleItems_whenOrderHasMultipleProducts() {
159161

160162
// act
161163
ParameterizedTypeReference<ApiResponse<OrderV1Dto.OrderResponse>> responseType =
162-
new ParameterizedTypeReference<>() {};
164+
new ParameterizedTypeReference<>() {
165+
};
163166
ResponseEntity<ApiResponse<OrderV1Dto.OrderResponse>> response =
164167
testRestTemplate.exchange(
165168
ENDPOINT_ORDER,
@@ -195,7 +198,8 @@ void returnsBadRequest_whenUserIdHeaderIsMissing() {
195198

196199
// act
197200
ParameterizedTypeReference<ApiResponse<OrderV1Dto.OrderResponse>> responseType =
198-
new ParameterizedTypeReference<>() {};
201+
new ParameterizedTypeReference<>() {
202+
};
199203
ResponseEntity<ApiResponse<OrderV1Dto.OrderResponse>> response =
200204
testRestTemplate.exchange(
201205
ENDPOINT_ORDER,
@@ -231,7 +235,8 @@ void returnsNotFound_whenUserDoesNotExist() {
231235

232236
// act
233237
ParameterizedTypeReference<ApiResponse<OrderV1Dto.OrderResponse>> responseType =
234-
new ParameterizedTypeReference<>() {};
238+
new ParameterizedTypeReference<>() {
239+
};
235240
ResponseEntity<ApiResponse<OrderV1Dto.OrderResponse>> response =
236241
testRestTemplate.exchange(
237242
ENDPOINT_ORDER,
@@ -267,7 +272,8 @@ void returnsNotFound_whenProductDoesNotExist() {
267272

268273
// act
269274
ParameterizedTypeReference<ApiResponse<OrderV1Dto.OrderResponse>> responseType =
270-
new ParameterizedTypeReference<>() {};
275+
new ParameterizedTypeReference<>() {
276+
};
271277
ResponseEntity<ApiResponse<OrderV1Dto.OrderResponse>> response =
272278
testRestTemplate.exchange(
273279
ENDPOINT_ORDER,
@@ -305,7 +311,8 @@ void returnsBadRequest_whenStockIsInsufficient() {
305311

306312
// act
307313
ParameterizedTypeReference<ApiResponse<OrderV1Dto.OrderResponse>> responseType =
308-
new ParameterizedTypeReference<>() {};
314+
new ParameterizedTypeReference<>() {
315+
};
309316
ResponseEntity<ApiResponse<OrderV1Dto.OrderResponse>> response =
310317
testRestTemplate.exchange(
311318
ENDPOINT_ORDER,
@@ -343,7 +350,8 @@ void returnsBadRequest_whenProductIsOutOfStock() {
343350

344351
// act
345352
ParameterizedTypeReference<ApiResponse<OrderV1Dto.OrderResponse>> responseType =
346-
new ParameterizedTypeReference<>() {};
353+
new ParameterizedTypeReference<>() {
354+
};
347355
ResponseEntity<ApiResponse<OrderV1Dto.OrderResponse>> response =
348356
testRestTemplate.exchange(
349357
ENDPOINT_ORDER,
@@ -379,7 +387,8 @@ void returnsBadRequest_whenItemsIsEmpty() {
379387

380388
// act
381389
ParameterizedTypeReference<ApiResponse<OrderV1Dto.OrderResponse>> responseType =
382-
new ParameterizedTypeReference<>() {};
390+
new ParameterizedTypeReference<>() {
391+
};
383392
ResponseEntity<ApiResponse<OrderV1Dto.OrderResponse>> response =
384393
testRestTemplate.exchange(
385394
ENDPOINT_ORDER,
@@ -417,7 +426,8 @@ void returnsBadRequest_whenQuantityIsZero() {
417426

418427
// act
419428
ParameterizedTypeReference<ApiResponse<OrderV1Dto.OrderResponse>> responseType =
420-
new ParameterizedTypeReference<>() {};
429+
new ParameterizedTypeReference<>() {
430+
};
421431
ResponseEntity<ApiResponse<OrderV1Dto.OrderResponse>> response =
422432
testRestTemplate.exchange(
423433
ENDPOINT_ORDER,
@@ -455,7 +465,8 @@ void returnsNotFound_whenCouponDoesNotExist() {
455465

456466
// act
457467
ParameterizedTypeReference<ApiResponse<OrderV1Dto.OrderResponse>> responseType =
458-
new ParameterizedTypeReference<>() {};
468+
new ParameterizedTypeReference<>() {
469+
};
459470
ResponseEntity<ApiResponse<OrderV1Dto.OrderResponse>> response =
460471
testRestTemplate.exchange(
461472
ENDPOINT_ORDER,
@@ -500,14 +511,17 @@ void returnsOrderList_whenOrdersExist() {
500511
);
501512
testRestTemplate.exchange(ENDPOINT_ORDER, HttpMethod.POST,
502513
new HttpEntity<>(orderRequest1, headers),
503-
new ParameterizedTypeReference<ApiResponse<OrderV1Dto.OrderResponse>>() {});
514+
new ParameterizedTypeReference<ApiResponse<OrderV1Dto.OrderResponse>>() {
515+
});
504516
testRestTemplate.exchange(ENDPOINT_ORDER, HttpMethod.POST,
505517
new HttpEntity<>(orderRequest2, headers),
506-
new ParameterizedTypeReference<ApiResponse<OrderV1Dto.OrderResponse>>() {});
518+
new ParameterizedTypeReference<ApiResponse<OrderV1Dto.OrderResponse>>() {
519+
});
507520

508521
// act
509522
ParameterizedTypeReference<ApiResponse<List<OrderV1Dto.OrderResponse>>> responseType =
510-
new ParameterizedTypeReference<>() {};
523+
new ParameterizedTypeReference<>() {
524+
};
511525
ResponseEntity<ApiResponse<List<OrderV1Dto.OrderResponse>>> response =
512526
testRestTemplate.exchange(
513527
ENDPOINT_ORDER,
@@ -535,7 +549,8 @@ void returnsEmptyList_whenNoOrdersExist() {
535549

536550
// act
537551
ParameterizedTypeReference<ApiResponse<List<OrderV1Dto.OrderResponse>>> responseType =
538-
new ParameterizedTypeReference<>() {};
552+
new ParameterizedTypeReference<>() {
553+
};
539554
ResponseEntity<ApiResponse<List<OrderV1Dto.OrderResponse>>> response =
540555
testRestTemplate.exchange(
541556
ENDPOINT_ORDER,
@@ -556,7 +571,8 @@ void returnsEmptyList_whenNoOrdersExist() {
556571
void returnsBadRequest_whenUserIdHeaderIsMissing() {
557572
// act
558573
ParameterizedTypeReference<ApiResponse<List<OrderV1Dto.OrderResponse>>> responseType =
559-
new ParameterizedTypeReference<>() {};
574+
new ParameterizedTypeReference<>() {
575+
};
560576
ResponseEntity<ApiResponse<List<OrderV1Dto.OrderResponse>>> response =
561577
testRestTemplate.exchange(
562578
ENDPOINT_ORDER,
@@ -598,12 +614,14 @@ void returnsOrderDetail_whenOrderExists() {
598614
ResponseEntity<ApiResponse<OrderV1Dto.OrderResponse>> createResponse =
599615
testRestTemplate.exchange(ENDPOINT_ORDER, HttpMethod.POST,
600616
new HttpEntity<>(orderRequest, headers),
601-
new ParameterizedTypeReference<>() {});
617+
new ParameterizedTypeReference<>() {
618+
});
602619
Long orderId = createResponse.getBody().data().orderId();
603620

604621
// act
605622
ParameterizedTypeReference<ApiResponse<OrderV1Dto.OrderResponse>> responseType =
606-
new ParameterizedTypeReference<>() {};
623+
new ParameterizedTypeReference<>() {
624+
};
607625
ResponseEntity<ApiResponse<OrderV1Dto.OrderResponse>> response =
608626
testRestTemplate.exchange(
609627
ENDPOINT_ORDER + "/" + orderId,
@@ -633,7 +651,8 @@ void returnsNotFound_whenOrderDoesNotExist() {
633651

634652
// act
635653
ParameterizedTypeReference<ApiResponse<OrderV1Dto.OrderResponse>> responseType =
636-
new ParameterizedTypeReference<>() {};
654+
new ParameterizedTypeReference<>() {
655+
};
637656
ResponseEntity<ApiResponse<OrderV1Dto.OrderResponse>> response =
638657
testRestTemplate.exchange(
639658
ENDPOINT_ORDER + "/99999",
@@ -671,7 +690,8 @@ void returnsForbidden_whenAccessingOtherUsersOrder() {
671690
ResponseEntity<ApiResponse<OrderV1Dto.OrderResponse>> createResponse =
672691
testRestTemplate.exchange(ENDPOINT_ORDER, HttpMethod.POST,
673692
new HttpEntity<>(orderRequest, headers1),
674-
new ParameterizedTypeReference<>() {});
693+
new ParameterizedTypeReference<>() {
694+
});
675695
Long orderId = createResponse.getBody().data().orderId();
676696

677697
// user2가 user1의 주문 조회 시도
@@ -680,7 +700,8 @@ void returnsForbidden_whenAccessingOtherUsersOrder() {
680700

681701
// act
682702
ParameterizedTypeReference<ApiResponse<OrderV1Dto.OrderResponse>> responseType =
683-
new ParameterizedTypeReference<>() {};
703+
new ParameterizedTypeReference<>() {
704+
};
684705
ResponseEntity<ApiResponse<OrderV1Dto.OrderResponse>> response =
685706
testRestTemplate.exchange(
686707
ENDPOINT_ORDER + "/" + orderId,
@@ -689,8 +710,10 @@ void returnsForbidden_whenAccessingOtherUsersOrder() {
689710
responseType
690711
);
691712

692-
// assert - 다른 사용자의 주문 조회 시 403 또는 404 반환
693-
assertTrue(response.getStatusCode().is4xxClientError());
713+
assertAll(
714+
() -> assertTrue(response.getStatusCode().is4xxClientError()),
715+
() -> assertThat(response.getStatusCode()).isIn(HttpStatus.FORBIDDEN, HttpStatus.NOT_FOUND)
716+
);
694717
}
695718
}
696719
}

0 commit comments

Comments
 (0)