fix attributes without a value not being parsed

LordSimal · LordSimal · commit 905d477cf04c · 2024-08-12T14:05:21.000+02:00
diff --git a/README.md b/README.md
@@ -154,6 +154,28 @@ both are rendered the same way.
 
 By default, this library renders nested custom HTML elements. So you don't need to worry about that.
 
+## Disabling custom HTML elements
+
+You have 2 ways how you can disable custom HTML elements:
+
+### Disable all occurence of custom HTML elements
+
+You can add the attributes 
+
+```php
+public bool $disabled = true;
+```
+
+to your Custom HTML Element class.
+
+### Disable only specific occurence of custom HTML elements
+
+You can add the attribute `disabled`, then it will not be rendered.
+
+```html
+<c-youtube src="RLdsCL4RDf8" disabled />
+```
+
 ## More examples?
 
 See all the different [TagEngine Tests](https://github.com/LordSimal/custom-html-elements/blob/main/tests/TagEngine/)
diff --git a/src/TagEngine.php b/src/TagEngine.php
@@ -131,13 +131,13 @@ protected function replaceComponent(array $matches): string
     protected function parseAttributes(string $attributesString): array
     {
         // Regex to match attributes (both static and dynamic)
-        $pattern = '/([:?\w-]+)=["\']([^"\']+)["\']/';
+        $pattern = '/([:\w-]+)(?:=["\']([^"\']+)["\'])?/';
         preg_match_all($pattern, $attributesString, $matches, PREG_SET_ORDER);
 
         $attributes = [];
         foreach ($matches as $match) {
             $name = $match[1];
-            $value = $match[2];
+            $value = $match[2] ?? true; // If no value, set it to true
 
             $name = str_replace('-', '_', $name); // Replace hyphens with underscores so that it works with properties
 
diff --git a/tests/TagEngine/CustomTagsTest.php b/tests/TagEngine/CustomTagsTest.php
@@ -110,11 +110,9 @@ public function testMultipleTagsWithAttributeSelfClosing(): void
      */
     public function testTagWithMultipleAttributes(): void
     {
-        $element = '<c-button type="primary" text="Click me" url="/something/stupid" />';
+        $element = '<c-button type="primary" text="Click me" url="/something/stupid" other />';
         $result = $this->tagEngine->parse($element);
-        $expected = <<<HTML
-			<a href="/something/stupid" class="c-button c-button--primary">Click me</a>
-HTML;
+        $expected = '<a href="/something/stupid" class="c-button c-button--primary" other>Click me</a>';
         $this->assertSame($expected, $result);
     }
 
diff --git a/tests/Tags/Button.php b/tests/Tags/Button.php
@@ -9,6 +9,7 @@
  * @property string $type
  * @property string $text
  * @property string $url
+ * @property bool $other
  */
 class Button extends CustomTag
 {
@@ -22,8 +23,6 @@ public function render(): string
         }
         $classes = implode(' ', $classes);
 
-        return <<< HTML
-			<a href="$this->url" class="$classes">$this->text</a>
-HTML;
+        return '<a href="' . $this->url . '" class="' . $classes . '"' . ($this->other ? ' other' : '') . '>' . $this->text . '</a>';
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -110,11 +110,9 @@ public function testMultipleTagsWithAttributeSelfClosing(): void`
`110`	`110`	`*/`
`111`	`111`	`public function testTagWithMultipleAttributes(): void`
`112`	`112`	`{`
`113`		`- $element = '<c-button type="primary" text="Click me" url="/something/stupid" />';`
	`113`	`+ $element = '<c-button type="primary" text="Click me" url="/something/stupid" other />';`
`114`	`114`	`$result = $this->tagEngine->parse($element);`
`115`		`- $expected = <<<HTML`
`116`		`- <a href="/something/stupid" class="c-button c-button--primary">Click me</a>`
`117`		`-HTML;`
	`115`	`+ $expected = '<a href="/something/stupid" class="c-button c-button--primary" other>Click me</a>';`
`118`	`116`	`$this->assertSame($expected, $result);`
`119`	`117`	`}`
`120`	`118`
Original file line number	Diff line number	Diff line change
`@@ -9,6 +9,7 @@`
`9`	`9`	`* @property string $type`
`10`	`10`	`* @property string $text`
`11`	`11`	`* @property string $url`
	`12`	`+ * @property bool $other`
`12`	`13`	`*/`
`13`	`14`	`class Button extends CustomTag`
`14`	`15`	`{`
`@@ -22,8 +23,6 @@ public function render(): string`
`22`	`23`	`}`
`23`	`24`	`$classes = implode(' ', $classes);`
`24`	`25`
`25`		`- return <<< HTML`
`26`		`- <a href="$this->url" class="$classes">$this->text</a>`
`27`		`-HTML;`
	`26`	`+ return '<a href="' . $this->url . '" class="' . $classes . '"' . ($this->other ? ' other' : '') . '>' . $this->text . '</a>';`
`28`	`27`	`}`
`29`	`28`	`}`