Add smoke tests, re-add slf4j for test logging

Author: LucaScorpion

Jenkinsfile

@@ -22,5 +22,5 @@ pipeline {
 
 def mvn(String goals) {
     def mvnHome = tool 'Maven 3'
-    sh "'${mvnHome}/bin/mvn' -Dmaven.test.failure.ignore $goals"
+    sh "'${mvnHome}/bin/mvn' -Dmaven.test.failure.ignore -Djavarant.test.smoke $goals"
 }

pom.xml

@@ -41,6 +41,7 @@
         <!-- Dependencies -->
         <jackson.version>2.8.9</jackson.version>
         <fluent.version>4.5.3</fluent.version>
+        <slf4j.version>1.7.25</slf4j.version>
         <guice.version>4.1.0</guice.version>
         <testng.version>6.11</testng.version>
         <wiremock.version>2.7.1</wiremock.version>
@@ -83,6 +84,12 @@
             <version>${wiremock.version}</version>
             <scope>test</scope>
         </dependency>
+        <dependency>
+            <groupId>org.slf4j</groupId>
+            <artifactId>slf4j-simple</artifactId>
+            <version>${slf4j.version}</version>
+            <scope>test</scope>
+        </dependency>
     </dependencies>
 
     <!-- Distribution management for OSSRH -->

src/main/java/com/scorpiac/javarant/DevRant.java

@@ -15,7 +15,7 @@ public class DevRant {
     private final DevRantAuth devRantAuth;
 
     private RequestHandler requestHandler;
-    Auth auth;
+    private Auth auth;
 
     static {
         INJECTOR = Guice.createInjector();
@@ -40,6 +40,14 @@ RequestHandler getRequestHandler() {
         return requestHandler;
     }
 
+    Auth getAuthObject() {
+        return auth;
+    }
+
+    void setAuthObject(Auth auth) {
+        this.auth = auth;
+    }
+
     /**
      * Access the devRant feed.
      *

src/main/java/com/scorpiac/javarant/DevRantAuth.java

@@ -46,9 +46,9 @@ public Comment voteComment(int id, Vote vote) {
 
     private NameValuePair[] getParameters(List<NameValuePair> params) {
         // Add the auth parameters.
-        params.add(new BasicNameValuePair("token_id", devRant.auth.getId()));
-        params.add(new BasicNameValuePair("token_key", devRant.auth.getKey()));
-        params.add(new BasicNameValuePair("user_id", devRant.auth.getUserId()));
+        params.add(new BasicNameValuePair("token_id", devRant.getAuthObject().getId()));
+        params.add(new BasicNameValuePair("token_key", devRant.getAuthObject().getKey()));
+        params.add(new BasicNameValuePair("user_id", devRant.getAuthObject().getUserId()));
 
         return params.toArray(new NameValuePair[0]);
     }

src/test/java/com/scorpiac/javarant/DevRantAuthIT.java

@@ -13,7 +13,7 @@ public class DevRantAuthIT extends ITHelper {
 
     @BeforeClass
     public void login() {
-        devRant.auth = new Auth("123", "t0k3n", "456");
+        devRant.setAuthObject(new Auth("123", "t0k3n", "456"));
         authBody = "token_id=123&token_key=t0k3n&user_id=456";
     }
 

src/test/java/com/scorpiac/javarant/DevRantSmokeTestIT.java

@@ -0,0 +1,55 @@
+package com.scorpiac.javarant;
+
+import org.testng.SkipException;
+import org.testng.annotations.BeforeClass;
+import org.testng.annotations.Test;
+
+import java.util.UUID;
+
+import static org.testng.Assert.*;
+
+public class DevRantSmokeTestIT {
+    private final DevRant devRant = new DevRant();
+
+    @BeforeClass
+    public void checkShouldTest() {
+        if (System.getProperty("javarant.test.smoke") == null) {
+            throw new SkipException("Property 'javarant.test.smoke' is not set, skipping smoke tests.");
+        }
+    }
+
+    @Test
+    public void testGetRant() {
+        Rant rant = devRant.getRant(892667);
+
+        assertEquals(rant.getId(), 892667);
+        assertEquals(rant.getUser().getUsername(), "LucaScorpion");
+        assertNotNull(rant.getImage());
+    }
+
+    @Test(expectedExceptions = NoSuchRantException.class, expectedExceptionsMessageRegExp = ".*123.*")
+    public void testGetRantInvalid() {
+        devRant.getRant(123);
+    }
+
+    @Test
+    public void testGetUserByUsername() {
+        User user = devRant.getUser("LucaScorpion");
+
+        assertEquals(user.getUsername(), "LucaScorpion");
+        assertEquals(user.getId(), 102959);
+        assertFalse(user.getRants().isEmpty());
+        assertTrue(user.getRantsCount() > 0);
+    }
+
+    @Test(expectedExceptions = NoSuchUserException.class, expectedExceptionsMessageRegExp = ".*'This-is-a-non-existing-username.*'.*")
+    public void testGetUserByUsernameInvalid() {
+        // Add some randomness in case someone wants to fuck this test by registering this username.
+        devRant.getUser("This-is-a-non-existing-username-" + UUID.randomUUID().toString());
+    }
+
+    @Test(expectedExceptions = NoSuchUserException.class, expectedExceptionsMessageRegExp = ".*123.*")
+    public void testGetUserInvalid() {
+        devRant.getUser(123);
+    }
+}