fix(folia): fix folia chunk updates

Author: Jsinco

main/src/main/java/me/outspending/biomesapi/BiomeUpdater.java

@@ -6,6 +6,7 @@
 import org.bukkit.Location;
 import org.bukkit.World;
 import org.bukkit.entity.Player;
+import org.bukkit.plugin.Plugin;
 import org.jetbrains.annotations.Contract;
 import org.jetbrains.annotations.NotNull;
 
@@ -30,11 +31,24 @@ public interface BiomeUpdater {
      * This method returns an instance of BiomeUpdaterImpl.
      *
      * @return an instance of BiomeUpdater.
-     * @version 0.0.2
+     * @since 0.0.2
+     * @deprecated {@link #of(Plugin)} is preferred for compatability reasons (Folia).
      */
-    @AsOf("0.0.2")
+    @Deprecated
+    @AsOf("1.2.0")
     static @NotNull BiomeUpdater of() {
-        return new BiomeUpdaterImpl();
+        return new BiomeUpdaterImpl(null);
+    }
+
+    /**
+     * Returns an instance of BiomeUpdater with a plugin reference.
+     * @param plugin the plugin to use for scheduling chunk updates. Necessary for Folia compatibility.
+     * @return an instance of BiomeUpdater with a plugin reference
+     * @since 1.2.0
+     */
+    @AsOf("1.2.0")
+    static @NotNull BiomeUpdater of(@NotNull Plugin plugin) {
+        return new BiomeUpdaterImpl(plugin);
     }
 
     /**

main/src/main/java/me/outspending/biomesapi/BiomeUpdaterImpl.java

@@ -6,7 +6,9 @@
 import org.bukkit.Location;
 import org.bukkit.World;
 import org.bukkit.entity.Player;
+import org.bukkit.plugin.Plugin;
 import org.jetbrains.annotations.NotNull;
+import org.jetbrains.annotations.Nullable;
 
 import java.util.ArrayList;
 import java.util.List;
@@ -22,6 +24,12 @@
 @AsOf("0.0.1")
 public class BiomeUpdaterImpl implements BiomeUpdater {
 
+    private final @Nullable Plugin plugin;
+
+    public BiomeUpdaterImpl(@Nullable Plugin plugin) {
+        this.plugin = plugin;
+    }
+
     @Override
     public void updateChunk(@NotNull CompletableFuture<Chunk> chunk) {
         updateChunks(List.of(chunk));
@@ -40,7 +48,7 @@ public void updateChunks(Location from, Location to) {
 
     @Override
     public void updateChunks(@NotNull List<CompletableFuture<Chunk>> chunks) {
-        UnsafeNMSHandler.executeNMS(nms -> nms.updateChunks(chunks));
+        UnsafeNMSHandler.executeNMS(nms -> nms.updateChunks(chunks, plugin));
     }
 
 

minecraft/1_21_11/src/main/java/me/outspending/biomesapi/UnsafeNMS_v1_21_11.java

@@ -26,7 +26,9 @@
 import org.bukkit.craftbukkit.CraftServer;
 import org.bukkit.craftbukkit.entity.CraftPlayer;
 import org.bukkit.entity.Player;
+import org.bukkit.plugin.Plugin;
 import org.jetbrains.annotations.NotNull;
+import org.jetbrains.annotations.Nullable;
 
 import java.lang.reflect.Field;
 import java.lang.reflect.InvocationTargetException;
@@ -63,16 +65,16 @@ public class UnsafeNMS_v1_21_11 implements UnsafeNMS {
      * @param chunks The chunks to update.
      */
     @Override
-    public void updateChunks(@NotNull List<CompletableFuture<Chunk>> chunks) {
+    public void updateChunks(@NotNull List<CompletableFuture<Chunk>> chunks, @Nullable Plugin plugin) {
         CompletableFuture.runAsync(() -> {
             for (CompletableFuture<Chunk> chunkFuture : chunks) {
                 chunkFuture.thenAccept(chunk -> {
-                    LevelChunk levelChunk = (LevelChunk) ((CraftChunk) chunk).getHandle(ChunkStatus.BIOMES);
-                    LevelLightEngine levelLightEngine = levelChunk.getLevel().getLightEngine();
-
-                    ClientboundLevelChunkWithLightPacket packet = new ClientboundLevelChunkWithLightPacket(levelChunk, levelLightEngine, null, null, true);
-                    for (Player player : getPlayersInDistance(chunk)) {
-                        ((CraftPlayer) player).getHandle().connection.send(packet);
+                    if (plugin != null) {
+                        Bukkit.getRegionScheduler().run(plugin, chunk.getWorld(), chunk.getX(), chunk.getZ(), task -> {
+                            doUpdateChunk(chunk);
+                        });
+                    } else {
+                        doUpdateChunk(chunk);
                     }
                 }).exceptionally(ex -> {
                     ex.printStackTrace();
@@ -85,6 +87,16 @@ public void updateChunks(@NotNull List<CompletableFuture<Chunk>> chunks) {
         });
     }
 
+    private void doUpdateChunk(Chunk chunk) {
+        LevelChunk levelChunk = (LevelChunk) ((CraftChunk) chunk).getHandle(ChunkStatus.BIOMES);
+        LevelLightEngine levelLightEngine = levelChunk.getLevel().getLightEngine();
+
+        ClientboundLevelChunkWithLightPacket packet = new ClientboundLevelChunkWithLightPacket(levelChunk, levelLightEngine, null, null, true);
+        for (Player player : getPlayersInDistance(chunk)) {
+            ((CraftPlayer) player).getHandle().connection.send(packet);
+        }
+    }
+
     /**
      * Locks or unlocks the biome registry.
      * It uses reflection to access the private boolean field in the registry class and sets its value.

minecraft/Wrapper/src/main/java/me/outspending/biomesapi/unsafe/UnsafeNMS.java

@@ -6,7 +6,9 @@
 import org.bukkit.NamespacedKey;
 import org.bukkit.World;
 import org.bukkit.entity.Player;
+import org.bukkit.plugin.Plugin;
 import org.jetbrains.annotations.NotNull;
+import org.jetbrains.annotations.Nullable;
 
 import java.util.List;
 import java.util.concurrent.CompletableFuture;
@@ -56,7 +58,7 @@ default List<Player> getPlayersInDistance(@NotNull Chunk chunk) {
      *
      * @param chunks The chunks to update.
      */
-    void updateChunks(@NotNull List<CompletableFuture<Chunk>> chunks);
+    void updateChunks(@NotNull List<CompletableFuture<Chunk>> chunks, @Nullable Plugin plugin);
 
     /**
      * Locks or unlocks the biome registry.