Converted to Trader 0.4.1

Author: jb-lopez

README.md

@@ -14,15 +14,9 @@ This project is just an interface to that extension, and does not work without i
 
 Variable types are set on all function parameters.
 
-## Note About Mis-documented Functions
+### Requires PECL Trader 0.4.1.
 
-The php.net documentation for trader_ht_phasor and trader_ht_sine are incorrect.  This was discovered through unit testing of this interface.  Both functions require a second parameter, a by reference array that extra data will be written into.
-
-This interface has the correct version of those functions.
-
-### Bug in Trader 0.4.0
-
-The PECL Trader package version 0.4.0 has a bug regarding the two functions above.  Though the output parameters are required for the function to execute, they are not used.  The returned array is a 2-Dimensional array with the return value and the output parameter combined. 
+If you are using version 0.4.0, see the branch `trader-0.4.0` for that.
 
 ## How to use
 

Tests/TraderTest.php

@@ -923,16 +923,12 @@ public function testInterfaceFunctions_ht_dcphase()
 
     public function testInterfaceFunctions_ht_phasor()
     {
-        $inPhase1 = [];
-        $inPhase2 = [];
-        $this->assertEquals(trader_ht_phasor($this->Close, $inPhase1), Trader::ht_phasor($this->Close, $inPhase2));
+        $this->assertEquals(trader_ht_phasor($this->Close), Trader::ht_phasor($this->Close));
     }
 
     public function testInterfaceFunctions_ht_sine()
     {
-        $sine1 = [];
-        $sine2 = [];
-        $this->assertEquals(trader_ht_sine($this->Close, $sine1), Trader::ht_sine($this->Close, $sine2));
+        $this->assertEquals(trader_ht_sine($this->Close), Trader::ht_sine($this->Close));
     }
 
     public function testInterfaceFunctions_ht_trendline()
@@ -1721,16 +1717,12 @@ public function testFriendlyFunctions_ht_dcphase()
 
     public function testFriendlyFunctions_ht_phasor()
     {
-        $inPhase1 = [];
-        $inPhase2 = [];
-        $this->assertEquals(trader_ht_phasor($this->Close, $inPhase1), Trader::hilbertTransformPhasorComponents($this->Close, $inPhase2));
+        $this->assertEquals(trader_ht_phasor($this->Close), Trader::hilbertTransformPhasorComponents($this->Close));
     }
 
     public function testFriendlyFunctions_ht_sine()
     {
-        $sine1 = [];
-        $sine2 = [];
-        $this->assertEquals(trader_ht_sine($this->Close, $sine1), Trader::hilbertTransformSineWave($this->Close, $sine2));
+        $this->assertEquals(trader_ht_sine($this->Close), Trader::hilbertTransformSineWave($this->Close));
     }
 
     public function testFriendlyFunctions_ht_trendline()

composer.json

@@ -14,7 +14,7 @@
   ],
   "require": {
     "php": ">=7.0.0",
-    "ext-trader": "*"
+    "ext-trader": "0.4.1"
   },
   "require-dev": {
     "phpunit/phpunit": "~6.3.0",

source/Trader.php

@@ -1597,28 +1597,26 @@ public static function hilbertTransformDominantCyclePhase(array $real): array
      * Hilbert Transform - Phasor Components
      *
      * @param array $real    Array of real values.
-     * @param array $inPhase Empty array, will be filled with in phase data.
      *
      * @return array Returns an array with calculated data or false on failure.
      * @throws \Exception
      */
-    public static function hilbertTransformPhasorComponents(array $real, array &$inPhase): array
+    public static function hilbertTransformPhasorComponents(array $real): array
     {
-        return static::ht_phasor($real, $inPhase);
+        return static::ht_phasor($real);
     }
 
     /**
      * Hilbert Transform - SineWave
      *
      * @param array $real Array of real values.
-     * @param array $sine Empty array, will be filled with sine data.
      *
      * @return array Returns an array with calculated data or false on failure.
      * @throws \Exception
      */
-    public static function hilbertTransformSineWave(array $real, array &$sine): array
+    public static function hilbertTransformSineWave(array $real): array
     {
-        return static::ht_sine($real, $sine);
+        return static::ht_sine($real);
     }
 
     /**

source/TraderTrait.php

@@ -1886,14 +1886,13 @@ public static function ht_dcphase(array $real): array
      * Hilbert Transform - Phasor Components
      *
      * @param array $real    Array of real values.
-     * @param array $inPhase Empty array, will be filled with in phase data.
      *
      * @return array Returns an array with calculated data or false on failure.
      * @throws \Exception
      */
-    public static function ht_phasor(array $real, array &$inPhase): array
+    public static function ht_phasor(array $real): array
     {
-        $return = trader_ht_phasor($real, $inPhase);
+        $return = trader_ht_phasor($real);
         static::checkForError();
 
         return $return;
@@ -1903,14 +1902,13 @@ public static function ht_phasor(array $real, array &$inPhase): array
      * Hilbert Transform - SineWave
      *
      * @param array $real Array of real values.
-     * @param array $sine Empty array, will be filled with sine data.
      *
      * @return array Returns an array with calculated data or false on failure.
      * @throws \Exception
      */
-    public static function ht_sine(array $real, array &$sine): array
+    public static function ht_sine(array $real): array
     {
-        $return = trader_ht_sine($real, $sine);
+        $return = trader_ht_sine($real);
         static::checkForError();
 
         return $return;
@@ -3193,4 +3191,4 @@ public static function wma(array $real, int $timePeriod = null): array
         return $return;
     }
 
-}
+}