refactor: make settings overridable

Author: leaftail1880

src/lib/settings.ts

@@ -6,9 +6,9 @@ import { stringify } from 'lib/util'
 import { createLogger } from 'lib/utils/logger'
 import { WeakPlayerMap } from 'lib/weak-player-storage'
 import { MemoryTable, Table, table } from './database/abstract'
+import { Message } from './i18n/message'
 import { i18n, noI18n } from './i18n/text'
 import stringifyError from './utils/error'
-import { Message } from './i18n/message'
 
 // TODO refactor(leaftail1880): Move all types under the Settings namespace
 // TODO refactor(leaftail1880): Move everything into the lib/settings/ folder
@@ -99,6 +99,11 @@ export class Settings {
     fn.groupId = groupId
     fn.groupName = groupName
     fn.extend = [groupName, groupId] as const
+    fn.override = (setting: keyof Config, value: Partial<SettingsConfig<PlayerSettingValues>[string]>) => {
+      for (const [k, v] of Object.entries(value)) {
+        if (config[setting]) (config[setting] as unknown as Record<string, unknown>)[k] = v
+      }
+    }
 
     return fn
   }

src/modules/features/break-item-durability-notify.ts

@@ -1,15 +1,16 @@
 import { system } from '@minecraft/server'
-import { actionGuard, ActionGuardOrder, Menu, Settings } from 'lib'
 import { ActionbarPriority } from 'lib/extensions/on-screen-display'
 import { i18n } from 'lib/i18n/text'
+import { actionGuard, ActionGuardOrder } from 'lib/region'
+import { Menu } from 'lib/rpg/menu'
+import { Settings } from 'lib/settings'
 
 const playerSettings = Settings.player(...Menu.settings, {
   breakItemDurabilityNotify: {
     name: i18n`Уведомлять о ломающемся предмете`,
     description: i18n`Если включено, то когда вы взаимодействуете с блоком предметом, у которого остается менее 90%% прочности, показывать уведомление на весь экран`,
     value: true,
   },
-  // TODO Donut feature
   breakItemDurabilityCancel: {
     name: i18n`Не давать ломать предмет`,
     description: i18n`Если включено, то когда вы взаимодействуете с блоком предметом, у которого остается менее 99%% прочности, взаимодействие будет отменено, а предмет - спасен.`,
@@ -18,21 +19,21 @@ const playerSettings = Settings.player(...Menu.settings, {
 })
 
 actionGuard((player, _, ctx) => {
-  const settings = playerSettings(player)
-  if (!settings.breakItemDurabilityNotify) return
   if (ctx.type !== 'break') return
 
   const durability = ctx.event.itemStack?.durability
   if (!durability) return
 
   const { damage, maxDurability } = durability
+  const percent = 100 - (damage / maxDurability) * 100
 
-  const percent = (damage / maxDurability) * 100
-
-  if (percent >= 90)
+  const settings = playerSettings(player)
+  if (percent < 10 && settings.breakItemDurabilityNotify)
     system.delay(() => {
       player.onScreenDisplay.setActionBar(
-        i18n.error`Инструмент скоро сломается! ${damage}/${maxDurability} (${percent}%)`.to(player.lang),
+        i18n.error`Инструмент скоро сломается! ${maxDurability - damage}/${maxDurability} (${percent}%)`.to(
+          player.lang,
+        ),
         ActionbarPriority.Highest,
       )
     })
@@ -41,3 +42,7 @@ actionGuard((player, _, ctx) => {
     return false
   }
 }, ActionGuardOrder.Feature)
+
+export const breakItemDurabilityNotify = {
+  playerSettings,
+}