add motions integration

Author: JoeyRubas

mittab/apps/tab/models.py

@@ -72,6 +72,12 @@
         "subtitle": "Published ballots and detailed round results.",
         "url_path": "/public/ballots/",
     },
+    {
+        "slug": "public_motions",
+        "title": "Motions",
+        "subtitle": "View debate motions and info slides.",
+        "url_path": "/public/motions/",
+    },
 )
 
 PUBLIC_HOME_SHORTCUT_DEFAULTS = (

mittab/libs/tests/views/test_post_operations.py

@@ -134,7 +134,7 @@ def test_public_home_shortcuts_update(self):
             {
                 "tournament_name": "MIT Invitational",
                 "slot_1": "public_team_results",
-                "slot_2": "public_speaker_results",
+                "slot_2": "public_motions",
                 "slot_3": "public_ballots",
                 "slot_4": "released_pairings",
                 "slot_5": "missing_ballots",
@@ -148,6 +148,10 @@ def test_public_home_shortcuts_update(self):
             PublicHomeShortcut.objects.get(position=1).nav_item,
             "public_team_results",
         )
+        self.assertEqual(
+            PublicHomeShortcut.objects.get(position=2).nav_item,
+            "public_motions",
+        )
         self.assertEqual(
             PublicHomeShortcut.objects.get(position=3).nav_item,
             "public_ballots",

mittab/libs/tests/views/test_public_views.py

@@ -279,6 +279,46 @@ def test_public_home_falls_back_to_defaults_when_shortcuts_missing(self):
         self.assertIn(reverse("pretty_pair"), content)
         self.assertIn(reverse("missing_ballots"), content)
 
+    def test_public_home_shows_only_seven_shortcuts_when_motions_enabled(self):
+        client = Client()
+        TabSettings.set("motions_enabled", 1)
+
+        defaults = PublicHomeShortcut.default_slot_mapping()
+        for position, nav_item in defaults.items():
+            PublicHomeShortcut.objects.update_or_create(
+                position=position,
+                defaults={"nav_item": nav_item},
+            )
+
+        caches["public"].clear()
+        response = client.get(reverse("public_home"))
+        self.assertEqual(response.status_code, 200)
+        content = response.content.decode()
+
+        self.assertEqual(content.count('class="tile shadow-sm"'), 7)
+        self.assertNotIn('<span class="title">Motions</span>', content)
+
+    def test_public_home_can_show_motions_when_selected_as_shortcut(self):
+        client = Client()
+        TabSettings.set("motions_enabled", 1)
+
+        defaults = PublicHomeShortcut.default_slot_mapping()
+        defaults[1] = "public_motions"
+        for position, nav_item in defaults.items():
+            PublicHomeShortcut.objects.update_or_create(
+                position=position,
+                defaults={"nav_item": nav_item},
+            )
+
+        caches["public"].clear()
+        response = client.get(reverse("public_home"))
+        self.assertEqual(response.status_code, 200)
+        content = response.content.decode()
+
+        self.assertEqual(content.count('class="tile shadow-sm"'), 7)
+        self.assertIn('<span class="title">Motions</span>', content)
+        self.assertIn(reverse("public_motions"), content)
+
     def test_public_rankings_control_updates_display_settings(self):
         client = Client()
         user = get_user_model().objects.create_superuser(

mittab/templates/public/home.html

@@ -95,16 +95,6 @@ <h2 class="status-title mb-2">Status:</h2>
               <span class="chevron"><i class="fas fa-arrow-right"></i></span>
             </a>
           {% endfor %}
-          {% motions_enabled as show_motions %}
-          {% if show_motions %}
-          <a class="tile shadow-sm" href="{% url 'public_motions' %}">
-            <span class="body">
-              <span class="title">Motions</span>
-              <span class="subtitle">View debate motions and info slides.</span>
-            </span>
-            <span class="chevron"><i class="fas fa-arrow-right"></i></span>
-          </a>
-          {% endif %}
         </nav>
       </aside>
     </div>