Improve xblock deserialization error handling

Wrap serializer.Deserialize in a try/catch to log deserialization errors (and inner exception) and safely return an empty entity list on failure. Add a mapId parameter to GetInstance so error messages include the source map/file name, and update unknown-property logging to include the model name and map id. Also pass the file name (or "XML Input" for string inputs) to GetInstance calls to provide better context when reporting issues.

Author: AngeloTadeucci

Maple2.File.Parser/MapXBlock/XBlockParser.cs

@@ -90,7 +90,18 @@ public static IEnumerable<string> CheckParseOrder(ICollection<Type> types) {
     }
 
     private IEnumerable<IMapEntity> ParseEntities(PackFileEntry file) {
-        if (serializer.Deserialize(reader.GetXmlReader(file)) is GameXBlock block) {
+        GameXBlock block;
+        try {
+            block = serializer.Deserialize(reader.GetXmlReader(file)) as GameXBlock;
+        } catch (Exception ex) {
+            OnError?.Invoke($"Failed to deserialize xblock '{file.Name}': {ex.Message}");
+            if (ex.InnerException != null) {
+                OnError?.Invoke($"  Inner: {ex.InnerException.Message}");
+            }
+            return Array.Empty<IMapEntity>();
+        }
+
+        if (block != null) {
             var unknownModels = new HashSet<string>();
             return block.entitySet.entity
                 .Where(entity => {
@@ -103,7 +114,7 @@ private IEnumerable<IMapEntity> ParseEntities(PackFileEntry file) {
                 })
                 .Select(entity => {
                     try {
-                        return GetInstance(entity);
+                        return GetInstance(entity, file.Name);
                     } catch (UnknownModelTypeException ex) {
                         // Reduce noise from this exception to once per file
                         if (unknownModels.Add(entity.modelName)) {
@@ -118,7 +129,7 @@ private IEnumerable<IMapEntity> ParseEntities(PackFileEntry file) {
         return Array.Empty<IMapEntity>();
     }
 
-    private IMapEntity GetInstance(Entity entity) {
+    private IMapEntity GetInstance(Entity entity, string mapId) {
         Type entityType = lookup.GetClass(entity.modelName);
 
         var mapEntity = (IMapEntity) Activator.CreateInstance(entityType);
@@ -141,7 +152,7 @@ private IMapEntity GetInstance(Entity entity) {
 
             FlatProperty modelProperty = baseType.GetProperty(property.name);
             if (modelProperty == null) {
-                OnError?.Invoke($"Ignoring unknown property {property.name}");
+                OnError?.Invoke($"Ignoring unknown property {property.name} on {entity.modelName} from map {mapId}");
                 continue;
             }
 
@@ -187,7 +198,7 @@ public void ParseXml(XmlReader xmlReader, Action<IEnumerable<IMapEntity>> callba
                 })
                 .Select(entity => {
                     try {
-                        return GetInstance(entity);
+                        return GetInstance(entity, "XML Input");
                     } catch (UnknownModelTypeException ex) {
                         if (unknownModels.Add(entity.modelName)) {
                             OnError?.Invoke(ex.Message);