New errors detected and returned: ErrorSendMessageSpamSuspected, ErrorSendMessageDailyLimitExceeded

Author: Sergei Epatov

src/core/abstract/MCErrorMessage.cpp

@@ -46,11 +46,14 @@ static const char * localizedDescriptionTable[] = {
     "An application specific password is required",                                  /** MCOErrorGmailApplicationSpecificPasswordRequired */
     "An error when requesting date",                                                 /** MCOErrorServerDate */
     "No valid server found",                                                         /** MCOErrorNoValidServerFound */
+    NULL,                                                                            /** MCOErrorCustomCommand */
+    "Cannot send message due to possible spam detected by server",                   /** MCOErrorSendMessageSpamSuspected */
+    "User is over the limit for messages allowed to be sent in a single day",        /** MCOErrorSendMessageDailyLimitExceeded */
 };
 
 String * mailcore::errorMessageWithErrorCode(ErrorCode errorCode)
 {
-    if (errorCode < 0) {
+    if (errorCode < 0 || errorCode == ErrorCustomCommand) {
         return NULL;
     }
     if (errorCode >= sizeof(localizedDescriptionTable) / sizeof(localizedDescriptionTable[0])) {

src/core/smtp/MCSMTPSession.cpp

@@ -682,6 +682,14 @@ void SMTPSession::sendMessage(Address * from, Array * recipients, Data * message
                 goto err;
             }
         }
+        else if (responseCode == 521 && response->locationOfString(MCSTR("limit")) != -1) {
+            * pError = ErrorSendMessageDailyLimitExceeded;
+            goto err;
+        }
+        else if (responseCode == 554 && response->locationOfString(MCSTR("spam")) != -1) {
+            * pError = ErrorSendMessageSpamSuspected;
+            goto err;
+        }
 
         * pError = ErrorSendMessage;
         MC_SAFE_REPLACE_COPY(String, mLastSMTPResponse, response);

src/objc/abstract/MCOConstants.h

@@ -413,6 +413,10 @@ typedef NS_ENUM(NSInteger, MCOErrorCode) {
     MCOErrorNoValidServerFound,
     /** Error while running custom command */
     MCOErrorCustomCommand,
+    /** Spam was suspected by server */
+    MCOErrorSendMessageSpamSuspected,
+    /** Daily limit of sent messages was hit */
+    MCOErrorSendMessageDailyLimitExceeded,
     /** The count of all errors */
     MCOErrorCodeCount,
 };