Merge pull request #399 from MangoInstantMessenger/editorconfig

editor config updates | dictionary commit | minor clean ups

Author: kolosovpetro

.editorconfig

@@ -1,18 +1,26 @@
-# Remove the line below if you want to inherit .editorconfig settings from higher directories
 root = true
 
-# C# files
+# noinspection EditorConfigKeyCorrectness
 [*.cs]
-dotnet_diagnostic.CA1824.severity = none
+dotnet_diagnostic.CA1824.severity = warning
+dotnet_diagnostic.IDE0005.severity = warning
+dotnet_diagnostic.CA1707.severity = warning
+dotnet_diagnostic.CA1822.severity = warning
+dotnet_diagnostic.CA1416.severity = warning
+dotnet_diagnostic.IDE0072.severity = warning
+dotnet_diagnostic.IDE0270.severity = warning
+
+# populate switch
+dotnet_diagnostic.IDE0010.severity = warning
+
+# fix formatting
 dotnet_diagnostic.IDE0055.severity = none
-dotnet_diagnostic.IDE0005.severity = none
+
+# if statement can be simplified
+dotnet_diagnostic.IDE0046.severity = warning
+
+# expression value never used
 dotnet_diagnostic.IDE0058.severity = none
-dotnet_diagnostic.CA1707.severity = none
-dotnet_diagnostic.CA1822.severity = none
-dotnet_diagnostic.IDE0046.severity = none
-dotnet_diagnostic.CA1416.severity = none
-dotnet_diagnostic.IDE0072.severity = none
-dotnet_diagnostic.IDE0270.severity = none
 
 #### Core EditorConfig Options ####
 
@@ -264,4 +272,17 @@ charset = utf-8
 
 # Set severity = error for all analyzers
 
-dotnet_analyzer_diagnostic.severity = error
+dotnet_analyzer_diagnostic.severity = error
+
+# resharper rules
+
+resharper_inconsistent_naming_highlighting = none
+resharper_built_in_type_reference_style_for_member_access_highlighting = none
+resharper_arrange_object_creation_when_type_evident_highlighting = none
+resharper_arrange_trailing_comma_in_multiline_lists_highlighting = none
+resharper_arrange_trailing_comma_in_singleline_lists_highlighting = none
+resharper_comment_typo_highlighting = warning
+resharper_identifier_typo_highlighting = warning
+resharper_string_literal_typo_highlighting = warning
+resharper_unused_type_global_highlighting = warning
+resharper_unused_member_global_highlighting = warning

.github/workflows/build-angular.yml

@@ -4,7 +4,7 @@ on:
   push:
     branches:
       - develop
-      - cache
+      - master
 
   pull_request:
     branches: [ develop ]

.github/workflows/run-openssl-dh-handshake.yml

@@ -1,8 +1,6 @@
 name: Run OpenSSL DH Handshake
 
 on:
-  push:
-    branches: [ MANGO-520 ]
   workflow_dispatch:
 
 jobs:

MangoAPI.Application/Interfaces/ICorrelationContext.cs

@@ -5,6 +5,4 @@ namespace MangoAPI.Application.Interfaces;
 public interface ICorrelationContext
 {
     public Guid GetUserId();
-
-    public string GetUserName();
 }

MangoAPI.Application/Services/CorrelationContext.cs

@@ -28,16 +28,4 @@ public Guid GetUserId()
                 $"User ID cannot be parsed. {nameof(correlationContextUserId)}.")
             : parsedUserId;
     }
-
-    public string GetUserName()
-    {
-        var context = httpContextAccessor.HttpContext;
-
-        var correlationUserName = context.User.FindFirstValue(JwtRegisteredClaimNames.Name);
-
-        return string.IsNullOrEmpty(correlationUserName)
-            ? throw new InvalidOperationException(
-                $"User Name cannot be null or empty. {nameof(correlationUserName)}.")
-            : correlationUserName;
-    }
 }

MangoAPI.BusinessLogic/ApiCommands/Users/RegisterCommandHandler.cs

@@ -161,7 +161,7 @@ public async Task<Result<TokensResponse>> Handle(RegisterCommand request, Cancel
 
         dbContext.Chats.Add(mangoChatEntity);
         dbContext.UserChats.AddRange(userChats);
-        dbContext.Messages.AddRange(new [] {firstMessage, secondMessage});
+        dbContext.Messages.AddRange(firstMessage, secondMessage);
 
         await dbContext.SaveChangesAsync(cancellationToken);
 

MangoAPI.BusinessLogic/ApiQueries/AppInfo/GetAppInfoQuery.cs

@@ -3,4 +3,4 @@
 
 namespace MangoAPI.BusinessLogic.ApiQueries.AppInfo;
 
-public record GetAppInfoQuery() : IRequest<Result<GetAppInfoResponse>>;
+public record GetAppInfoQuery : IRequest<Result<GetAppInfoResponse>>;

MangoAPI.BusinessLogic/ApiQueries/AppInfo/GetAppInfoResponse.cs

@@ -3,17 +3,12 @@
 
 namespace MangoAPI.BusinessLogic.ApiQueries.AppInfo;
 
-public record GetAppInfoResponse() : ResponseBase
+public record GetAppInfoResponse : ResponseBase
 {
     public Models.AppInfo AppInfo { get; set; }
-    
+
     public static GetAppInfoResponse FromSuccess(Models.AppInfo appInfo)
     {
-        return new()
-        {
-            Message = ResponseMessageCodes.Success,
-            Success = true,
-            AppInfo = appInfo
-        };
+        return new GetAppInfoResponse { Message = ResponseMessageCodes.Success, Success = true, AppInfo = appInfo };
     }
-};
+}

MangoAPI.BusinessLogic/ApiQueries/Communities/GetCurrentUserChatsResponse.cs

@@ -11,7 +11,7 @@ public record GetCurrentUserChatsResponse : ResponseBase
 
     public static GetCurrentUserChatsResponse FromSuccess(List<Chat> chats)
     {
-        return new()
+        return new GetCurrentUserChatsResponse
         {
             Message = ResponseMessageCodes.Success,
             Success = true,

MangoAPI.BusinessLogic/ApiQueries/Messages/SearchChatMessagesResponse.cs

@@ -11,7 +11,7 @@ public record SearchChatMessagesResponse : ResponseBase
 
     public static SearchChatMessagesResponse FromSuccess(List<Message> messages)
     {
-        return new()
+        return new SearchChatMessagesResponse
         {
             Messages = messages,
             Message = ResponseMessageCodes.Success,