Merge pull request #411 from Ketteiteki/remove_registration_checkbox

remove registration checkbox

Author: kolosovpetro

MangoAPI.BusinessLogic/ApiCommands/Users/RegisterCommand.cs

@@ -6,6 +6,5 @@ namespace MangoAPI.BusinessLogic.ApiCommands.Users;
 public record RegisterCommand(
         string Email,
         string DisplayName,
-        string Password,
-        bool TermsAccepted)
+        string Password)
     : IRequest<Result<TokensResponse>>;

MangoAPI.BusinessLogic/ApiCommands/Users/RegisterCommandValidator.cs

@@ -21,7 +21,5 @@ public RegisterCommandValidator()
         RuleFor(x => x.DisplayName)
             .NotEmpty()
             .Length(1, 50);
-
-        RuleFor(x => x.TermsAccepted).Equal(true);
     }
 }

MangoAPI.BusinessLogic/ApiCommands/Users/RegisterRequest.cs

@@ -9,13 +9,11 @@ public record RegisterRequest
     public RegisterRequest(
         string email,
         string displayName,
-        string password,
-        bool termsAccepted)
+        string password)
     {
         Email = email;
         DisplayName = displayName;
         Password = password;
-        TermsAccepted = termsAccepted;
     }
 
     [DefaultValue("test@gmail.com")]
@@ -26,7 +24,4 @@ public RegisterRequest(
 
     [DefaultValue("x[?6dME#xrp=nr7q")]
     public string Password { get; }
-
-    [DefaultValue(true)]
-    public bool TermsAccepted { get; }
 }

MangoAPI.Client/src/app/components/register/register.component.html

@@ -33,20 +33,6 @@ <h4 class="mb-4 text-center">We are Different, We Make You Different.</h4>
       [(ngModel)]="registerCommand.password"
     />
 
-    <p class="justify-content-end">*any 8 chars</p>
-
-    <div class="d-inline-flex flex-row">
-      <label for="termsAccepted"></label>
-      <input
-        class="terms-of-service"
-        id="termsAccepted"
-        name="termsAccepted"
-        type="checkbox"
-        [(ngModel)]="registerCommand.termsAccepted"
-      />
-      <p class="text-nowrap">I accept terms of service</p>
-    </div>
-
     <button class="form-button p-3 font-weight-bold mb-3" (click)="onRegisterClick()">
       REGISTER
     </button>

MangoAPI.Client/src/app/components/register/register.component.ts

@@ -25,7 +25,6 @@ export class RegisterComponent implements OnDestroy {
     displayName: '',
     email: '',
     password: '',
-    termsAccepted: false
   };
 
   componentDestroyed$: Subject<boolean> = new Subject();
@@ -61,11 +60,6 @@ export class RegisterComponent implements OnDestroy {
       return;
     }
 
-    if (!this.registerCommand.termsAccepted) {
-      alert('Terms not accepted');
-      return;
-    }
-
     this._usersService
       .createUser(this.registerCommand)
       .pipe(takeUntil(this.componentDestroyed$))

MangoAPI.Client/src/app/types/requests/RegisterCommand.ts

@@ -2,12 +2,10 @@
   email: string;
   displayName: string;
   password: string;
-  termsAccepted: boolean;
 
-  constructor(email: string, displayName: string, password: string, termsAccepted: boolean) {
+  constructor(email: string, displayName: string, password: string) {
     this.email = email;
     this.displayName = displayName;
     this.password = password;
-    this.termsAccepted = termsAccepted;
   }
 }

MangoAPI.IntegrationTests/Helpers/CommandHelper.cs

@@ -17,8 +17,7 @@ public static RegisterCommand RegisterKhachaturCommand()
         var command = new RegisterCommand(
             Email: "xachulxx@gmail.com",
             DisplayName: "Khachatur Khachatryan",
-            Password: "Bm3-`dPRv-/w#3)cw^97",
-            TermsAccepted: true);
+            Password: "Bm3-`dPRv-/w#3)cw^97");
 
         return command;
     }
@@ -28,8 +27,7 @@ public static RegisterCommand RegisterPetroCommand()
         var command = new RegisterCommand(
             Email: "kolosovp95@gmail.com",
             DisplayName: "Petro Kolosov",
-            Password: "Bm3-`dPRv-/w#3)cw^97",
-            TermsAccepted: true);
+            Password: "Bm3-`dPRv-/w#3)cw^97");
 
         return command;
     }