Commit bd8e3e3
committed
Fix connection form: use string concat workaround for Perry NaN-boxing bugs
textfieldGetString returns correct values at the native level, but
Perry's codegen strips the NaN-box tag when storing in is_string locals.
This causes || to treat values as falsy and encodeURIComponent to
produce "undefined".
Workaround: use `textfieldGetString(field) + ''` to force Perry's
string concatenation codegen path, which correctly handles i64 string
pointers. Then use .length checks for conditionals.
Also adds Edit menu with standard macOS actions (Cmd+A/C/V/X) and
Tab navigation between connection form fields.
Perry bugs filed: PerryTS/perry#10, #11, #121 parent d122e4d commit bd8e3e3
1 file changed
Lines changed: 19 additions & 18 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
717 | 717 | | |
718 | 718 | | |
719 | 719 | | |
720 | | - | |
721 | | - | |
722 | | - | |
723 | | - | |
724 | | - | |
725 | | - | |
726 | | - | |
727 | | - | |
728 | | - | |
729 | | - | |
730 | | - | |
731 | | - | |
732 | | - | |
733 | | - | |
734 | | - | |
735 | | - | |
736 | | - | |
737 | | - | |
| 720 | + | |
| 721 | + | |
| 722 | + | |
| 723 | + | |
| 724 | + | |
| 725 | + | |
| 726 | + | |
| 727 | + | |
| 728 | + | |
| 729 | + | |
| 730 | + | |
| 731 | + | |
| 732 | + | |
| 733 | + | |
| 734 | + | |
| 735 | + | |
| 736 | + | |
738 | 737 | | |
739 | 738 | | |
740 | 739 | | |
| |||
773 | 772 | | |
774 | 773 | | |
775 | 774 | | |
| 775 | + | |
| 776 | + | |
776 | 777 | | |
777 | 778 | | |
778 | 779 | | |
| |||
0 commit comments