(Added) Enhance mutation testing coverage with logical condition tests (#49)

* test(mutation): Add comprehensive logical condition tests

- Add Mac/Mc prefix handling tests targeting LogicalAnd mutations
- Implement single character optimisation tests for mutation coverage
- Test edge cases where both conditions must be true for code paths
- Verify proper handling of array vs string parameter combinations
- Enhance test coverage for logical operators in nameFix and strReplace

These tests specifically target mutation testing scenarios by validating
that logical AND conditions work correctly. The new test methods ensure
that both conditions in logical expressions must be satisfied for the
intended behaviour to occur, improving the robustness of mutation
testing coverage.

Signed-off-by: Marjo van Lier <marjo.vanlier@gmail.com>

* chore: Enable manual approval for PR-Agent

- Disable enable_auto_approval setting
- Add require_approval = true configuration
- Remove auto_approve commands from pr_commands and push_commands
- PR-Agent will now require manual approval instead of automatic approval

Co-authored-by: Marjo <MarjovanLier@users.noreply.github.com>

---------

Signed-off-by: Marjo van Lier <marjo.vanlier@gmail.com>
Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
Co-authored-by: Marjo <MarjovanLier@users.noreply.github.com>

Author: MarjovanLier

.pr_agent.toml

@@ -11,7 +11,8 @@ require_all_thresholds_for_incremental_review = false
 minimal_commits_for_incremental_review = 2
 minimal_minutes_for_incremental_review = 10
 enable_help_text = false
-enable_auto_approval = true
+enable_auto_approval = false
+require_approval = true
 maximal_review_effort = 5
 
 [pr_code_suggestions]
@@ -34,7 +35,7 @@ pr_commands = [
     "/describe --pr_description.add_original_user_description=true --pr_description.keep_original_user_title=true",
     "/update_changelog --pr_update_changelog.push_changelog_changes=false",
     "/improve --extended --pr_code_suggestions.summarize=true",
-    "/review auto_approve --pr_reviewer.num_code_suggestions=0 --pr_reviewer.inline_code_comments=true",
+    "/review --pr_reviewer.num_code_suggestions=0 --pr_reviewer.inline_code_comments=true",
 ]
 push_commands = [
     "/describe --pr_description.add_original_user_description=true --pr_description.keep_original_user_title=true",
@@ -53,6 +54,6 @@ push_commands = [
        --pr_reviewer.minimal_minutes_for_incremental_review=10 \
        --pr_reviewer.extra_instructions='' \
     """,
-    "/review auto_approve --pr_reviewer.num_code_suggestions=0 --pr_reviewer.inline_code_comments=true"
+    "/review --pr_reviewer.num_code_suggestions=0 --pr_reviewer.inline_code_comments=true"
 ]
 handle_push_trigger = true

tests/Unit/NameFixTest.php

@@ -80,4 +80,38 @@ public function testNameFixWithNumericInput(): void
     {
         self::assertEquals('12345', StringManipulation::nameFix('12345'));
     }
+
+
+    /**
+     * Test that Mac/Mc prefix handling requires both conditions to be true.
+     * This targets the LogicalAnd mutations in the nameFix function.
+     */
+    public function testMacMcPrefixHandlingLogicalConditions(): void
+    {
+        // Test cases where 'mc' exists but is followed by a space (should NOT trigger fix)
+        self::assertEquals('Mc Donald', StringManipulation::nameFix('mc donald'));
+        self::assertEquals('Mc Lean', StringManipulation::nameFix('mc lean'));
+
+        // Test cases where 'mac' exists but is followed by a space (should NOT trigger fix)
+        self::assertEquals('Mac Donald', StringManipulation::nameFix('mac donald'));
+        self::assertEquals('Mac Lean', StringManipulation::nameFix('mac lean'));
+
+        // Test cases where 'mc' exists and is NOT followed by a space (SHOULD trigger fix)
+        self::assertEquals('McDonald', StringManipulation::nameFix('mcdonald'));
+        self::assertEquals('McLean', StringManipulation::nameFix('mclean'));
+
+        // Test cases where 'mac' exists and is NOT followed by a space (SHOULD trigger fix)
+        self::assertEquals('MacDonald', StringManipulation::nameFix('macdonald'));
+        self::assertEquals('MacLean', StringManipulation::nameFix('maclean'));
+
+        // Test cases where prefix doesn't exist at all
+        self::assertEquals("O'brien", StringManipulation::nameFix("o'brien"));
+        self::assertEquals('Johnson', StringManipulation::nameFix('johnson'));
+
+        // Test complex cases with multiple occurrences
+        self::assertEquals('MacDonald-McDonald', StringManipulation::nameFix('macdonald-mcdonald'));
+
+        // Test edge case where both conditions in OR would be true but should only trigger once
+        self::assertEquals('MacDonald Mac Smith', StringManipulation::nameFix('macdonald mac smith'));
+    }
 }

tests/Unit/StrReplaceTest.php

@@ -127,6 +127,47 @@ public function testEmptyStringOptimisation(): void
     }
 
 
+    /**
+     * Test that verifies both conditions are required for single character optimisation.
+     * This targets the LogicalAnd mutations in the strReplace function.
+     */
+    public function testSingleCharacterOptimisationRequiresBothConditions(): void
+    {
+        // Use variables to avoid Psalm's literal string analysis
+        $testString = 'banana';
+        $searchChar = 'a';
+        $replaceChar = 'z';
+        $expectedResult = 'bznznz';
+
+        // Case 1: Array search with single character - should NOT use strtr optimisation
+        $result1 = StringManipulation::strReplace([$searchChar], $replaceChar, $testString);
+        self::assertSame($expectedResult, $result1);
+
+        // Case 2: Array types - should NOT use strtr optimisation
+        $result2 = StringManipulation::strReplace([$searchChar], [$replaceChar], $testString);
+        self::assertSame($expectedResult, $result2);
+
+        // Case 3: Both string types but length > 1 - should NOT use strtr optimisation
+        $result3 = StringManipulation::strReplace('an', $replaceChar, $testString);
+        self::assertSame('bzza', $result3);
+
+        // Case 4: Both conditions met - SHOULD use strtr optimisation
+        $result4 = StringManipulation::strReplace($searchChar, $replaceChar, $testString);
+        self::assertSame($expectedResult, $result4);
+
+        // Case 5: Test empty string case - should NOT use strtr optimisation
+        $result5 = StringManipulation::strReplace('', $replaceChar, $testString);
+        self::assertSame($testString, $result5);
+
+        // Case 6: Test longer string case - should NOT use strtr optimisation
+        $result6 = StringManipulation::strReplace('ban', 'can', $testString);
+        self::assertSame('canana', $result6);
+
+        // All single-character replacements tested above should produce consistent results
+        // The individual assertions above verify that different code paths work correctly
+    }
+
+
     /**
      * Test comprehensive array-based string replacements.
      */