(Changed) Update to PHP 8.3 and Enforce Explicit Type Declarations (#43)

* chore!: Set minimum required PHP version to 8.3

- Remove references to PHP 8.2 in workflows and configuration files
- Update composer constraints to reflect the new requirement
- Align development and production environments with PHP 8.3

BREAKING CHANGE: Environments must now use PHP 8.3 or higher.

* style: Add type hints and formatting

- Introduce explicit type declarations for clarity and type safety
- Remove redundant comments to streamline the code
- Correct formatting for improved readability and consistency

These changes align the codebase with established style guidelines,
making it easier to maintain and collaborate on.

Author: MarjovanLier

.github/workflows/codecov.yml

@@ -9,10 +9,10 @@ jobs:
         with:
           fetch-depth: 0
 
-      - name: Set up php 8.2
+      - name: Set up php 8.3
         uses: shivammathur/setup-php@v2
         with:
-          php-version: "8.2"
+          php-version: "8.3"
           extensions: mbstring, xml, zip, pdo_mysql, xhprof
 
       - name: Install dependencies

.github/workflows/php.yml

@@ -15,7 +15,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        php-versions: ["8.2", "8.3", "8.4"]
+        php-versions: ["8.3", "8.4"]
 
     steps:
       # This step checks out a copy of your repository.

.phan/config.php

@@ -54,8 +54,8 @@
     //
     // Note that the **only** effect of choosing `'5.6'` is to infer that functions removed in php 7.0 exist.
     // (See `backward_compatibility_checks` for additional options)
-    // Automatically inferred from composer.json requirement for "php" of "^8.2"
-    'target_php_version' => '8.2',
+    // Automatically inferred from composer.json requirement for "php" of "^8.3"
+    'target_php_version' => '8.3',
 
     // If enabled, missing properties will be created when
     // they are first seen. If false, we'll report an

README.md

@@ -209,7 +209,7 @@ And to run tests matching a specific name pattern:
 
 ## System Requirements
 
-- PHP 8.2 or later.
+- PHP 8.3 or later.
 
 ## Support
 

composer.json

@@ -42,7 +42,7 @@
   },
   "minimum-stability": "stable",
   "require": {
-    "php": ">=8.2.0|>=8.3.0|>=8.4.0"
+    "php": ">=8.3.0|>=8.4.0"
   },
   "require-dev": {
     "enlightn/security-checker": ">=2.0",

phpstan.neon

@@ -1,6 +1,6 @@
 parameters:
     level: max
-    phpVersion: 80200
+    phpVersion: 80300
     treatPhpDocTypesAsCertain: false
     tipsOfTheDay: false
     reportWrongPhpDocTypeInVarTag: true

rector.php

@@ -43,17 +43,17 @@
     $rectorConfig->rule(SeparateMultiUseImportsRector::class);
     $rectorConfig->rule(SplitDoubleAssignRector::class);
 
-    $rectorConfig->phpVersion(PhpVersion::PHP_82);
+    $rectorConfig->phpVersion(PhpVersion::PHP_83);
 
     // define sets of rules
     $rectorConfig->sets(
         [
-            LevelSetList::UP_TO_PHP_82,
+            LevelSetList::UP_TO_PHP_83,
             SetList::CODE_QUALITY,
             SetList::CODING_STYLE,
             SetList::DEAD_CODE,
             SetList::EARLY_RETURN,
-            SetList::PHP_82,
+            SetList::PHP_83,
             SetList::TYPE_DECLARATION,
             SetList::NAMING,
             SetList::PRIVATIZATION,

src/AccentNormalization.php

@@ -25,10 +25,8 @@ trait AccentNormalization
     /**
      * An array of characters with accents and special characters. These characters are intended to be replaced
      * in a string to normalize it.
-     *
-     * @var string[]
      */
-    private const REMOVE_ACCENTS_FROM = [
+    private const array REMOVE_ACCENTS_FROM = [
         '*',
         '?',
         '’',
@@ -271,10 +269,8 @@ trait AccentNormalization
     /**
      * An array of characters without accents. These characters correspond to the characters in the
      * REMOVE_ACCENTS_FROM array and are used to replace them in a string.
-     *
-     * @var string[]
      */
-    private const REMOVE_ACCENTS_TO = [
+    private const array REMOVE_ACCENTS_TO = [
         ' ',
         ' ',
         "'",

src/StringManipulation.php

@@ -194,7 +194,7 @@ public static function nameFix(#[SensitiveParameter] ?string $lastName): ?string
      * processing text for storage in a database or file system that does not support UTF-8 encoding.
      *
      * @param null|string $valor The input string to be converted from UTF-8 to ANSI. If null, the function will return
-     *                           an empty string.
+     *                            an empty string.
      *
      * @return string The converted string in ANSI encoding.
      *
@@ -282,7 +282,7 @@ public static function strReplace(array|string $search, array|string $replace, s
      *
      * @param string $date The date string to validate. This should be a string representing a date.
      * @param string $format The expected date format. Default is 'Y-m-d H:i:s'. This should be a string representing
-     *                       the expected format of the date.
+     *                        the expected format of the date.
      *
      * @return bool Returns true if the date string matches the format and is logically valid, false otherwise.
      *

src/UnicodeMappings.php

@@ -24,10 +24,8 @@ trait UnicodeMappings
     /**
      * An associative array mapping Unicode characters to their ANSI counterparts.
      * The keys of the array are Unicode characters, and the values are the corresponding ANSI characters.
-     *
-     * @var array<string, string>
      */
-    private const UTF8_ANSI2 = [
+    private const array UTF8_ANSI2 = [
         '\u00c0' => 'À',
         '\u00c1' => 'Á',
         '\u00c2' => 'Â',