Skip to content
This repository was archived by the owner on Dec 16, 2023. It is now read-only.

Commit e6a7b45

Browse files
committed
Prevent attempting to update FCM token when sign in/up fails
1 parent ed21005 commit e6a7b45

3 files changed

Lines changed: 9 additions & 4 deletions

File tree

app/src/main/java/com/marknkamau/justjava/ui/completeSignUp/CompleteSignUpViewModel.kt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ class CompleteSignUpViewModel(private val usersRepository: UsersRepository, priv
1919
viewModelScope.launch {
2020
_loading.value = true
2121
liveData.value = usersRepository.updateUser(firstName, lastName, mobile, email)
22-
usersRepository.updateFcmToken(firebaseService.getFcmToken())
2322
_loading.value = false
2423
}
2524

app/src/main/java/com/marknkamau/justjava/ui/login/SignInViewModel.kt

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,9 @@ class SignInViewModel(
2626
_loading.value = true
2727
liveData.value = authRepository.signInWithGoogle(idToken)
2828

29-
usersRepository.updateFcmToken(firebaseService.getFcmToken())
29+
if(liveData.value is Resource.Success){
30+
usersRepository.updateFcmToken(firebaseService.getFcmToken())
31+
}
3032

3133
_loading.value = false
3234
}
@@ -41,7 +43,9 @@ class SignInViewModel(
4143
_loading.value = true
4244
liveData.value = authRepository.signIn(email, password)
4345

44-
usersRepository.updateFcmToken(firebaseService.getFcmToken())
46+
if(liveData.value is Resource.Success){
47+
usersRepository.updateFcmToken(firebaseService.getFcmToken())
48+
}
4549

4650
_loading.value = false
4751
}

app/src/main/java/com/marknkamau/justjava/ui/signup/SignUpViewModel.kt

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,9 @@ class SignUpViewModel(
3232
_loading.value = true
3333
livedata.value = authRepository.signUp(firstName, lastName, mobile, email, password)
3434

35-
usersRepository.updateFcmToken(firebaseService.getFcmToken())
35+
if(livedata.value is Resource.Success){
36+
usersRepository.updateFcmToken(firebaseService.getFcmToken())
37+
}
3638

3739
_loading.value = false
3840
}

0 commit comments

Comments
 (0)