Directory as database parameter.

Author: MartinRixham

src/repository/rocksdb_repository.cpp

@@ -6,13 +6,16 @@
 #include "error.h"
 #include "rocksdb_repository.h"
 
-repository::rocksdb_repository::rocksdb_repository()
+repository::rocksdb_repository::rocksdb_repository(const std::string &directory)
 {
 	rocksdb::Options options;
 	options.create_if_missing = true;
 
-	std::filesystem::create_directory("/tmp/asyncdb");
-	rocksdb::Status status = rocksdb::DB::Open(options, "/tmp/asyncdb/" + std::to_string(std::rand()), &database);
+	std::filesystem::path directory_path = std::filesystem::path(directory);
+	std::filesystem::create_directories(directory_path);
+
+	std::filesystem::path database_path = directory_path / std::to_string(std::rand());
+	rocksdb::Status status = rocksdb::DB::Open(options, database_path.string(), &database);
 
 	if (!status.ok())
 	{

src/repository/rocksdb_repository.h

@@ -1,6 +1,8 @@
 #ifndef REPOSITORY_ROCSKDB_REPOSITORY_H
 #define REPOSITORY_ROCSKDB_REPOSITORY_H
 
+#include <string>
+
 #include "repository.h"
 
 namespace repository
@@ -10,7 +12,7 @@ namespace repository
 		rocksdb::DB *database;
 
 		public:
-			rocksdb_repository();
+			explicit rocksdb_repository(const std::string &directory);
 
 			void create_table(const table::table &table) override;
 

src/server/server.cpp

@@ -13,7 +13,7 @@ server::server::server(
 		thread_count(threads),
 		io_context(thread_count),
 		acceptor(boost::asio::make_strand(io_context)),
-		repository(repository::rocksdb_repository()),
+		repository(repository::rocksdb_repository("/tmp/asyncdb")),
 		router(router::router(repository))
 {
 	boost::beast::error_code error;

test/repository/rocksdb_repository_test.cpp

@@ -1,5 +1,6 @@
 #include <set>
 #include <vector>
+#include <filesystem>
 
 #include <gtest/gtest.h>
 #include <rocksdb/db.h>
@@ -13,15 +14,33 @@ class repository_test: public ::testing::Test
 protected:
 	repository::rocksdb_repository repository;
 
-	void SetUp()
+	repository::rocksdb_repository faulty_repository;
+
+	repository_test():
+		repository("/tmp/asyncdb"),
+		faulty_repository("/tmp/faulty")
 	{
 	}
 
-	void TearDown()
+	void SetUp() override
+	{
+	}
+
+	void TearDown() override
 	{
 	}
 };
 
+TEST_F(repository_test, fail_to_create_table_with_faulty_repository)
+{
+	faulty_repository.create_table(table::valid_table("first table", std::vector<std::string>()));
+
+	std::set<table::table> table_set = faulty_repository.list_tables();
+	std::vector<table::table> tables(table_set.begin(), table_set.end());
+
+	EXPECT_EQ(tables.size(), 1);
+}
+
 TEST_F(repository_test, create_and_read_tables)
 {
 	repository.create_table(table::valid_table("first table", std::vector<std::string>()));