fix: Bad mapper for default value (heftapp#312)

Author: budde377

packages/graphql_codegen/CHANGELOG.md

@@ -1,3 +1,7 @@
+# 0.13.6
+
+- Fix bad copy class on list with default value.
+
 # 0.13.5
 
 - Run builder before `json_serializable`

packages/graphql_codegen/example/pubspec.lock

@@ -329,7 +329,7 @@ packages:
       path: ".."
       relative: true
     source: path
-    version: "0.13.5"
+    version: "0.13.6"
   graphql_flutter:
     dependency: "direct main"
     description:

packages/graphql_codegen/lib/src/context/context.dart

@@ -4,6 +4,7 @@ import 'package:gql/ast.dart';
 import 'package:graphql_codegen/src/context/schema.dart';
 import 'package:graphql_codegen/src/config/config.dart';
 import 'package:graphql_codegen/src/errors.dart';
+import 'package:graphql_codegen/src/printer/base/utils.dart';
 import 'package:graphql_codegen/src/transform/add_typename_transforming_visitor.dart';
 
 import 'name.dart';
@@ -161,6 +162,9 @@ class ContextProperty {
   final List<DirectiveNode> fieldDirectives;
   final bool hasDefaultValue;
 
+  TypeNode get nullableTypeOnDefaultValue =>
+      hasDefaultValue ? typeNodeAsNullable(type) : type;
+
   NameNode get name => alias ?? _name;
 
   ContextProperty({

packages/graphql_codegen/lib/src/printer/base/deep_copy.dart

@@ -72,7 +72,7 @@ Method? _printDeepCopyTypeNode(
   ContextProperty property,
   bool abstract,
 ) {
-  final node = property.type;
+  final node = property.nullableTypeOnDefaultValue;
   final namePrinter = printContext.namePrinter;
   final propertyName = namePrinter.printPropertyName(property.name);
   final copyClassName = namePrinter.printCopyWithClassName(

packages/graphql_codegen/lib/src/printer/base/equality.dart

@@ -6,25 +6,6 @@ import 'package:graphql_codegen/src/printer/context.dart';
 
 typedef DataObjResolver = Expression Function();
 
-TypeNode _typeNodeAsNullable(TypeNode node) {
-  if (!node.isNonNull) {
-    return node;
-  }
-  if (node is ListTypeNode) {
-    return ListTypeNode(
-      type: node.type,
-      isNonNull: false,
-    );
-  }
-  if (node is NamedTypeNode) {
-    return NamedTypeNode(
-      name: node.name,
-      isNonNull: false,
-    );
-  }
-  return node;
-}
-
 Method printEqualityOperator(
   PrintContext c,
   String name,
@@ -72,7 +53,7 @@ Method printEqualityOperator(
                   ),
                 ],
                 _printPropertyEqualityCheck(
-                  e.hasDefaultValue ? _typeNodeAsNullable(e.type) : e.type,
+                  e.nullableTypeOnDefaultValue,
                   localThisName,
                   localOtherName,
                 )
@@ -142,9 +123,7 @@ Method printHashCodeMethod(
                         final localProp = context.namePrinter
                             .printLocalPropertyName(property.name);
                         final hash = _printPropertyHash(
-                          property.hasDefaultValue
-                              ? _typeNodeAsNullable(property.type)
-                              : property.type,
+                          property.nullableTypeOnDefaultValue,
                           refer(localProp),
                         );
                         if (dataObjectCheckResolver != null &&

packages/graphql_codegen/lib/src/printer/base/utils.dart

@@ -0,0 +1,20 @@
+import 'package:gql/ast.dart';
+
+TypeNode typeNodeAsNullable(TypeNode node) {
+  if (!node.isNonNull) {
+    return node;
+  }
+  if (node is ListTypeNode) {
+    return ListTypeNode(
+      type: node.type,
+      isNonNull: false,
+    );
+  }
+  if (node is NamedTypeNode) {
+    return NamedTypeNode(
+      name: node.name,
+      isNonNull: false,
+    );
+  }
+  return node;
+}

packages/graphql_codegen/pubspec.yaml

@@ -3,7 +3,7 @@ description: |
   Simple, opinionated, codegen library for GraphQL. It allows you to
   generate serializers and client helpers to easily call and parse your data.
 
-version: 0.13.5
+version: 0.13.6
 homepage: https://github.com/heftapp/graphql_codegen/tree/main/packages/graphql_codegen
 repository: https://github.com/heftapp/graphql_codegen/tree/main/packages/graphql_codegen
 

packages/graphql_codegen/test/assets/issue_309/document.graphql

@@ -0,0 +1,19 @@
+input TemplateDisciplineTopicContentInput {
+  howStudyIt: String!
+  infoContentBlocks: [I1!]!
+  taskContentBlocks: [I2!]
+  testContentBlocks: [I3!]! = []
+  whyStudyIt: String!
+}
+
+input I1 {
+  data: String
+}
+
+input I2 {
+  data: String
+}
+
+input I3 {
+  data: String
+}