deal manager secondary trades#109
Draft
Detoo wants to merge 3 commits into
Draft
Conversation
17cf059 to
e82f873
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO
Updated
LexScroWLitewith secondary trade logic because the overlaps between primary and secondary trades turns out to be too small to worth sharing the same base contractLexScroWLite, they will be mostly non-overlapping if...else branches. Why risking re-auditLexScroWLiteif most of its codes are re-written?DealManagerthrough a dedicated storageSecondaryTradeStorage; this way we don't need to deploy a new manager (and its factory)