Skip to content

deal manager secondary trades#109

Draft
Detoo wants to merge 3 commits into
developfrom
feat/deal-manager-secondary-trades
Draft

deal manager secondary trades#109
Detoo wants to merge 3 commits into
developfrom
feat/deal-manager-secondary-trades

Conversation

@Detoo

@Detoo Detoo commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

TODO

  • Contract size too large. Will move stuff to storage
  • Review aginst specs and add more tests
  • All interfaces are placeholders for unit-test purposes (i.e. method names are not final)

Updated

  • Spec: decided not to extend LexScroWLite with secondary trade logic because the overlaps between primary and secondary trades turns out to be too small to worth sharing the same base contract
    • The underlying NFT pathways are very different. If we implement both inside LexScroWLite, they will be mostly non-overlapping if...else branches. Why risking re-audit LexScroWLite if most of its codes are re-written?
    • However, secondary trading logic will still live on DealManager through a dedicated storage SecondaryTradeStorage; this way we don't need to deploy a new manager (and its factory)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant