Skip to content
This repository was archived by the owner on Nov 9, 2023. It is now read-only.

Commit 2860ab9

Browse files
authored
Fix callback batch request handling (#61)
1 parent cb69d58 commit 2860ab9

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

src/index.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,8 @@ module.exports = class RpcEngine extends SafeEventEmitter {
2626
if (Array.isArray(req)) {
2727
if (cb) {
2828
this._handleBatch(req)
29-
.catch((err) => cb(err)) // fatal error
3029
.then((res) => cb(null, res))
30+
.catch((err) => cb(err)) // fatal error
3131
return undefined
3232
}
3333
return this._handleBatch(req)
@@ -45,7 +45,7 @@ module.exports = class RpcEngine extends SafeEventEmitter {
4545

4646
async _handleBatch (reqs) {
4747
// The order here is important
48-
// 3a. Return batch response, or reject on some kind of fatal error
48+
// 3. Return batch response, or reject on some kind of fatal error
4949
return await Promise.all( // 2. Wait for all requests to finish
5050
// 1. Begin executing each request in the order received
5151
reqs.map(this._promiseHandle.bind(this)),

0 commit comments

Comments
 (0)