Skip to content

Commit 7157707

Browse files
committed
Remove AssetsEndpoint.update
1 parent 589683c commit 7157707

4 files changed

Lines changed: 10 additions & 43 deletions

File tree

metafold/assets.py

Lines changed: 0 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -115,30 +115,6 @@ def create(
115115
fp.close()
116116
return Asset(**r.json())
117117

118-
def update(
119-
self, asset_id: str,
120-
f: Union[str, bytes, PathLike, IO[bytes]],
121-
project_id: Optional[str] = None,
122-
) -> Asset:
123-
"""Update an asset.
124-
125-
Args:
126-
asset_id: ID of asset to update.
127-
f: File-like object (opened in binary mode) or path to file on disk.
128-
project_id: Asset project ID.
129-
130-
Returns:
131-
Updated asset resource.
132-
"""
133-
project_id = self._client.project_id(project_id)
134-
fp: IO[bytes] = _open_file(f)
135-
try:
136-
url = f"/projects/{project_id}/assets/{asset_id}"
137-
r: Response = self._client.patch(url, files={"file": fp})
138-
finally:
139-
fp.close()
140-
return Asset(**r.json())
141-
142118
def delete(self, asset_id: str, project_id: Optional[str] = None) -> None:
143119
"""Delete an asset.
144120

metafold/jobs.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,10 @@ class Job:
3838
default=None,
3939
)
4040
state: str
41-
assets: list[Asset] = field(converter=_assets)
41+
assets: Optional[list[Asset]] = field(
42+
converter=lambda v: optional(_assets)(v),
43+
default=None,
44+
)
4245
meta: dict[str, Any]
4346

4447

tests/test_assets.py

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -171,19 +171,6 @@ def test_create_asset(client):
171171
)
172172

173173

174-
def test_update_asset(client):
175-
with open(test_file, "rb") as f:
176-
a = client.assets.update("1", f)
177-
assert a == Asset(
178-
id="1",
179-
filename="test.png",
180-
size=67,
181-
checksum="sha256:089ad5bf4831b6758e9907db43bc5ebba2e9248a9929dad6132c49932e538278",
182-
created=default_dt,
183-
modified=default_dt,
184-
)
185-
186-
187174
def test_delete_asset(client):
188175
# FIXME: Assert something
189176
client.assets.delete("1")

tests/test_jobs.py

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,6 @@
3939
},
4040
"created": "Mon, 01 Jan 2024 00:00:00 GMT",
4141
"state": "success",
42-
"assets": [asset_json],
4342
"meta": None,
4443
},
4544
{
@@ -51,7 +50,6 @@
5150
},
5251
"created": "Mon, 01 Jan 2024 00:00:00 GMT",
5352
"state": "success",
54-
"assets": [asset_json],
5553
"meta": None,
5654
},
5755
{
@@ -63,7 +61,6 @@
6361
},
6462
"created": "Mon, 01 Jan 2024 00:00:00 GMT",
6563
"state": "success",
66-
"assets": [asset_json],
6764
"meta": None,
6865
},
6966
]
@@ -103,7 +100,8 @@ def do_GET(self):
103100
self.send_response(HTTPStatus.OK)
104101
self.send_header("Content-Type", "application/json")
105102
self.end_headers()
106-
payload = job_list[-1]
103+
payload = deepcopy(job_list[-1])
104+
payload["assets"] = [asset_json]
107105
self.wfile.write(json.dumps(payload).encode())
108106
elif u.path == "/projects/1/jobs/1/status":
109107
global poll_count
@@ -145,7 +143,10 @@ def do_PATCH(self):
145143
self.send_header("Content-Type", "application/json")
146144
self.end_headers()
147145
payload = deepcopy(job_list[-1])
148-
payload["name"] = "baz"
146+
payload.update({
147+
"name": "baz",
148+
"assets": [asset_json],
149+
})
149150
self.wfile.write(json.dumps(payload).encode())
150151
else:
151152
self.send_error(HTTPStatus.NOT_FOUND)

0 commit comments

Comments
 (0)