Skip to content

Commit cff4fd9

Browse files
committed
:fix: fix logic
1 parent 8da2a93 commit cff4fd9

4 files changed

Lines changed: 32 additions & 24 deletions

File tree

package.json

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -46,15 +46,13 @@
4646
]
4747
},
4848
"peerDependencies": {
49-
"@micro-app/cli": ">=0.3.1"
49+
"@micro-app/cli": ">=0.3.5"
5050
},
5151
"devDependencies": {
52-
"@micro-app/cli": "^0.3.1",
52+
"@micro-app/cli": "^0.3.5",
5353
"@micro-app/plugin-deploy": "^0.0.4",
5454
"@types/jest": "^24.9.1",
55-
"babel-eslint": "^10.1.0",
56-
"eslint": "^5.16.0",
57-
"eslint-config-2o3t": "^1.1.17",
55+
"eslint-config-2o3t": "^2.0.1",
5856
"husky": "^3.1.0",
5957
"jest": "^24.9.0",
6058
"lint-staged": "^9.5.0"

src/index.js

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,18 @@
11
'use strict';
22

3-
module.exports = function(api, opts = {}) {
3+
module.exports = function compatible(api, opts = {}) {
44

55
const version = opts.version || 'v1';
66

77
// adapter
88
switch (version.toLowerCase()) {
99
case 'v1':
10-
default: {
11-
require('./v1')(api, opts);
10+
return require('./v1')(api, opts);
11+
default:
1212
break;
13-
}
1413
}
1514

15+
api.logger.warn('[compatible]', `Not Support Version: ${version}`);
16+
17+
return;
1618
};

src/v1/convertHooks.js

Lines changed: 20 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -16,37 +16,43 @@ module.exports = function(api, { hooks, entrys }) {
1616
// 生成模拟插件注册
1717
// hooks
1818
(hooks || []).map(({ key, link, info = {} }) => {
19-
const hook = tryRequire(link);
20-
if (hook && _.isFunction(hook)) {
19+
if (link && tryRequire.resolve(link)) {
2120
const hookName = HOOK_KEY_MAP[key];
2221
if (hookName) {
2322
return {
24-
hookName, hook,
23+
hookName,
2524
info, link, key,
2625
};
2726
}
2827
}
2928
return false;
30-
}).filter(item => !!item).forEach(({ hookName, hook, info, link, key }) => {
29+
}).filter(item => !!item).forEach(({ hookName, info, link, key }) => {
3130
api[hookName](params => {
32-
logger.info('[compatible]', `【 ${info.name} 】Hook inject "${key}"`);
33-
logger.debug('[compatible]', `【 ${info.name} 】Hook inject "${key}" Link: ${link}`);
34-
return hook(params.app, info);
31+
const hook = tryRequire(link);
32+
if (hook && _.isFunction(hook)) {
33+
logger.info('[compatible]', `【 ${info.name} 】Hook inject "${key}"`);
34+
logger.debug('[compatible]', `【 ${info.name} 】Hook inject "${key}" Link: ${link}`);
35+
return hook(params.app, info);
36+
}
37+
return false;
3538
});
3639
});
3740

3841
// entrys
3942
(entrys || []).map(item => {
40-
const entry = tryRequire(item.link);
41-
if (entry && _.isFunction(entry)) {
42-
return { ...item, entry };
43+
if (item && item.link && tryRequire.resolve(item.link)) {
44+
return { ...item };
4345
}
4446
return false;
45-
}).filter(item => !!item).forEach(({ entry, info, link }) => {
47+
}).filter(item => !!item).forEach(({ link, info }) => {
4648
api.onServerEntry(params => {
47-
logger.info(`【 ${info.name} 】Inserted`);
48-
logger.debug(`【 ${info.name} 】Inserted Link: ${link}`);
49-
return entry(params.app, info);
49+
const entry = tryRequire(link);
50+
if (entry && _.isFunction(entry)) {
51+
logger.info(`【 ${info.name} 】Inserted`);
52+
logger.debug(`【 ${info.name} 】Inserted Link: ${link}`);
53+
return entry(params.app, info);
54+
}
55+
return false;
5056
});
5157
});
5258
};

src/v1/index.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,11 +12,13 @@ module.exports = function(api, opts) {
1212
api.modifyChainWebpackConfig((...args) => api.applyPluginHooks('modifyChainWebpcakConfig', ...args));
1313
}
1414

15-
if (opts.server !== false) {
15+
if (opts.server === true) {
1616
const createKoaServer = require('./createKoaServer');
1717
createKoaServer(api);
1818
}
1919

20+
// modify micros: 增加 scope
21+
2022
// 用于兼容老版本的 hooks 和 entrys
2123
api.onInitWillDone(() => {
2224
const serverMerge = require('./lib/merge-server');

0 commit comments

Comments
 (0)