Update descriptions for FilePreviewAllowedDomainList and IsFilePrevie…#1166
Conversation
…wDomainRestrictionEnabled Update descriptions for FilePreviewAllowedDomainList and IsFilePreviewDomainRestrictionEnabled, change delimiter, add restrictions
|
Learn Build status updates of commit b0fb07e: ✅ Validation status: passed
For more details, please refer to the build report. |
PoliCheck Scan ReportThe following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 and severity-2 issues. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans. ✅ No issues foundMore information about PoliCheckInformation: PoliCheck | Severity Guidance | Term |
| ### EXAMPLE 26 | ||
|
|
||
| ```powershell | ||
| Set-SPOTenant -IsFilePreviewDomainRestrictionEnabled $true -FilePreviewAllowedDomainList "contoso.com,fabrikam.com" |
There was a problem hiding this comment.
Sorry, that was by mistake. Thanks for pointing that out.
There was a problem hiding this comment.
@hildar007 actually, I remember seeing this backend PR -- is it related to this one? https://onedrive.visualstudio.com/SharePoint%20Online/_git/SPO.Core/pullrequest/2222153
There was a problem hiding this comment.
Yes, the backend code in this PR support both space and comma as delimiters, before it only supports comma. To avoid confusion from the backend code and the docs getting out of sync, I think use comma here is a safer choice.
There was a problem hiding this comment.
Why change from comma to space in the first place for the backend change? Commas are better understood as separators, and in backend you just break by comma then trim
There was a problem hiding this comment.
Because I find other para like SharingAllowedDomainList is using space, in backend they are break by space and comma now.
There was a problem hiding this comment.
Also, I noticed that the final string I want to pass to embed.aspx happens to be space-delimited, and I didn't want to split and re-join it. But then I realized — since I normalize the string in the helper anyway, it doesn't matter whether the input uses spaces or commas.
…wDomainRestrictionEnabled
…wDomainRestrictionEnabled Corrected the example format for specifying multiple domains in the FilePreviewAllowedDomainList parameter.
PoliCheck Scan ReportThe following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 and severity-2 issues. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans. ✅ No issues foundMore information about PoliCheckInformation: PoliCheck | Severity Guidance | Term |
|
@sachin-lalwani Before this PR can be merged, a Content Lead needs to add the Sign off label to it. Only one of the listed reviewers needs to add the Sign off label. Before you sign off a PR, confirm the following:
After you've confirmed the above, do the following to sign off:
After you've signed off, our operations (PubOps) team will review the PR for issues that may impact formatting and the customer experience. If any changes are needed, they will return When the PR passes PubOps review, they'll merge the PR. If the PR is merged into the main branch, changes will go live within the next couple hours. If you think you were incorrectly added as a reviewer, have questions about this process, or need help signing off on this PR, post a message to https://aka.ms/tcphelp. |
|
Learn Build status updates of commit 6dd7d58: ✅ Validation status: passed
For more details, please refer to the build report. |
PoliCheck Scan ReportThe following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 and severity-2 issues. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans. ✅ No issues foundMore information about PoliCheckInformation: PoliCheck | Severity Guidance | Term |
|
Learn Build status updates of commit 7db0b1c: ✅ Validation status: passed
For more details, please refer to the build report. |
PoliCheck Scan ReportThe following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 and severity-2 issues. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans. ✅ No issues foundMore information about PoliCheckInformation: PoliCheck | Severity Guidance | Term |
|
Learn Build status updates of commit 450db33: ✅ Validation status: passed
For more details, please refer to the build report. |

…wDomainRestrictionEnabled
Update descriptions for FilePreviewAllowedDomainList and IsFilePreviewDomainRestrictionEnabled, change delimiter, add restrictions