Make useless and spammy loggers shush

Author: Matyrobbrt

src/commander/java/com/mcmoddev/mmdbot/commander/TheCommander.java

@@ -218,20 +218,6 @@ public void start() {
             .build();
         EventListeners.COMMANDS_LISTENER.addListener((EventListener) commandClient);
 
-        if (generalConfig.features().tricks().tricksEnabled()) {
-            commandClient.addCommand(new AddTrickCommand.Prefix());
-            commandClient.addCommand(new EditTrickCommand.Prefix());
-            EventListeners.COMMANDS_LISTENER.addListener(ListTricksCommand.getListListener());
-            if (generalConfig.features().tricks().prefixEnabled()) {
-                Tricks.getTricks().stream().map(RunTrickCommand.Prefix::new).forEach(commandClient::addCommand);
-            }
-        }
-
-        if (generalConfig.features().areQuotesEnabled()) {
-            commandClient.addContextMenu(new AddQuoteContextMenu());
-            commandClient.addContextMenu(new UserInfoContextMenu());
-        }
-
         {
             // Command register
             ReflectionsUtils.getFieldsAnnotatedWith(RegisterSlashCommand.class)
@@ -253,6 +239,22 @@ public void start() {
                 .forEach(commandClient::addSlashCommand);
         }
 
+        // Tricks
+        if (generalConfig.features().tricks().tricksEnabled()) {
+            commandClient.addCommand(new AddTrickCommand.Prefix());
+            commandClient.addCommand(new EditTrickCommand.Prefix());
+            EventListeners.COMMANDS_LISTENER.addListener(ListTricksCommand.getListListener());
+            if (generalConfig.features().tricks().prefixEnabled()) {
+                Tricks.getTricks().stream().map(RunTrickCommand.Prefix::new).forEach(commandClient::addCommand);
+            }
+        }
+
+        // Quotes
+        if (generalConfig.features().areQuotesEnabled()) {
+            commandClient.addContextMenu(new AddQuoteContextMenu());
+            commandClient.addContextMenu(new UserInfoContextMenu());
+        }
+
         // Button listeners
         EventListeners.COMMANDS_LISTENER.addListeners(DictionaryCommand.listener, new DismissListener(),
             QuoteCommand.ListQuotes.getQuoteListener(), RolesCommand.getListener());

src/commander/java/com/mcmoddev/mmdbot/commander/commands/QuoteCommand.java

@@ -302,7 +302,7 @@ public class ListQuotes extends PaginatedCommand {
          * Create the command.
          * Sets all the usual flags.
          */
-        public ListQuotes() {
+        private ListQuotes() {
             super("list", "Get all quotes.", true, new ArrayList<>(), 10);
             category = new Category("Fun");
             guildOnly = true;

src/commander/java/com/mcmoddev/mmdbot/commander/commands/tricks/AddTrickCommand.java

@@ -71,7 +71,7 @@ protected void execute(final SlashCommandEvent event) {
             return;
         }
 
-        if (TheCommander.getInstance().getGeneralConfig().features().tricks().tricksEnabled()) {
+        if (!TheCommander.getInstance().getGeneralConfig().features().tricks().tricksEnabled()) {
             event.deferReply(true).setContent("Tricks are not enabled!").queue();
             return;
         }

src/commander/java/com/mcmoddev/mmdbot/commander/tricks/ScriptTrick.java

@@ -29,23 +29,7 @@
 import java.util.Arrays;
 import java.util.List;
 
-// TODO convert to record, and register a record adapter factory to the GSON in `Tricks`
-public final class ScriptTrick implements Trick {
-
-    /**
-     * The Names.
-     */
-    private final List<String> names;
-
-    /**
-     * The Body.
-     */
-    private final String script;
-
-    public ScriptTrick(final List<String> names, final String script) {
-        this.names = names;
-        this.script = script;
-    }
+public record ScriptTrick(List<String> names, String script) implements Trick {
 
     @Override
     public List<String> getNames() {

src/commander/java/com/mcmoddev/mmdbot/commander/tricks/StringTrick.java

@@ -36,28 +36,7 @@
  *
  * @author williambl
  */
-public class StringTrick implements Trick {
-
-    /**
-     * The Names.
-     */
-    private final List<String> names;
-
-    /**
-     * The Body.
-     */
-    private final String body;
-
-    /**
-     * Instantiates a new String trick.
-     *
-     * @param names the names
-     * @param body  the body
-     */
-    public StringTrick(final List<String> names, final String body) {
-        this.names = names;
-        this.body = body;
-    }
+public record StringTrick(List<String> names, String body) implements Trick {
 
     /**
      * Gets names.

src/commander/java/com/mcmoddev/mmdbot/commander/tricks/Tricks.java

@@ -49,8 +49,6 @@
 import java.util.Optional;
 import java.util.function.Supplier;
 
-//TODO: Migrate to a SQLite DB with PR #45
-
 /**
  * The Tricks Module.
  *
@@ -211,8 +209,8 @@ private static void write() {
         Tricks.registerTrickType("script", new ScriptTrick.Type());
 
         GSON = new GsonBuilder()
-            .registerTypeAdapterFactory(new TrickSerializer())
             .registerTypeAdapterFactory(new RecordTypeAdapterFactory())
+            .registerTypeAdapterFactory(new TrickSerializer())
             .create();
     }
 

src/commander/java/com/mcmoddev/mmdbot/commander/util/script/ScriptingUtils.java

@@ -331,7 +331,7 @@ public static ScriptingContext createMember(Member member, boolean canDm) {
         context.set("nickname", member.getNickname());
         context.set("color", member.getColorRaw());
         context.set("timeBoosted", member.getTimeBoosted());
-        context.set("joinTime", member.getTimeJoined()); // TODO replace with the database values
+        context.set("joinTime", member.getTimeJoined());
         context.setFunction("getStatus", a -> member.getOnlineStatus().getKey());
         context.set("activities", member.getActivities().stream().map(a -> createActivity(a).toProxyObject()).toArray(ScriptingContext[]::new));
         context.setFunction("getGuild", a -> createGuild(member.getGuild()).toProxyObject());

src/core/java/com/mcmoddev/mmdbot/core/RunBots.java

@@ -117,7 +117,6 @@ public static void main(String[] a) {
             ServerBridge.setInstance(new ServerBridgeImpl());
             final var dashConfig = getDashboardConfig();
             try {
-                // TODO get the public ipv4 address
                 final var address = new InetSocketAddress("0.0.0.0", dashConfig.port);
                 final var listeners = new ArrayList<PacketListener>();
                 bots.map(b -> b.getType().getPacketListenerUnsafe(b)).forEach(listeners::add);

src/core/java/com/mcmoddev/mmdbot/core/util/event/ThreadedEventListener.java

@@ -20,6 +20,7 @@
  */
 package com.mcmoddev.mmdbot.core.util.event;
 
+import lombok.NonNull;
 import lombok.experimental.Delegate;
 import lombok.extern.slf4j.Slf4j;
 import net.dv8tion.jda.api.EmbedBuilder;
@@ -65,7 +66,7 @@ public ThreadedEventListener(final ExecutorService threadPool, EventListener...
      * @param listener the listener to add
      * @return the current {@link ThreadedEventListener} for chaining conveniences.
      */
-    public ThreadedEventListener addListener(EventListener listener) {
+    public ThreadedEventListener addListener(@NonNull final EventListener listener) {
         this.listeners.add(listener);
         return this;
     }
@@ -76,7 +77,7 @@ public ThreadedEventListener addListener(EventListener listener) {
      * @param listeners the listeners to add
      * @return the current {@link ThreadedEventListener} for chaining conveniences.
      */
-    public ThreadedEventListener addListeners(EventListener... listeners) {
+    public ThreadedEventListener addListeners(@NonNull final EventListener... listeners) {
         this.listeners.addAll(Arrays.asList(listeners));
         return this;
     }
@@ -87,7 +88,7 @@ public ThreadedEventListener addListeners(EventListener... listeners) {
      * @param listeners the listeners to add
      * @return the current {@link ThreadedEventListener} for chaining conveniences.
      */
-    public ThreadedEventListener addListeners(List<EventListener> listeners) {
+    public ThreadedEventListener addListeners(@NonNull List<EventListener> listeners) {
         this.listeners.addAll(listeners);
         return this;
     }
@@ -100,7 +101,9 @@ public ThreadedEventListener addListeners(List<EventListener> listeners) {
     public void onEvent(@Nonnull GenericEvent event) {
         listeners.forEach(listener -> threadPool.execute(() -> {
             try {
-                listener.onEvent(event);
+                if (listener != null) {
+                    listener.onEvent(event);
+                }
             } catch (Exception e) {
                 log.error("Error while executing threaded event!", e);
                 // Reply to the user in order to inform them

src/main/resources/logback.xml

@@ -32,4 +32,13 @@
     <root level="WARN">
         <appender-ref ref="CHANNEL"/>
     </root>
+
+    <!--Disable the weird D4J stuffs -->
+    <logger name="discord4j.gateway.payload.JacksonPayloadReader" level="ERROR" additivity="false" />
+    <!--Make all useless loggers shut up -->
+    <logger name="io.netty.buffer.AbstractByteBufAllocator" level = "WARN" additivity="false" />
+    <logger name="discord4j.rest.request.RequestStream" level = "WARN" additivity="false" />
+    <logger name="reactor.netty.resources.DefaultPooledConnectionProvider" level = "WARN" additivity="false" />
+    <logger name="reactor.netty.ReactorNetty" level = "WARN" additivity="false" />
+    <logger name="io.netty.buffer.PooledByteBufAllocator" level = "WARN" additivity="false" />
 </configuration>