Merge branch 'GEOPY-2793' of github.com:MiraGeoscience/geoapps-utils into GEOPY-2793

Author: benk-mira

geoapps_utils/modelling/plates.py

@@ -115,18 +115,16 @@ def from_maxwell_plate(cls, plate: MaxwellPlate) -> Self:
             raise ValueError("Maxwell plate must have its geometry set.")
         return cls(PlateModel.from_maxwell_plate_geometry(plate.geometry))
 
-    def to_maxwell_plate(
-        self, workspace: Workspace, name: str | None = None
-    ) -> MaxwellPlate:
+    def to_maxwell_plate(self, workspace: Workspace, **plate_kwargs) -> MaxwellPlate:
         """
         Save the Plate as a MaxwellPlate entity in the provided workspace.
 
         :param workspace: Workspace to save the MaxwellPlate in.
-        :param name: Name of the MaxwellPlate entity.
+        :param plate_kwargs: Arguments passed on to the MaxwellPlate instantiation.
         """
         with fetch_active_workspace(workspace) as ws:
             plate = MaxwellPlate.create(
-                ws, name=name, geometry=self.params.to_maxwell_plate_geometry()
+                ws, geometry=self.params.to_maxwell_plate_geometry(), **plate_kwargs
             )
         return plate
 

tests/plates_test.py

@@ -223,13 +223,6 @@ def test_maxwell_plate_integration(tmp_path):
         maxwell_plate.geometry.rotation = 10.0
 
     with pytest.warns(UserWarning, match="Plunging plate"):
-        plate = Plate.from_maxwell_plate(maxwell_plate)
-
-    assert plate.params.strike_length == 100
-    assert plate.params.dip_length == 300
-    assert plate.params.width == 20
-    assert plate.params.easting == 100
-    assert plate.params.northing == 0
-    assert plate.params.elevation == 0
-    assert plate.params.direction == 90
-    assert plate.params.dip == 45
+        new_plate = Plate.from_maxwell_plate(maxwell_plate)
+
+    assert new_plate.params == plate.params