Augment test to check for

Author: domfournier

tests/topography_test.py

@@ -14,14 +14,14 @@
 
 import numpy as np
 
-from simpeg_drivers.components import InversionTopography
+from simpeg_drivers.components import InversionData, InversionMesh, InversionTopography
 from simpeg_drivers.options import ActiveCellsOptions
 from simpeg_drivers.potential_fields import MVIInversionOptions
 from simpeg_drivers.utils.testing import Geoh5Tester, setup_inversion_workspace
 
 
 def test_get_locations(tmp_path: Path):
-    geoh5, entity, model, survey, topography = setup_inversion_workspace(
+    geoh5, mesh, model, survey, topography = setup_inversion_workspace(
         tmp_path,
         background=0.0,
         anomaly=0.05,
@@ -31,7 +31,6 @@ def test_get_locations(tmp_path: Path):
         inversion_type="magnetic_vector",
     )
     with geoh5.open():
-        mesh = model.parent
         tmi_channel, gyz_channel = survey.add_data(
             {
                 "tmi": {"values": np.random.rand(survey.n_vertices)},
@@ -51,6 +50,7 @@ def test_get_locations(tmp_path: Path):
         ),
         starting_model=1.0,
     )
+
     geoh5 = params.geoh5
     with geoh5.open():
         topo = InversionTopography(geoh5, params)
@@ -60,6 +60,25 @@ def test_get_locations(tmp_path: Path):
             params.active_cells.topography.values,
         )
 
+        # Check that boundary cells are handled properly
+        # Shift one of the survey vertices to the corner
+        survey.vertices[0, :] = mesh.centroids[0, :]
+        geoh5.update_attribute(survey, "vertices")
+        inversion_mesh = InversionMesh(geoh5, params)
+        inversion_data = InversionData(geoh5, params)
+        params.inversion_type = "magnetotellurics"
+        active_cells = topo.active_cells(inversion_mesh, inversion_data)
+
+        mesh.add_data(
+            {
+                "active_cells": {
+                    "values": active_cells,
+                }
+            }
+        )
+        assert not active_cells[-1]
+
+        # Test flat topo
         params.active_cells.topography = 199.0
         locs = topo.get_locations(params.active_cells.topography_object)
         np.testing.assert_allclose(locs[:, 2], np.ones_like(locs[:, 2]) * 199.0)