Better checks on valid survey in template.

Augment test

Author: domfournier

simpeg_drivers/plate_simulation/match/driver.py

@@ -26,9 +26,6 @@
 from geoh5py import Workspace
 from geoh5py.groups import PropertyGroup, SimPEGGroup
 from geoh5py.objects import AirborneTEMReceivers, Surface
-from geoh5py.shared.utils import (
-    fetch_active_workspace,
-)
 from geoh5py.ui_json import InputFile
 from scipy import signal
 from scipy.sparse import csr_matrix
@@ -57,20 +54,20 @@ def __init__(
         self._template = self.get_template()
         self._time_mask, self._time_projection = self.time_mask_and_projection()
 
-    def get_template(self):
+    def get_template(self) -> AirborneTEMReceivers:
         """
         Get a template simulation to extract time sampling.
         """
         with Workspace(self.params.simulation_files[0], mode="r") as ws:
             survey = fetch_survey(ws)
-            if survey.channels is None:
+            if not isinstance(survey, AirborneTEMReceivers):
                 raise GeoAppsError(
-                    f"No time channels found in survey of {self.params.simulation_files[0]}"
+                    f"No survey found under Plate Simulation of {self.params.simulation_files[0]}"
                 )
 
-            if survey.vertices is None:
+            if survey.channels is None:
                 raise GeoAppsError(
-                    f"No receiver locations found in survey of {self.params.simulation_files[0]}"
+                    f"No time channels found in survey of {self.params.simulation_files[0]}"
                 )
 
         return survey

tests/plate_simulation/runtest/match_test.py

@@ -11,8 +11,10 @@
 from pathlib import Path
 
 import numpy as np
+import pytest
+from geoapps_utils.utils.importing import GeoAppsError
 from geoh5py import Workspace
-from geoh5py.groups import PropertyGroup
+from geoh5py.groups import PropertyGroup, SimPEGGroup
 from geoh5py.objects import Points
 from geoh5py.ui_json import InputFile
 
@@ -84,6 +86,21 @@ def test_file_parsing(tmp_path: Path):
     assert len(sim_files) == 1
     assert sim_files[0].name == f"{__name__}.geoh5"
 
+    with pytest.raises(GeoAppsError, match="No survey found under Plate Simulation"):
+        PlateMatchDriver(options)
+
+    # Copy the survey as if it was generated by the PlateSimulationDriver
+    with geoh5.open():
+        sim_group = SimPEGGroup.create(geoh5, name="Plate Simulation")
+        survey = geoh5.get_entity("survey")[0]
+        new_survey = survey.copy(parent=sim_group)
+        metadata = survey.metadata
+        metadata["EM Dataset"].pop("Channels")
+        new_survey.metadata = metadata
+
+    with pytest.raises(GeoAppsError, match="No time channels found in survey"):
+        PlateMatchDriver(options)
+
 
 def test_matching_driver(tmp_path: Path):
     """