[GEOPY-2049] augment tests

sebhmg · sebhmg · commit 175d6455a8a5 · 2025-04-13T18:24:02.000-04:00
diff --git a/simpeg_drivers/uijson.py b/simpeg_drivers/uijson.py
@@ -34,13 +34,12 @@ def verify_and_update_version(cls, value: str) -> str:
         input_version = cls.comparable_version(value)
         if input_version != package_version:
             logger.warning(
-                "Provided ui.json file version %s does not match the the current"
-                "simpeg-drivers version %s.  This may lead to unpredictable"
-                "behavior.",
+                "Provided ui.json file version '%s' does not match the current "
+                "simpeg-drivers version '%s'. This may lead to unpredictable behavior.",
                 value,
                 simpeg_drivers.__version__,
             )
-        return input_version
+        return value
 
     @staticmethod
     def comparable_version(value: str) -> str:
@@ -54,10 +53,17 @@ def comparable_version(value: str) -> str:
         For example, if the version is "0.2.0+local", it will return "0.2.0".
         """
         version = Version(value)
-        version.post = None
-        if version.pre is not None and version.pre[0] == "rc":  # pylint: disable=unsubscriptable-object
-            version.pre = None
-        return version.public
+
+        # Extract the base version (major.minor.patch)
+        base_version = version.base_version
+
+        # If it's not an RC, keep any pre-release info (alpha/beta)
+        if version.pre is not None and version.pre[0] != "rc":  # pylint: disable=unsubscriptable-object
+            # Recreate version with pre-release but no post or local
+            return f"{base_version}{version.pre[0]}{version.pre[1]}"
+
+        # No pre-release info or it's an RC, return just the base version
+        return base_version
 
     @classmethod
     def write_default(cls):
diff --git a/tests/uijson_test.py b/tests/uijson_test.py
@@ -14,6 +14,7 @@
 from typing import ClassVar
 
 import numpy as np
+import pytest
 from geoh5py import Workspace
 from geoh5py.ui_json.annotations import Deprecated
 from packaging.version import Version
@@ -35,12 +36,23 @@ def _current_version() -> Version:
     return Version(simpeg_drivers.__version__)
 
 
-def test_version_warning(tmp_path, caplog):
-    workspace = Workspace.create(tmp_path / "test.geoh5")
+@pytest.fixture(name="workspace")
+def workspace_fixture(tmp_path):
+    """Create a workspace for testing."""
+    return Workspace.create(tmp_path / "test.geoh5")
 
-    with caplog.at_level(logging.WARNING):
-        _ = SimPEGDriversUIJson(
-            version="0.2.0",
+
+@pytest.fixture(name="simpeg_uijson_factory")
+def simpeg_uijson_factory_fixture(workspace):
+    """Create a SimPEGDriversUIJson object with configurable version."""
+
+    def _create_uijson(version: str | None = None, **kwargs):
+        """Create a SimPEGDriversUIJson with the given version and custom fields."""
+        if version is None:
+            version = _current_version().public
+
+        return SimPEGDriversUIJson(
+            version=version,
             title="My app",
             icon="",
             documentation="",
@@ -49,8 +61,87 @@ def test_version_warning(tmp_path, caplog):
             monitoring_directory="",
             conda_environment="my-app",
             workspace_geoh5="",
+            **kwargs,
+        )
+
+    return _create_uijson
+
+
+@pytest.mark.parametrize(
+    "version_input,expected",
+    [
+        # Normal version
+        ("1.2.3", "1.2.3"),
+        # Post-release version
+        ("1.2.3.post1", "1.2.3"),
+        # RC pre-release version
+        ("1.2.3rc1", "1.2.3"),
+        # Alpha pre-release version (should not normalize)
+        ("1.2.3a1", "1.2.3a1"),
+        # Beta pre-release version (should not normalize)
+        ("1.2.3b1", "1.2.3b1"),
+        # Local version
+        ("1.2.3+local", "1.2.3"),
+        # Combined cases
+        ("1.2.3rc1.post2+local", "1.2.3"),
+    ],
+)
+def test_comparable_version(version_input, expected):
+    """Test the comparable_version method of SimPEGDriversUIJson."""
+    assert SimPEGDriversUIJson.comparable_version(version_input) == expected
+
+
+@pytest.mark.parametrize(
+    "version_input,package_version,should_warn",
+    [
+        # Different version (should warn)
+        ("1.0.0", "2.0.0", True),
+        # Same version (should not warn)
+        ("2.0.0", "2.0.0", False),
+        # Post-release variant (should not warn)
+        ("2.0.0.post1", "2.0.0", False),
+        ("2.0.0", "2.0.0.post1", False),
+        # RC variant (should not warn)
+        ("2.0.0rc1", "2.0.0", False),
+        ("2.0.0", "2.0.0rc1", False),
+        ("2.0.0rc1", "2.0.0rc2", False),
+        # differ by the pre-release number, non RC (should warn)
+        ("2.0.0a1", "2.0.0a2", True),
+        ("2.0.0b1", "2.0.0b2", True),
+        ("2.0.0a1", "2.0.0", True),
+        ("2.0.0", "2.0.0a1", True),
+        ("2.0.0a1", "2.0.0b1", True),
+        ("2.0.0b1", "2.0.0a1", True),
+        ("2.0.0rc1", "2.0.0b1", True),
+        ("2.0.0b1", "2.0.0rc1", True),
+        # same normalized versions (should not warn)
+        ("2.0.0-beta.1", "2.0.0b1", False),
+        ("2.0.0b1", "2.0.0-beta.1", False),
+    ],
+)
+def test_version_warning(
+    monkeypatch,
+    caplog,
+    simpeg_uijson_factory,
+    version_input,
+    package_version,
+    should_warn,
+):
+    """Test version warning behavior with mocked package version."""
+    # Mock the package version
+    monkeypatch.setattr(simpeg_drivers, "__version__", package_version)
+
+    with caplog.at_level(logging.WARNING):
+        caplog.clear()
+        _ = simpeg_uijson_factory(version=version_input)
+
+        warning_message = f"version '{version_input}' does not match the current simpeg-drivers version"
+        warning_found = any(
+            warning_message in record.message for record in caplog.records
         )
 
+        assert warning_found == should_warn
+
 
 def test_write_default(tmp_path):
     default_path = tmp_path / "default.ui.json"
@@ -75,70 +166,34 @@ class MyUIJson(SimPEGDriversUIJson):
     with open(default_path, encoding="utf-8") as f:
         data = json.load(f)
 
-    assert Version(data["version"]) == Version(_current_version().public)
-
+    # Use comparable_version for comparison to handle pre/post-release versions
+    assert SimPEGDriversUIJson.comparable_version(
+        data["version"]
+    ) == SimPEGDriversUIJson.comparable_version(simpeg_drivers.__version__)
 
-def test_deprecations(tmp_path, caplog):
-    workspace = Workspace.create(tmp_path / "test.geoh5")
 
+def test_deprecations(caplog, simpeg_uijson_factory):
     class MyUIJson(SimPEGDriversUIJson):
         my_param: Deprecated
 
     with caplog.at_level(logging.WARNING):
-        _ = MyUIJson(
-            version=_current_version().public,
-            title="My app",
-            icon="",
-            documentation="",
-            geoh5=str(workspace.h5file),
-            run_command="myapp.driver",
-            monitoring_directory="",
-            conda_environment="my-app",
-            workspace_geoh5="",
-            my_param="whoopsie",
-        )
+        _ = MyUIJson(**simpeg_uijson_factory().model_dump(), my_param="whoopsie")
     assert "Skipping deprecated field: my_param." in caplog.text
 
 
-def test_pydantic_deprecation(tmp_path):
-    workspace = Workspace.create(tmp_path / "test.geoh5")
-
+def test_pydantic_deprecation(simpeg_uijson_factory):
     class MyUIJson(SimPEGDriversUIJson):
         my_param: str = Field(deprecated="Use my_param2 instead.", exclude=True)
 
-    uijson = MyUIJson(
-        version=_current_version().public,
-        title="My app",
-        icon="",
-        documentation="",
-        geoh5=str(workspace.h5file),
-        run_command="myapp.driver",
-        monitoring_directory="",
-        conda_environment="my-app",
-        workspace_geoh5="",
-        my_param="whoopsie",
-    )
+    uijson = MyUIJson(**simpeg_uijson_factory(my_param="whoopsie").model_dump())
     assert "my_param" not in uijson.model_dump()
 
 
-def test_alias(tmp_path):
-    workspace = Workspace.create(tmp_path / "test.geoh5")
-
+def test_alias(simpeg_uijson_factory):
     class MyUIJson(SimPEGDriversUIJson):
         my_param: str = Field(validation_alias=AliasChoices("my_param", "myParam"))
 
-    uijson = MyUIJson(
-        version=_current_version().public,
-        title="My app",
-        icon="",
-        documentation="",
-        geoh5=str(workspace.h5file),
-        run_command="myapp.driver",
-        monitoring_directory="",
-        conda_environment="my-app",
-        workspace_geoh5="",
-        myParam="hello",
-    )
+    uijson = MyUIJson(**simpeg_uijson_factory(myParam="hello").model_dump())
     assert uijson.my_param == "hello"
     assert "myParam" not in uijson.model_fields_set
     assert "my_param" in uijson.model_dump()
