remove aliasing as it breaks tests since collect_from_dict recurses and finds 'plate' and 'overbuden' fields elsewhere in the model.

Author: benk-mira

simpeg_drivers/plate_simulation/models/options.py

@@ -47,7 +47,7 @@ class PlateOptions(BaseModel):
     model_config = ConfigDict(arbitrary_types_allowed=True)
 
     name: str = "Plate"
-    plate_property: float = Field(validation_alias="plate")
+    plate_property: float
     geometry: PlateModel
     number: int = 1
     spacing: float = 0.0
@@ -125,7 +125,7 @@ class OverburdenOptions(BaseModel):
     """
 
     thickness: float
-    overburden_property: float = Field(validation_alias="overburden")
+    overburden_property: float
 
 
 class ModelOptions(BaseModel):

simpeg_drivers/utils/synthetics/driver.py

@@ -80,7 +80,7 @@ def plate(self) -> Surface | None:
     @property
     def mesh(self) -> Octree | DrapeModel:
         if self._mesh is None:
-            entity = self.geoh5.get_entity("mesh")[0]
+            entity = self.geoh5.get_entity(self.options.mesh.name)[0]
             if entity is None:
                 entity = get_mesh(
                     self.options.method,

simpeg_drivers/utils/synthetics/options.py

@@ -13,7 +13,8 @@
 import numpy as np
 from geoapps_utils.modelling.plates import PlateModel
 from geoapps_utils.utils.locations import gaussian
-from geoh5py.objects import ObjectBase, Surface
+from geoh5py.objects import ObjectBase, Points, Surface
+from geoh5py.shared.utils import fetch_active_workspace
 from grid_apps.octree_creation.options import OctreeOptions
 from pydantic import BaseModel, ConfigDict
 
@@ -77,16 +78,20 @@ def octree_params(
 
         :return: OctreeOptions instance ready to be passed to an OctreeDriver.
         """
-        shifted_survey = survey.copy()
-        shifted_survey.vertices = shifted_survey.vertices - np.r_[self.cell_size] / 2.0
+
+        locs = survey.vertices.copy()
+        locs = np.vstack([locs, locs - np.r_[self.cell_size] / 2])
+        with fetch_active_workspace(survey.workspace) as geoh5:
+            survey = Points.create(geoh5, vertices=locs)
+
         refinements = [
             {
                 "refinement_object": survey,
                 "levels": self.survey_refinement,
                 "horizon": False,
             },
             {
-                "refinement_object": shifted_survey,
+                "refinement_object": survey,
                 "levels": self.survey_refinement,
                 "horizon": False,
             },

tests/plate_simulation/runtest/gravity_test.py

@@ -55,11 +55,7 @@ def test_gravity_plate_simulation(tmp_path):
             plate_refinement=[4, 2],
         )
 
-        overburden_params = OverburdenOptions(
-            thickness=50.0,
-            overburden=0.2,  # tests alias handling
-        )
-        assert overburden_params.overburden_property == 0.2
+        overburden_params = OverburdenOptions(thickness=50.0, overburden_property=0.2)
 
         plate_params = PlateOptions(
             name="plate",