Skip to content

Commit 9be1fca

Browse files
committed
add deprecation for old parameters
1 parent e3ab542 commit 9be1fca

3 files changed

Lines changed: 28 additions & 18 deletions

File tree

simpeg_drivers/options.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818

1919
import numpy as np
2020
from geoapps_utils.base import Options
21-
from geoh5py import Workspace
2221
from geoh5py.data import (
2322
BooleanData,
2423
DataAssociationEnum,

simpeg_drivers/plate_simulation/models/options.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,12 @@
1818
BaseModel,
1919
ConfigDict,
2020
Field,
21+
field_validator,
2122
model_validator,
2223
)
2324

25+
from simpeg_drivers.options import Deprecated
26+
2427

2528
class PlateOptions(BaseModel):
2629
"""
@@ -42,6 +45,9 @@ class PlateOptions(BaseModel):
4245
geometry: PlateModel
4346
number: int = 1
4447
spacing: float = 0.0
48+
relative_locations: Deprecated
49+
reference_surface: Deprecated
50+
reference_type: Deprecated
4551

4652
@model_validator(mode="after")
4753
def single_plate(self):

tests/plate_simulation/models/params_test.py

Lines changed: 22 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,8 @@
88
# '
99
# '''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''
1010

11+
import logging
12+
1113
import numpy as np
1214
from geoapps_utils.modelling.plates import PlateModel
1315
from geoh5py import Workspace
@@ -54,24 +56,27 @@ def test_plate_options_center(tmp_path):
5456
assert np.allclose(center, [0.0, 0.0, 20], atol=7e-1)
5557

5658

57-
def test_plate_params(tmp_path):
59+
def test_plate_params(tmp_path, caplog):
5860
workspace = Workspace(tmp_path / "test.geoh5")
59-
params = PlateOptions(
60-
name="my plate",
61-
plate_property=1.0,
62-
geometry=PlateModel(
63-
strike_length=1500.0,
64-
dip_length=400.0,
65-
width=20.0,
66-
easting=10.0,
67-
northing=10.0,
68-
elevation=100.0,
69-
direction=0.0,
70-
dip=90.0,
71-
),
72-
number=1,
73-
spacing=10.0,
74-
)
61+
with caplog.at_level(logging.WARNING):
62+
params = PlateOptions(
63+
name="my plate",
64+
plate_property=1.0,
65+
geometry=PlateModel(
66+
strike_length=1500.0,
67+
dip_length=400.0,
68+
width=20.0,
69+
easting=10.0,
70+
northing=10.0,
71+
elevation=100.0,
72+
direction=0.0,
73+
dip=90.0,
74+
),
75+
number=1,
76+
spacing=10.0,
77+
relative_locations=False,
78+
)
79+
assert "'relative_locations' will be ignored" in caplog.text
7580
assert params.spacing == 0.0
7681

7782
survey = Points.create(

0 commit comments

Comments
 (0)