Skip to content

Commit e132ff7

Browse files
committed
Remove core params from provided by BaseUIJson
1 parent b6e31b9 commit e132ff7

2 files changed

Lines changed: 3 additions & 20 deletions

File tree

simpeg_drivers/uijson.py

Lines changed: 1 addition & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -10,38 +10,19 @@
1010

1111
import json
1212
import logging
13-
from pathlib import Path
14-
from typing import Annotated
1513

16-
from geoh5py.groups import SimPEGGroup, UIJsonGroup
17-
from geoh5py.shared.validators import empty_string_to_none, none_to_empty_string
18-
from geoh5py.ui_json.enforcers import UUIDEnforcer
1914
from geoh5py.ui_json.ui_json import BaseUIJson
20-
from pydantic import BeforeValidator, PlainSerializer, field_validator
15+
from pydantic import field_validator
2116

2217
import simpeg_drivers
2318

2419

2520
logger = logging.getLogger(__name__)
2621

2722

28-
OptionalPath = Annotated[
29-
Path | None,
30-
BeforeValidator(empty_string_to_none),
31-
PlainSerializer(none_to_empty_string),
32-
]
33-
34-
3523
class SimPEGDriversUIJson(BaseUIJson):
36-
version: str = simpeg_drivers.__version__
37-
title: str
3824
icon: str
3925
documentation: str
40-
conda_environment: str
41-
run_command: str
42-
geoh5: Path | None
43-
monitoring_directory: OptionalPath
44-
workspace_geoh5: OptionalPath
4526

4627
@field_validator("version", mode="before")
4728
@classmethod

tests/uijson_test.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,8 @@ def test_version_warning(tmp_path, caplog):
3333
_ = SimPEGDriversUIJson(
3434
version="0.2.0",
3535
title="My app",
36+
icon="",
37+
documentation="",
3638
geoh5=str(workspace.h5file),
3739
run_command="myapp.driver",
3840
monitoring_directory="",

0 commit comments

Comments
 (0)