Skip to content

Commit 169f089

Browse files
Dmitry Dementyevandroid-build-team Robot
authored andcommitted
Protect account chooser activities against overlay.
Bug: 172841550 Test: manual Change-Id: I1a16808426934f4a8d12410576d769443e4c2a04 Merged-In: I3cd5a94386f15cf60a7fe3095b00815e4a6485ae (cherry picked from commit 6ff42dd)
1 parent e57fac5 commit 169f089

3 files changed

Lines changed: 15 additions & 8 deletions

File tree

core/java/android/accounts/ChooseAccountActivity.java

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@
1616
package android.accounts;
1717

1818
import android.app.Activity;
19-
import android.app.ActivityManager;
2019
import android.app.ActivityTaskManager;
2120
import android.content.Context;
2221
import android.content.pm.PackageManager;
@@ -25,8 +24,8 @@
2524
import android.os.Bundle;
2625
import android.os.IBinder;
2726
import android.os.Parcelable;
28-
import android.os.RemoteException;
2927
import android.os.Process;
28+
import android.os.RemoteException;
3029
import android.os.UserHandle;
3130
import android.util.Log;
3231
import android.view.LayoutInflater;
@@ -37,6 +36,7 @@
3736
import android.widget.ImageView;
3837
import android.widget.ListView;
3938
import android.widget.TextView;
39+
4040
import com.android.internal.R;
4141

4242
import java.util.HashMap;
@@ -60,6 +60,9 @@ public class ChooseAccountActivity extends Activity {
6060
@Override
6161
public void onCreate(Bundle savedInstanceState) {
6262
super.onCreate(savedInstanceState);
63+
getWindow().addSystemFlags(
64+
android.view.WindowManager.LayoutParams
65+
.SYSTEM_FLAG_HIDE_NON_SYSTEM_OVERLAY_WINDOWS);
6366
mAccounts = getIntent().getParcelableArrayExtra(AccountManager.KEY_ACCOUNTS);
6467
mAccountManagerResponse =
6568
getIntent().getParcelableExtra(AccountManager.KEY_ACCOUNT_MANAGER_RESPONSE);

core/java/android/accounts/ChooseAccountTypeActivity.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@
3131
import android.widget.ImageView;
3232
import android.widget.ListView;
3333
import android.widget.TextView;
34+
3435
import com.android.internal.R;
3536

3637
import java.util.ArrayList;
@@ -51,7 +52,9 @@ public class ChooseAccountTypeActivity extends Activity {
5152
@Override
5253
public void onCreate(Bundle savedInstanceState) {
5354
super.onCreate(savedInstanceState);
54-
55+
getWindow().addSystemFlags(
56+
android.view.WindowManager.LayoutParams
57+
.SYSTEM_FLAG_HIDE_NON_SYSTEM_OVERLAY_WINDOWS);
5558
if (Log.isLoggable(TAG, Log.VERBOSE)) {
5659
Log.v(TAG, "ChooseAccountTypeActivity.onCreate(savedInstanceState="
5760
+ savedInstanceState + ")");

core/java/android/accounts/ChooseTypeAndAccountActivity.java

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,8 @@
1515
*/
1616
package android.accounts;
1717

18-
import android.app.ActivityTaskManager;
19-
import com.google.android.collect.Sets;
20-
2118
import android.app.Activity;
22-
import android.app.ActivityManager;
19+
import android.app.ActivityTaskManager;
2320
import android.content.Intent;
2421
import android.os.Bundle;
2522
import android.os.IBinder;
@@ -39,6 +36,8 @@
3936

4037
import com.android.internal.R;
4138

39+
import com.google.android.collect.Sets;
40+
4241
import java.io.IOException;
4342
import java.util.ArrayList;
4443
import java.util.HashSet;
@@ -143,7 +142,9 @@ public void onCreate(Bundle savedInstanceState) {
143142
Log.v(TAG, "ChooseTypeAndAccountActivity.onCreate(savedInstanceState="
144143
+ savedInstanceState + ")");
145144
}
146-
145+
getWindow().addSystemFlags(
146+
android.view.WindowManager.LayoutParams
147+
.SYSTEM_FLAG_HIDE_NON_SYSTEM_OVERLAY_WINDOWS);
147148
String message = null;
148149

149150
try {

0 commit comments

Comments
 (0)