Skip to content

Commit cb0b5e2

Browse files
TreeHugger RobotAndroid (Google) Code Review
authored andcommitted
Merge "Revert "DO NOT MERGE - Add AUTOMOTIVE_USER_SETUP_IN_PROGRESS to Settings"" into qt-qpr1-dev
2 parents 5895c90 + db70de3 commit cb0b5e2

5 files changed

Lines changed: 1 addition & 36 deletions

File tree

core/java/android/provider/Settings.java

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -5979,16 +5979,6 @@ public static boolean putFloatForUser(ContentResolver cr, String name, float val
59795979
@TestApi
59805980
public static final String USER_SETUP_COMPLETE = "user_setup_complete";
59815981

5982-
/**
5983-
* Whether the Auto Embedded Setup Wizard (0 = false, 1 = true) is in progress.
5984-
* This differs from USER_SETUP_COMPLETE in that it can be reset back to 0
5985-
* in case Setup Wizard has been re-enabled on Auto Embedded devices.
5986-
*
5987-
* @hide
5988-
*/
5989-
public static final String AUTOMOTIVE_USER_SETUP_IN_PROGRESS =
5990-
"automotive_user_setup_in_progress";
5991-
59925982
/**
59935983
* Indicates that the user has not started setup personalization.
59945984
* One of the possible states for {@link #USER_SETUP_PERSONALIZATION_STATE}.

core/proto/android/providers/settings/secure.proto

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -139,13 +139,6 @@ message SecureSettingsProto {
139139
}
140140
optional AutomaticStorageManager automatic_storage_manager = 9;
141141

142-
message Automotive {
143-
option (android.msg_privacy).dest = DEST_EXPLICIT;
144-
145-
optional SettingProto automotive_user_setup_in_progress = 1 [ (android.privacy).dest = DEST_AUTOMATIC ];
146-
}
147-
optional Automotive automotive = 77;
148-
149142
message Backup {
150143
option (android.msg_privacy).dest = DEST_EXPLICIT;
151144

@@ -573,5 +566,5 @@ message SecureSettingsProto {
573566

574567
// Please insert fields in alphabetical order and group them into messages
575568
// if possible (to avoid reaching the method limit).
576-
// Next tag = 78;
569+
// Next tag = 77;
577570
}

core/tests/coretests/src/android/provider/SettingsBackupTest.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -703,7 +703,6 @@ public class SettingsBackupTest {
703703
Settings.Secure.UNSAFE_VOLUME_MUSIC_ACTIVE_MS,
704704
Settings.Secure.USB_AUDIO_AUTOMATIC_ROUTING_DISABLED,
705705
Settings.Secure.USER_SETUP_COMPLETE,
706-
Settings.Secure.AUTOMOTIVE_USER_SETUP_IN_PROGRESS,
707706
Settings.Secure.USER_SETUP_PERSONALIZATION_STATE,
708707
Settings.Secure.VOICE_INTERACTION_SERVICE,
709708
Settings.Secure.VOICE_RECOGNITION_SERVICE,

packages/SettingsProvider/src/com/android/providers/settings/SettingsProtoDumpUtil.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2411,10 +2411,6 @@ static void dumpProtoSecureSettingsLocked(
24112411
Settings.Secure.USER_SETUP_COMPLETE,
24122412
SecureSettingsProto.USER_SETUP_COMPLETE);
24132413

2414-
dumpSetting(s, p,
2415-
Settings.Secure.AUTOMOTIVE_USER_SETUP_IN_PROGRESS,
2416-
SecureSettingsProto.Automotive.AUTOMOTIVE_USER_SETUP_IN_PROGRESS);
2417-
24182414
final long voiceToken = p.start(SecureSettingsProto.VOICE);
24192415
dumpSetting(s, p,
24202416
Settings.Secure.VOICE_INTERACTION_SERVICE,

packages/SettingsProvider/src/com/android/providers/settings/SettingsProvider.java

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -4449,19 +4449,6 @@ private int onUpgradeLocked(int userId, int oldVersion, int newVersion) {
44494449
currentVersion = 183;
44504450
}
44514451

4452-
if (currentVersion == 183) {
4453-
// Version 169: by default, automotive setup wizard is in progress
4454-
final SettingsState secureSettings = getSecureSettingsLocked(userId);
4455-
Setting currentSetting = secureSettings.getSettingLocked(
4456-
Secure.AUTOMOTIVE_USER_SETUP_IN_PROGRESS);
4457-
if (currentSetting.isNull()) {
4458-
secureSettings.insertSettingLocked(
4459-
Secure.AUTOMOTIVE_USER_SETUP_IN_PROGRESS, "1", null, true,
4460-
SettingsState.SYSTEM_PACKAGE_NAME);
4461-
}
4462-
currentVersion = 184;
4463-
}
4464-
44654452
// vXXX: Add new settings above this point.
44664453

44674454
if (currentVersion != newVersion) {

0 commit comments

Comments
 (0)