Skip to content

Commit 0c33d2f

Browse files
authored
fix: remove redundant heimdallr job from release workflow (#11)
1 parent 33b6f85 commit 0c33d2f

3 files changed

Lines changed: 28 additions & 12 deletions

File tree

.github/workflows/release.yml

Lines changed: 4 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -7,20 +7,13 @@ on:
77
branches:
88
- main
99

10+
permissions: read-all
11+
1012
jobs:
1113
release:
12-
uses: "Mosher-Labs/.github/.github/workflows/release.yml@main"
13-
permissions:
14-
contents: write
15-
16-
heimdallr:
17-
needs: release
18-
if: github.event_name == 'push' && github.ref == 'refs/heads/main'
19-
uses: "Mosher-Labs/.github/.github/workflows/heimdallr.yml@main"
14+
uses: "Mosher-Labs/.github/.github/workflows/release.yml@v0.10.3"
15+
secrets: inherit
2016
permissions:
2117
contents: write
2218
issues: write
2319
pull-requests: write
24-
secrets: inherit
25-
with:
26-
slack_message: "The project <https://github.com/${{ github.repository }}|${{ github.repository }}> just released version <https://github.com/${{ github.repository }}/releases/tag/${{ needs.release.outputs.next_version }}|${{ needs.release.outputs.next_version }}>."

.pre-commit-config.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ repos:
3636
hooks:
3737
- id: actionlint-docker
3838
- repo: https://github.com/bridgecrewio/checkov
39-
rev: 3.2.493
39+
rev: 3.2.494
4040
hooks:
4141
- id: checkov_container
4242
- repo: https://github.com/compilerla/conventional-pre-commit

CLAUDE.md

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -420,6 +420,29 @@ If you need to rebuild the cluster:
420420
- **k3s token:** Generated during server install, not stored in Git
421421
- **Kubeconfig:** Retrieved from server, stored locally (not in Git)
422422

423+
## Git Workflow
424+
425+
1. **Create feature branch:** `git checkout -b feature/description`
426+
1. **Make changes** to playbooks, roles, or documentation
427+
1. **ALWAYS run pre-commit BEFORE committing:** `pre-commit run --all-files`
428+
- Fix ALL errors (especially ansible-lint, yamllint, and markdown)
429+
- Do NOT commit with `--no-verify` unless absolutely necessary
430+
1. **Commit with conventional format:** `git commit -m "type: description"`
431+
1. **Push and create PR:** `gh pr create --title "feat: description"`
432+
1. **Test changes:** If your changes reference shared workflows that were also updated,
433+
temporarily change the reference from `@main` to `@your-branch` to test, verify
434+
the PR passes, then change back to `@main` before merging
435+
1. **Merge to main:** Ansible playbooks are ready to run
436+
437+
**Commit Format:** Conventional Commits (enforced by pre-commit hook)
438+
439+
- `feat:` - New feature or role
440+
- `fix:` - Bug fix
441+
- `docs:` - Documentation changes
442+
- `chore:` - Maintenance
443+
- `refactor:` - Code refactoring
444+
- `test:` - Temporary test changes (like branch references)
445+
423446
## TODO / Future Improvements
424447

425448
- [ ] Setup and configure molecule tests

0 commit comments

Comments
 (0)