Skip to content

Commit 2236baf

Browse files
committed
fix set_package function
1 parent 2a12c0f commit 2236baf

2 files changed

Lines changed: 8 additions & 4 deletions

File tree

src/header_generator.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33

44
def set_package(package: str) -> str:
5-
PACKAGE_REGEX = r"^(?:[a-z_][a-z0-9_]*)(?:\.(?:[a-z_][a-z0-9_]*))*$"
5+
PACKAGE_REGEX = r"^(?:[A-Za-z_][A-Za-z0-9_]*)(?:\.(?:[A-Za-z_][A-Za-z0-9_]*))*$"
66
if not re.match(PACKAGE_REGEX, package):
77
raise ValueError(f"Invalid package: '{package}'")
8-
return f"package {package}"
8+
return f"package {package};"

tests/test_header_generator.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,13 +5,17 @@
55

66
def test_set_package():
77
example = "org.example.hyphenated_name"
8-
expected = f"package {example}"
8+
expected = f"package {example};"
99
assert set_package(example) == expected
1010

1111
example_2 = "com.example._123name"
12-
expected_2 = f"package {example_2}"
12+
expected_2 = f"package {example_2};"
1313
assert set_package(example_2) == expected_2
1414

15+
example_3 = "com.exAmple.Name"
16+
expected_3 = f"package {example_3};"
17+
assert set_package(example_3) == expected_3
18+
1519

1620
def test_set_package_illegal_name():
1721
example = "org.example.hyphenated-name"

0 commit comments

Comments
 (0)