Add network to nostr discovery events

Author: benthecarman

mutiny-core/src/nostr/mod.rs

@@ -14,7 +14,7 @@ use crate::{utils, HTLCStatus};
 use bitcoin::bip32::{ChildNumber, DerivationPath, ExtendedPrivKey};
 use bitcoin::hashes::{sha256, Hash};
 use bitcoin::secp256k1::{Secp256k1, Signing};
-use bitcoin::{hashes::hex::FromHex, secp256k1::ThirtyTwoByteHash};
+use bitcoin::{hashes::hex::FromHex, secp256k1::ThirtyTwoByteHash, Network};
 use fedimint_core::api::InviteCode;
 use fedimint_core::config::FederationId;
 use futures::{pin_mut, select, FutureExt};
@@ -1467,6 +1467,7 @@ impl<S: MutinyStorage> NostrManager<S> {
     pub async fn recommend_federation(
         &self,
         invite_code: &InviteCode,
+        network: Network,
         review: Option<&str>,
     ) -> Result<EventId, MutinyError> {
         let kind = Kind::from(38000);
@@ -1478,6 +1479,12 @@ impl<S: MutinyStorage> NostrManager<S> {
             vec!["38173".to_string()],
         );
 
+        // tag the network
+        let n_tag = Tag::Generic(
+            TagKind::SingleLetter(SingleLetterTag::lowercase(Alphabet::N)),
+            vec![network_to_string(network).to_string()],
+        );
+
         // tag the federation invite code
         let invite_code_tag = Tag::Generic(
             TagKind::SingleLetter(SingleLetterTag::lowercase(Alphabet::U)),
@@ -1489,7 +1496,7 @@ impl<S: MutinyStorage> NostrManager<S> {
         let builder = EventBuilder::new(
             kind,
             review.unwrap_or_default(),
-            [d_tag, k_tag, invite_code_tag],
+            [d_tag, k_tag, invite_code_tag, n_tag],
         );
 
         // send the event
@@ -1512,7 +1519,10 @@ impl<S: MutinyStorage> NostrManager<S> {
     }
 
     /// Queries our relays for federation announcements
-    pub async fn discover_federations(&self) -> Result<Vec<NostrDiscoveredFedimint>, MutinyError> {
+    pub async fn discover_federations(
+        &self,
+        network: Network,
+    ) -> Result<Vec<NostrDiscoveredFedimint>, MutinyError> {
         // get contacts by npub
         let mut npubs: HashMap<nostr::PublicKey, Contact> = self
             .storage
@@ -1552,6 +1562,8 @@ impl<S: MutinyStorage> NostrManager<S> {
             }
         }
 
+        let network_str = network_to_string(network);
+
         // filter for finding mint announcements
         let mints = Filter::new().kind(Kind::from(38173));
         // filter for finding federation recommendations from trusted people
@@ -1564,6 +1576,7 @@ impl<S: MutinyStorage> NostrManager<S> {
             .kind(Kind::from(38000))
             .custom_tag(SingleLetterTag::lowercase(Alphabet::K), ["38173"])
             .limit(NUM_TRUSTED_USERS as usize);
+
         // fetch events
         let events = self
             .client
@@ -1581,6 +1594,24 @@ impl<S: MutinyStorage> NostrManager<S> {
                     return None;
                 }
 
+                let network_tag = event.tags.iter().find_map(|tag| {
+                    if tag.kind() == TagKind::SingleLetter(SingleLetterTag::lowercase(Alphabet::N))
+                    {
+                        Some(tag.as_vec().get(1).cloned().unwrap_or_default())
+                    } else {
+                        None
+                    }
+                });
+
+                // if the network tag is missing, we assume it is on mainnet
+                let network_tag = network_tag
+                    .as_deref()
+                    .unwrap_or(network_to_string(Network::Bitcoin));
+                // skip if the network doesn't match
+                if network_tag != network_str {
+                    return None;
+                }
+
                 let federation_id = event.tags.iter().find_map(|tag| {
                     if let Tag::Identifier(id) = tag {
                         FederationId::from_str(id).ok()
@@ -1642,6 +1673,19 @@ impl<S: MutinyStorage> NostrManager<S> {
                 None => continue,
             };
 
+            let network_tag = event.tags.iter().find_map(|tag| {
+                if tag.kind() == TagKind::SingleLetter(SingleLetterTag::lowercase(Alphabet::N)) {
+                    Some(tag.as_vec().get(1).cloned().unwrap_or_default())
+                } else {
+                    None
+                }
+            });
+
+            // skip if the network doesn't match
+            if network_tag.is_none() || network_tag.unwrap() != network_str {
+                continue;
+            }
+
             let invite_codes = event
                 .tags
                 .iter()
@@ -1833,6 +1877,16 @@ fn get_next_nwc_index(
     Ok((name, index, child_key_index))
 }
 
+fn network_to_string(network: Network) -> &'static str {
+    match network {
+        Network::Bitcoin => "mainnet",
+        Network::Testnet => "testnet",
+        Network::Signet => "signet",
+        Network::Regtest => "regtest",
+        net => unreachable!("Unknown network {net}!"),
+    }
+}
+
 #[cfg(not(target_arch = "wasm32"))]
 #[cfg(test)]
 mod test {

mutiny-wasm/src/lib.rs

@@ -1241,7 +1241,7 @@ impl MutinyWallet {
         let event_id = self
             .inner
             .nostr
-            .recommend_federation(&invite_code, review.as_deref())
+            .recommend_federation(&invite_code, self.inner.get_network(), review.as_deref())
             .await?;
         Ok(event_id.to_hex())
     }
@@ -1264,7 +1264,11 @@ impl MutinyWallet {
     pub async fn discover_federations(
         &self,
     ) -> Result<JsValue /* Vec<NostrDiscoveredFedimint> */, MutinyJsError> {
-        let federations = self.inner.nostr.discover_federations().await?;
+        let federations = self
+            .inner
+            .nostr
+            .discover_federations(self.inner.get_network())
+            .await?;
         Ok(JsValue::from_serde(&federations)?)
     }