Merge pull request #1128 from MutinyWallet/lots-o-tests

Tests for lots new nostr functionality

Author: benthecarman

mutiny-core/src/lib.rs

@@ -46,6 +46,7 @@ mod test_utils;
 pub use crate::gossip::{GOSSIP_SYNC_TIME_KEY, NETWORK_GRAPH_KEY, PROB_SCORER_KEY};
 pub use crate::keymanager::generate_seed;
 pub use crate::ldkstorage::{CHANNEL_CLOSURE_PREFIX, CHANNEL_MANAGER_KEY, MONITORS_PREFIX_KEY};
+use crate::nostr::primal::{PrimalApi, PrimalClient};
 use crate::storage::{
     get_payment_hash_from_key, list_payment_info, persist_payment_info, update_nostr_contact_list,
     IndexItem, MutinyStorage, DEVICE_ID_KEY, EXPECTED_NETWORK_KEY, NEED_FULL_SYNC_KEY,
@@ -109,7 +110,7 @@ use moksha_core::primitives::{
     PostMeltQuoteBolt11Response,
 };
 use moksha_core::token::TokenV3;
-use nostr_sdk::{NostrSigner, RelayPoolNotification};
+use nostr_sdk::{Client, NostrSigner, RelayPoolNotification};
 use reqwest::multipart::{Form, Part};
 use serde::{Deserialize, Serialize};
 use serde_json::Value;
@@ -848,15 +849,28 @@ impl<S: MutinyStorage> MutinyWalletBuilder<S> {
         // start syncing node manager
         NodeManager::start_sync(node_manager.clone());
 
+        let primal_client = PrimalClient::new(
+            config
+                .primal_url
+                .clone()
+                .unwrap_or("https://primal-cache.mutinywallet.com/api".to_string()),
+        );
+
+        let client = Client::default();
+
         // create nostr manager
-        let nostr = Arc::new(NostrManager::from_mnemonic(
-            self.xprivkey,
-            self.nostr_key_source,
-            self.storage.clone(),
-            config.primal_url.clone(),
-            logger.clone(),
-            stop.clone(),
-        )?);
+        let nostr = Arc::new(
+            NostrManager::from_mnemonic(
+                self.xprivkey,
+                self.nostr_key_source,
+                self.storage.clone(),
+                primal_client,
+                client,
+                logger.clone(),
+                stop.clone(),
+            )
+            .await?,
+        );
 
         // connect to relays when not in tests
         #[cfg(not(test))]
@@ -1099,7 +1113,7 @@ pub struct MutinyWallet<S: MutinyStorage> {
     config: MutinyWalletConfig,
     pub(crate) storage: S,
     pub node_manager: Arc<NodeManager<S>>,
-    pub nostr: Arc<NostrManager<S>>,
+    pub nostr: Arc<NostrManager<S, PrimalClient, nostr_sdk::Client>>,
     pub federation_storage: Arc<RwLock<FederationStorage>>,
     pub(crate) federations: Arc<RwLock<HashMap<FederationId, Arc<FederationClient<S>>>>>,
     lnurl_client: Arc<LnUrlClient>,
@@ -1172,7 +1186,7 @@ impl<S: MutinyStorage> MutinyWallet<S> {
                     log_warn!(logger, "Failed to clear invalid NWC invoices: {e}");
                 }
 
-                let client = &nostr.client;
+                let client = nostr_sdk::Client::default();
 
                 client
                     .add_relays(nostr.get_relays())

mutiny-core/src/nostr/client.rs

@@ -0,0 +1,109 @@
+use nostr::{Event, EventBuilder, EventId, Filter, PublicKey, SubscriptionId};
+use nostr_sdk::client::Error;
+use nostr_sdk::{NostrSigner, SubscribeAutoCloseOptions};
+use std::time::Duration;
+
+#[cfg_attr(test, mockall::automock)]
+pub trait NostrClient {
+    async fn add_relays(&self, relays: Vec<String>) -> nostr::Result<(), Error>;
+    async fn add_relay(&self, relay: &str) -> nostr::Result<bool, Error>;
+    async fn connect_relay(&self, relay: &str) -> nostr::Result<(), Error>;
+    async fn connect(&self);
+    async fn disconnect(&self) -> nostr::Result<(), Error>;
+
+    async fn sign_event_builder(&self, builder: EventBuilder) -> nostr::Result<Event, Error>;
+    async fn send_event_builder(&self, builder: EventBuilder) -> nostr::Result<EventId, Error>;
+    async fn send_event(&self, event: Event) -> nostr::Result<EventId, Error>;
+    async fn send_event_to(&self, urls: Vec<String>, event: Event)
+        -> nostr::Result<EventId, Error>;
+    async fn send_direct_msg(
+        &self,
+        receiver: PublicKey,
+        msg: String,
+        reply_to: Option<EventId>,
+    ) -> nostr::Result<EventId, Error>;
+
+    async fn subscribe(
+        &self,
+        filters: Vec<Filter>,
+        opts: Option<SubscribeAutoCloseOptions>,
+    ) -> SubscriptionId;
+    async fn get_events_of(
+        &self,
+        filters: Vec<Filter>,
+        timeout: Option<Duration>,
+    ) -> Result<Vec<Event>, Error>;
+
+    async fn set_signer(&self, signer: Option<NostrSigner>);
+}
+
+impl NostrClient for nostr_sdk::Client {
+    async fn add_relays(&self, relays: Vec<String>) -> nostr::Result<(), Error> {
+        self.add_relays(relays).await
+    }
+
+    async fn add_relay(&self, relay: &str) -> nostr::Result<bool, Error> {
+        self.add_relay(relay).await
+    }
+
+    async fn connect_relay(&self, relay: &str) -> nostr::Result<(), Error> {
+        self.connect_relay(relay).await
+    }
+
+    async fn connect(&self) {
+        self.connect().await
+    }
+
+    async fn disconnect(&self) -> nostr::Result<(), Error> {
+        self.disconnect().await
+    }
+
+    async fn sign_event_builder(&self, builder: EventBuilder) -> nostr::Result<Event, Error> {
+        self.sign_event_builder(builder).await
+    }
+
+    async fn send_event_builder(&self, builder: EventBuilder) -> nostr::Result<EventId, Error> {
+        self.send_event_builder(builder).await
+    }
+
+    async fn send_event(&self, event: Event) -> nostr::Result<EventId, Error> {
+        self.send_event(event).await
+    }
+
+    async fn send_event_to(
+        &self,
+        urls: Vec<String>,
+        event: Event,
+    ) -> nostr::Result<EventId, Error> {
+        self.send_event_to(urls, event).await
+    }
+
+    async fn send_direct_msg(
+        &self,
+        receiver: PublicKey,
+        msg: String,
+        reply_to: Option<EventId>,
+    ) -> nostr::Result<EventId, Error> {
+        self.send_direct_msg(receiver, msg, reply_to).await
+    }
+
+    async fn subscribe(
+        &self,
+        filters: Vec<Filter>,
+        opts: Option<SubscribeAutoCloseOptions>,
+    ) -> SubscriptionId {
+        self.subscribe(filters, opts).await
+    }
+
+    async fn get_events_of(
+        &self,
+        filters: Vec<Filter>,
+        timeout: Option<Duration>,
+    ) -> Result<Vec<Event>, Error> {
+        self.get_events_of(filters, timeout).await
+    }
+
+    async fn set_signer(&self, signer: Option<NostrSigner>) {
+        self.set_signer(signer).await
+    }
+}