updated to ensure all tests pass on linux, this was due to OpenGL and WebGPU contexts clashing and needing to order tests into sub test suites, see conftest for more details

Author: jmacey

src/ncca/ngl/vec3.py

@@ -84,11 +84,9 @@ def __matmul__(self, rhs):
         Returns:
             Vec3: A new vector that is the result of multiplying this vector by the matrix.
         """
-        return Vec3(
-            self._data[0] * rhs.m[0, 0] + self._data[1] * rhs.m[1, 0] + self._data[2] * rhs.m[2, 0],
-            self._data[0] * rhs.m[0, 1] + self._data[1] * rhs.m[1, 1] + self._data[2] * rhs.m[2, 1],
-            self._data[0] * rhs.m[0, 2] + self._data[1] * rhs.m[1, 2] + self._data[2] * rhs.m[2, 2],
-        )
+        result = Vec3()
+        result._data = rhs.m.T @ self._data  # More efficient
+        return result
 
     def set(self, *args: float) -> None:
         """

tests/conftest.py

@@ -1,10 +1,38 @@
+import gc
+
 import glfw
 import OpenGL.GL as gl
 import pytest
 import wgpu
 import wgpu.utils
 
 
+def pytest_collection_modifyitems(config, items):
+    """
+    Ensure WebGPU tests run before OpenGL tests to avoid context conflicts
+    This is fine on mac as both are Metal backends.
+    """
+
+    opengl_tests = []
+    webgpu_tests = []
+    other_tests = []
+
+    for item in items:
+        fixtures = getattr(item, "fixturenames", [])
+        if "opengl_context" in fixtures or any("opengl" in f for f in fixtures):
+            opengl_tests.append(item)
+        elif "webgpu_device" in fixtures or any("webgpu" in f for f in fixtures):
+            webgpu_tests.append(item)
+        else:
+            other_tests.append(item)
+
+    # Reorder:  Other -> WebGPU -> OpenGL this avoids context conflicts on Linux
+    # WebGPU cleans nicely OpenGL not so much!
+    items[:] = other_tests + webgpu_tests + opengl_tests
+
+    print(f"\nTest execution order: {len(opengl_tests)} OpenGL, {len(other_tests)} Other, {len(webgpu_tests)} WebGPU")
+
+
 @pytest.fixture(scope="session")
 def opengl_context():
     if not glfw.init():
@@ -34,3 +62,5 @@ def webgpu_device():
     if device is None:
         raise RuntimeError("Could not get a WebGPU device.")
     yield device
+    del device
+    gc.collect()