Skip to content

Clean up small issues in the elasticsearch role #491

Description

@afeefghannam89

Minor code-quality issues found while documenting the elasticsearch role. Relates to #396.

1. Typo elaticsearch_cluster_set_up (missing "s") — set in tasks/main.yml and tasks/elasticsearch-security.yml, read in templates/elasticsearch.yml.j2. Consistently misspelled so it works, but fragile (fixing one occurrence breaks it). Rename to elasticsearch_cluster_set_up everywhere.

2. Stray # test on line 1 of templates/elasticsearch.yml.j2 — leftover, remove it.

3. elasticstack_temperature is misnamed and undocumented — used only by this role (node.attr.temp) but carries the shared elasticstack_* prefix, so it falls outside both the role's argument_specs.yml and the shared-variables doc. Rename to elasticsearch_temperature and document it (optionally switch node.attr.temp to data-tier node.roles). Breaking; also relates to #485.

Metadata

Metadata

Assignees

No one assigned

    Labels

    breaking-changePR / Issue / Fix that will implement a breaking change!qualityChanges that will not affect the technical details, but add some more quality to the code, docs, ...

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions