From 6e8eca09ffd1f3ffff35298deb6a2fe52c41b885 Mon Sep 17 00:00:00 2001 From: Aaron Erickson Date: Thu, 16 Jul 2026 19:10:38 -0700 Subject: [PATCH] fix(ci): omit null conclusion from check update Signed-off-by: Aaron Erickson --- test/pr-e2e-gate-fork-skip.test.ts | 2 +- test/pr-e2e-gate-retry-history.test.ts | 2 +- tools/e2e/pr-e2e-gate.mts | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/test/pr-e2e-gate-fork-skip.test.ts b/test/pr-e2e-gate-fork-skip.test.ts index 97e95b0b2e..bba9f7f9d0 100644 --- a/test/pr-e2e-gate-fork-skip.test.ts +++ b/test/pr-e2e-gate-fork-skip.test.ts @@ -1240,12 +1240,12 @@ describe("PR E2E controller fork credentialed E2E skip approval safety", () => { expect(restoredAuthorizations).toHaveLength(2); expect(restoredAuthorizations[0]?.body).toMatchObject({ status: "in_progress", - conclusion: null, output: { title: "Maintainer authorization required to run E2E", summary: expect.stringContaining("launch a fresh first-attempt `run-control-plane`"), }, }); + expect(restoredAuthorizations[0]?.body).not.toHaveProperty("conclusion"); expect(checkTitle).toBe("Maintainer authorization required to run E2E"); expect(requests.some((request) => request.url.endsWith("/dispatches"))).toBe(false); } finally { diff --git a/test/pr-e2e-gate-retry-history.test.ts b/test/pr-e2e-gate-retry-history.test.ts index f2759b5f66..9ebf3f8448 100644 --- a/test/pr-e2e-gate-retry-history.test.ts +++ b/test/pr-e2e-gate-retry-history.test.ts @@ -246,7 +246,6 @@ describe("PR E2E controller retry history", () => { .at(-1); expect(completion?.body).toMatchObject({ status: "in_progress", - conclusion: null, output: { title: "Maintainer authorization required to run E2E", summary: expect.stringContaining( @@ -254,6 +253,7 @@ describe("PR E2E controller retry history", () => { ), }, }); + expect(completion?.body).not.toHaveProperty("conclusion"); expect(checkRuns[0]).toEqual(completedCheck); expect(checkRuns[1]).toMatchObject({ id: 18, diff --git a/tools/e2e/pr-e2e-gate.mts b/tools/e2e/pr-e2e-gate.mts index a794ebfa79..86e2a002db 100755 --- a/tools/e2e/pr-e2e-gate.mts +++ b/tools/e2e/pr-e2e-gate.mts @@ -1057,7 +1057,7 @@ async function markCheckInProgress( token, { method: "PATCH", - body: { status: "in_progress", conclusion: null, output: { title, summary } }, + body: { status: "in_progress", output: { title, summary } }, userAgent: USER_AGENT, }, );