Remove redundant Promise.resolve/reject calls

Author: nonword

lib/client.js

@@ -236,7 +236,7 @@ class Client {
 
     // Disallow non-object body if json enabled:
     if (options.json && options.body && (typeof options.body) !== 'object') {
-      return Promise.reject(new RequestError(`Attempted to ${method} with options.json==true, but body is a ${typeof options.body}`))
+      throw new RequestError(`Attempted to ${method} with options.json==true, but body is a ${typeof options.body}`)
     }
 
     const uri = this._getFullUrl(path)
@@ -252,7 +252,7 @@ class Client {
 
     let cached = null
     if (options.cache && (cached = this.cache.get(cacheKey))) {
-      return Promise.resolve(cached)
+      return cached
     } else {
       // Build request-specific options
       const requestOptions = {
@@ -328,11 +328,11 @@ class Client {
 
     // Handle token expiration:
     if (resp.status === 401) {
-      return Promise.reject(new TokenExpirationError('Detected token expiration fetching ' + options.uri))
+      throw new TokenExpirationError('Detected token expiration fetching ' + options.uri)
 
     // Throw an error on error response?
     } else if (!resp.ok && options.throwForStatus) {
-      return Promise.reject(new ResponseError(`Invalid response: for ${options.uri}: "${JSON.stringify(options.body)}"`))
+      throw new ResponseError(`Invalid response: for ${options.uri}: "${JSON.stringify(options.body)}"`)
 
     // Ok response:
     } else {

test/bib-test.js

@@ -11,8 +11,6 @@ describe('Bib test', function () {
 
   describe('Bibs endpoint', function () {
     it('should return a Bib', async () => {
-      console.log('(inside test) Stubbed fetch? ', fetch, !!fetch.restore)
-
       const resp = await client.get('bibs/sierra-nypl/17746307', { authenticate: true })
       expect(resp.data).to.be.a('object')
       expect(resp.data).to.have.a.property('id', '17746307')