Pass in all kwargs from PostgreSQLClient to the ConnectionPool

This allows for the py-utils developer to set any psql settings, such as max_idle.

Author: aaronfriedman6

src/nypl_py_utils/classes/postgresql_client.py

@@ -19,11 +19,10 @@ def __init__(self, host, port, db_name, user, password, **kwargs):
                           '{db_name}').format(user=user, password=password,
                                               host=host, port=port,
                                               db_name=db_name)
-        self.min_size = kwargs.get('min_size', 0)
-        self.max_size = kwargs.get('max_size', 1)
-        self.pool = ConnectionPool(
-            self.conn_info, open=False,
-            min_size=self.min_size, max_size=self.max_size)
+        self.kwargs = kwargs
+        self.kwargs['min_size'] = kwargs.get('min_size', 0)
+        self.kwargs['max_size'] = kwargs.get('max_size', 1)
+        self.pool = ConnectionPool(self.conn_info, open=False, **self.kwargs)
 
     def connect(self):
         """
@@ -34,8 +33,7 @@ def connect(self):
         try:
             if self.pool is None:
                 self.pool = ConnectionPool(
-                    self.conn_info, open=False, min_size=self.min_size,
-                    max_size=self.max_size)
+                    self.conn_info, open=False, **self.kwargs)
             self.pool.open(wait=True, timeout=self.timeout)
         except psycopg.Error as e:
             self.logger.error(

tests/test_postgresql_client.py

@@ -24,13 +24,14 @@ def test_init(self, test_instance):
     def test_init_with_kwargs(self):
         test_instance = PostgreSQLClient(
             'test_host', 'test_port', 'test_db_name', 'test_user',
-            'test_password', min_size=5, max_size=10)
+            'test_password', min_size=5, max_size=10, max_idle=15.0)
         assert test_instance.pool.conninfo == (
             'postgresql://test_user:test_password@test_host:test_port/' +
             'test_db_name')
         assert test_instance.pool._opened is False
         assert test_instance.pool.min_size == 5
         assert test_instance.pool.max_size == 10
+        assert test_instance.pool.max_idle == 15.0
 
     def test_connect(self, test_instance):
         test_instance.connect()